Date:   Fri, 17 Feb 2023 09:50:52 -0500
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Suren Baghdasaryan <surenb@google.com>
Cc:     akpm@linux-foundation.org, michel@lespinasse.org,
        jglisse@google.com, mhocko@suse.com, vbabka@suse.cz,
        hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net,
        willy@infradead.org, peterz@infradead.org, ldufour@linux.ibm.com,
        paulmck@kernel.org, mingo@redhat.com, will@kernel.org,
        luto@kernel.org, songliubraving@fb.com, peterx@redhat.com,
        david@redhat.com, dhowells@redhat.com, hughd@google.com,
        bigeasy@linutronix.de, kent.overstreet@linux.dev,
        punit.agrawal@bytedance.com, lstoakes@gmail.com,
        peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com,
        axelrasmussen@google.com, joelaf@google.com, minchan@google.com,
        rppt@kernel.org, jannh@google.com, shakeelb@google.com,
        tatashin@google.com, edumazet@google.com, gthelen@google.com,
        gurua@google.com, arjunroy@google.com, soheil@google.com,
        leewalsh@google.com, posk@google.com,
        michalechner92@googlemail.com, linux-mm@kvack.org,
        linux-arm-kernel@lists.infradead.org,
        linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v3 21/35] mm/mmap: write-lock adjacent VMAs if they can
 grow into unmapped area
Message-ID: <20230217145052.y526nmjudi6t2ael@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Suren Baghdasaryan <surenb@google.com>, akpm@linux-foundation.org,
        michel@lespinasse.org, jglisse@google.com, mhocko@suse.com,
        vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net,
        dave@stgolabs.net, willy@infradead.org, peterz@infradead.org,
        ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com,
        will@kernel.org, luto@kernel.org, songliubraving@fb.com,
        peterx@redhat.com, david@redhat.com, dhowells@redhat.com,
        hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev,
        punit.agrawal@bytedance.com, lstoakes@gmail.com,
        peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com,
        axelrasmussen@google.com, joelaf@google.com, minchan@google.com,
        rppt@kernel.org, jannh@google.com, shakeelb@google.com,
        tatashin@google.com, edumazet@google.com, gthelen@google.com,
        gurua@google.com, arjunroy@google.com, soheil@google.com,
        leewalsh@google.com, posk@google.com, michalechner92@googlemail.com,
        linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
        linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, kernel-team@android.com
References: <20230216051750.3125598-1-surenb@google.com>
 <20230216051750.3125598-22-surenb@google.com>
 <20230216153405.zo4l2lqpnc2agdzg@revolver>
 <CAJuCfpEkujbHNxNWcWr8bmrsMhXGcpDyraOfQaPAcOH=RQPv5A@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJuCfpEkujbHNxNWcWr8bmrsMhXGcpDyraOfQaPAcOH=RQPv5A@mail.gmail.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l+Hg+brjRuBCZU7F10OMsrSzkiIekQnMNduF+BzypA+H3AuGi9SxeZ0TLFk6?=
 =?us-ascii?Q?lgbaVZGqtL7BKkL8Gt24JV+am9GZr47bx8k4VzMi/IxNdnVmXtc9OpUMgm1V?=
 =?us-ascii?Q?gG8VfmtTPUhPjfsHUb//Qahk7mgBSYvRQ9hM4iP6DGOrLJWCrzAFZQrLDjwb?=
 =?us-ascii?Q?uV/vixs+H9WmDf6ddNb2Kg8jXvAEAO21+EyLLKXWukvDF//EoZJ5+pQ8nbgT?=
 =?us-ascii?Q?AgF4RqZRC3sNcBvpSDsESqQyHqfpKm7pq07JIldhBhMKgm7/EdkzIJJWmXQp?=
 =?us-ascii?Q?Na/Gzeb+7SCKI/KZVVM3keFZwdn9uGit0jeHzKbMe6aQqidgRuxEad1wkyw0?=
 =?us-ascii?Q?NdNjmBbNk1RkjmBVX4rwAKFHTn/olsMlvm4tOTj0cxJqDq2YYlasd9PKe7IM?=
 =?us-ascii?Q?ggzB3uoK1K+F/eE/HKlaE4fOt/o65qX+qlRFhmXh5fy3UxaJRCrO7aYY6vsB?=
 =?us-ascii?Q?tVqPu1yImEjNUPb+nR831lN6lxA+tc6wtuktQCSvmBrEItRI7nPl4LrgNaq5?=
 =?us-ascii?Q?8Yyl/cwtCqD7jIRnfQtPIqqitpAsg3Csd5YKGmzGnNN0+eV8JhY70Deal1LY?=
 =?us-ascii?Q?LV1cY06fQepqQfNmDg1z7YKMxpp7BsI26pKtWmKzxYPxfQ4CEV2pttnwzHRp?=
 =?us-ascii?Q?ik5s0YHFLTICqwlhY65c0V6Z0ygDAePh4AUj0+KNZg+lAgMfLHKLzKUtXMvB?=
 =?us-ascii?Q?A7LMUcR9Dik8VSTCc6O3Rn2vpkxjzV6OLzjOdGozhxiIhCKTvXWMg6wSyCa+?=
 =?us-ascii?Q?2Gm4ysCo5ILxexuVeDiDsFsbWflnq3e6RcP4b8ZofXohTmhBKj1Oi9Fpb88a?=
 =?us-ascii?Q?W6TAtA00ofKZ0KCp+uZlH7wUMdKp/9kdDZQb/50SOLQ4L90vwmSc9SEntxMP?=
 =?us-ascii?Q?jKOhZFNRcguuAkfa3/1LpcPKG4cIj7xf4xm/rnheV9Tdgtno60FQVsa1Qplh?=
 =?us-ascii?Q?iKu+CJTbcmwDMo7k0d70Wb0+rpEckqXgMQLyRFDRDlf7fwkwbBCWs5d/EbOE?=
 =?us-ascii?Q?ZcwQkhZ3Rpo6LTzwABVvkIcEs5rllLGzuVEog2fNcvWMGF9iCSrvEsHlB36I?=
 =?us-ascii?Q?RlF79zs8jF+rkYQffNBn0XCPbV4tNRO3zsg4U9xzJrwmY5NGsO1rzC7U80fJ?=
 =?us-ascii?Q?cW7JiGp8B7Rzmw2qtPKAW229dTzCAK97fEwByT8EXp4qjfSBi3/+Tx7UJ3AO?=
 =?us-ascii?Q?0xpLxTRnQF5VA6ObfbezlAtlH/cKv5E1Qw5clEr05A18UHEtjOdNMgn6Jn2b?=
 =?us-ascii?Q?jor84O5rvjgTCcxkuIMebKaCyyyTNj9U7Lklw9YO3DLwbRzkkpXIZb2qy8EK?=
 =?us-ascii?Q?pjSGj7KntYRKBLV5O14M+Gd/ATjUIAhnNRL4NC4YtgYMj+FGTsnUFFCdSyv1?=
 =?us-ascii?Q?EQlV7dkb91VrlpfeW8419OEt9vvhPzANoYfBvlDKBdC0aAVmLlzg4Lwkk6hP?=
 =?us-ascii?Q?HEsJ5uogKW9xaD5aqSAXqbzxuys+FadkcK3J1vl2SAd5voNOHbsLOyG7zzHF?=
 =?us-ascii?Q?LfePnJYeUwGZMf6xX6Wbv2mHTsdnO6KopZgO+ESdOL/QjRzwMiknoPkJLkG0?=
 =?us-ascii?Q?+ai0gfLQzqO3XAoSqKLpWvUuLUSRNvfnHIldy2xyFlmzYeqjQfYxcvw/SZ4W?=
 =?us-ascii?Q?8A=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?IE3dMiul3olWhPOzbHRuJ4lYPcFYJJpZlfl2nyietcBRWEIOqhqv+D93T7No?=
 =?us-ascii?Q?CDCLfLqENc3jbRAvW+R8pFX1pI4NAX2Ncj34r6cwnDcor4ozDQSCaP51j2NR?=
 =?us-ascii?Q?ooqUtEDzHge8RbAcgAMTDPTpQGD0aAmsISW853qN+wXozDn4e2d0qZBDHzJq?=
 =?us-ascii?Q?gdlubC4nY2ogevEoig0sS3Nvgzo74p1HFEqk3JDRJP4KAyfvtWLrAoap+VSP?=
 =?us-ascii?Q?3mkYDxPZI7RHEbUpaRA0p01F/yI716hhYr1cHxauvv6G+o1L6ALOlswS7PgE?=
 =?us-ascii?Q?eYZtnF1qssvQgxZrqHKDCqzsBJZQq8aH6nDb0r0xFW+SG9humetKkf7l7BXz?=
 =?us-ascii?Q?N77T2MYTATQVB6+S1/DbglIoLji5EJyW/Hs3J/RHKc0iNmPXP/90G251XxyY?=
 =?us-ascii?Q?WKOoofRzwxuswXEPqSquKTD4jlbhwAkcBazCmaIyjMv2sNFrvh9XLiYGXh9o?=
 =?us-ascii?Q?vtwqP4E2ULYfiO0FLLOeI8JS86VWYxHKVWQvC0yAhAePL+GY/nsCneGlPJzs?=
 =?us-ascii?Q?TabCekNX9D5Id3zpm0j9Q54FtANEYG3kt2qoggpiVzwxZcS+bQquYc3Eg/xQ?=
 =?us-ascii?Q?AobSLr6h5viv3188CE6VKFQfPCnmNtJKcUJCw0QlcC8SFr1XYMkDZnixjIA6?=
 =?us-ascii?Q?9YfCPFwRwH9VkMBRsxGZdA5cQa95Vi691leUtyFAg6upzcFiag+oZeEWB/mQ?=
 =?us-ascii?Q?Tpi95xa2tnVM/x4e6FNO/C25BziWIYPkhkYv6cRDTFgArm6I2G43C/b+7KZa?=
 =?us-ascii?Q?sajcZQTXaAU7p+yMbBeExWc8z8RMgEe36HRs0+7Tm4SKt+PBBfqvEFhP1e/2?=
 =?us-ascii?Q?tcKD2eqs4XwkTRYtjd2ybilNRJDp1mhRAvSLuzK370HOOAKnqeLoWYVMlVOS?=
 =?us-ascii?Q?KLQjQuwV052Loggfi3wnPsmuWEzvTvatULFXgoU1tHZ8NtdLGjD3awRIfcvH?=
 =?us-ascii?Q?yGicC777mHGB2TIlru7rkaQeAzCEYtAad6/qS9AHQf3vJUwDM8fezakE/wFa?=
 =?us-ascii?Q?vmvyjms4sVQfA4WeZFdSwvODqOXfTxpZmTWKYrMrh+A0XIZUWpnFY/hkagAt?=
 =?us-ascii?Q?/EweGLwUocxsk4QTjENfUuENr5B68tSuprVuYTL5HHJmq2ZrKVCvlT9oyM7s?=
 =?us-ascii?Q?sJFRd2LuVQUs3mX+QXBsdJn7SLp1WOQf1vG20xBWUQVuK9YR/NoJb2+2bJ3q?=
 =?us-ascii?Q?czTB/THoLuFxQi4znG1Uh1Ax8UBuCCIc1mNwAQLPluokzgKuu8rvC29IYDkT?=
 =?us-ascii?Q?TLumFQkN/ISrqhtS2XiP0hJyn6DSxKIMxLfBZ85T0dNwD3yEx0OSF1psBkrC?=
 =?us-ascii?Q?hTvfHoPp2cTUrXhJtGcLJ3iaZJ3lldTM96sxq0QkqkEPZ8pIID0iZATy7NJ4?=
 =?us-ascii?Q?lZKMqpkx9ro6A/IkZLtwFf/mJxRqFj2+ZPuLuHUaPGhbWIK9rByBPmCUkDyN?=
 =?us-ascii?Q?FHIILuw3X8IxA+y9Ji8G9dyA9e9EUsQrRXWI3CdKKDrmJ3MTCFnT207v2wS+?=
 =?us-ascii?Q?cmSNe/8b1UjJsr3V0/GUv0EJKqjv1D+GUdgWnhECR3yfy71nwY4QHYI4OA?=
 =?us-ascii?Q?=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6d8a982-ac7f-4c8d-52e0-08db10f66121
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 14:50:58.2505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UZBeBtlgbFcz59ZgCMuse2lZoMRm1u3rZtH4QVSumBpvaA84vHXISpEybBhHXJT3X6PIVMCetA+grIMGZb4ocQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4809
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-17_10,2023-02-17_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=737 mlxscore=0 adultscore=0
 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302170135
X-Proofpoint-GUID: RHBuj7a6gvuMBzv70eNE-aFY2GtCQy-y
X-Proofpoint-ORIG-GUID: RHBuj7a6gvuMBzv70eNE-aFY2GtCQy-y
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Suren Baghdasaryan <surenb@google.com> [230216 14:36]:
> On Thu, Feb 16, 2023 at 7:34 AM Liam R. Howlett <Liam.Howlett@oracle.com> wrote:
> >
> >
> > First, sorry I didn't see this before v3..
> 
> Feedback at any time is highly appreciated!
> 
> >
> > * Suren Baghdasaryan <surenb@google.com> [230216 00:18]:
> > > While unmapping VMAs, adjacent VMAs might be able to grow into the area
> > > being unmapped. In such cases write-lock adjacent VMAs to prevent this
> > > growth.
> > >
> > > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> > > ---
> > >  mm/mmap.c | 8 +++++---
> > >  1 file changed, 5 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/mm/mmap.c b/mm/mmap.c
> > > index 118b2246bba9..00f8c5798936 100644
> > > --- a/mm/mmap.c
> > > +++ b/mm/mmap.c
> > > @@ -2399,11 +2399,13 @@ do_vmi_align_munmap(struct vma_iterator *vmi, struct vm_area_struct *vma,
> > >        * down_read(mmap_lock) and collide with the VMA we are about to unmap.
> > >        */
> > >       if (downgrade) {
> > > -             if (next && (next->vm_flags & VM_GROWSDOWN))
> > > +             if (next && (next->vm_flags & VM_GROWSDOWN)) {
> > > +                     vma_start_write(next);
> > >                       downgrade = false;
> >
> > If the mmap write lock is insufficient to protect us from next/prev
> > modifications then we need to move *most* of this block above the maple
> > tree write operation, otherwise we have a race here.  When I say most, I
> > mean everything besides the call to mmap_write_downgrade() needs to be
> > moved.
> 
> Which prior maple tree write operation are you referring to? I see
> __split_vma() and munmap_sidetree() which both already lock the VMAs
> they operate on, so page faults can't happen in those VMAs.

The write that removes the VMAs from the maple tree a few lines above..
/* Point of no return */

If the mmap lock is not sufficient, then we need to move the
vma_start_write() of prev/next to above the call to
vma_iter_clear_gfp() in do_vmi_align_munmap().

But I still think it IS enough.

> 
> >
> > If the mmap write lock is sufficient to protect us from next/prev
> > modifications then we don't need to write lock the vmas themselves.
> 
> mmap write lock is not sufficient because with per-VMA locks we do not
> take mmap lock at all.

Understood, but it also does not expand VMAs.

> 
> >
> > I believe this is for expand_stack() protection, so I believe it's okay
> > to not vma write lock these vmas.. I don't think there are other areas
> > where we can modify the vmas without holding the mmap lock, but others
> > on the CC list please chime in if I've forgotten something.
> >
> > So, if I am correct, then you shouldn't lock next/prev and allow the
> > vma locking fault method on these vmas.  This will work because
> > lock_vma_under_rcu() uses mas_walk() on the faulting address.  That is,
> > your lock_vma_under_rcu() will fail to find anything that needs to be
> > grown and go back to mmap lock protection.  As it is written today, the
> > vma locking fault handler will fail and we will wait for the mmap lock
> > to be released even when the vma isn't going to expand.
> 
> So, let's consider a case when the next VMA is not being removed (so
> it was neither removed nor locked by munmap_sidetree()) and it is
> found by lock_vma_under_rcu() in the page fault handling path.

By this point next VMA is either NULL or outside the munmap area, so
what you said here is always true.

>Page
> fault handler can now expand it and push into the area we are
> unmapping in unmap_region(). That is the race I'm trying to prevent
> here by locking the next/prev VMAs which can be expanded before
> unmap_region() unmaps them. Am I missing something?

Yes, I think the part you are missing (or I am missing..) is that
expand_stack() will never be called without the mmap lock.  We don't use
the vma locking to expand the stack.

...