Message-ID: <a0898de5-5990-4198-cda2-fe22679aec90@intel.com>
Date:   Fri, 17 Feb 2023 15:54:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2 net-next 0/5] add ethtool categorized statistics
Content-Language: en-US
To:     Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <woojung.huh@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <andrew@lunn.ch>, <f.fainelli@gmail.com>, <olteanv@gmail.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>
References: <20230217110211.433505-1-rakesh.sankaranarayanan@microchip.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230217110211.433505-1-rakesh.sankaranarayanan@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU1jRkZKdGljd0pjOWl0cGhpeFM0elFzTElhc3U4TlRuZmI4ZXpaMFlFaWQ3?=
 =?utf-8?B?MmdXNnk2VlpXZnFQMXQ0QXltRTR0WXJpWi9YNnFVcVFkNHBwVEprUk5DZDhR?=
 =?utf-8?B?UXNyRXN6eHpUTVhpY2g5NUdyMWx6MkRuTVdHWEZaVG9jeVBTR2NpelArMHNh?=
 =?utf-8?B?YVJ3ZWJTc1FxSS9XbVY3bXpYd2dOdUxIOFJNZG1TQTZPZm9Gd3pPMGhlZHRy?=
 =?utf-8?B?Ukk0Q3U5QUNrSHRXM3Jadkc2dEFzNSswRHlWTlN3TVNuM3JSMzNiUHdLRWUr?=
 =?utf-8?B?bHB1dmZkTVNVWStqaXlmRjRJRTBYakN3TTljZ2JEWXZHRFBFTlZtRmhoK2J2?=
 =?utf-8?B?dTh1cTZyNmpIUTdPK0xYRjNnYkZ5OWYyRHR5K1pIeVdHelRCbmZ5aG1jQWNW?=
 =?utf-8?B?Wkc0MjhETDJ1SWtXbDlDc244ZWFMNmoxZXpVNEQzREcwelQ1MFBCQ2RPY3Vi?=
 =?utf-8?B?RWhCSHAxRmNWUzZjOWVIeUY0Z3lVeGMwOUtzYXA1bmV0SWw3ZnRFOEJZZEwv?=
 =?utf-8?B?bWRJcTJHM0FnTTUvaEhiejVLQ0F5alhMZEtlSEc4L3VZa1p2SjE4RkdnRzds?=
 =?utf-8?B?azFDOUdDRkVPQ1ozVFZHbVNIVExsYzA5ZDZqQ0JSZHNoNUhjWENSNUw5NTdZ?=
 =?utf-8?B?aFpYRncva3hOSlp3U1g4T05tVlFRK3JNbmxOcTl2ZTR3VDc2ZWREa0pkeUdX?=
 =?utf-8?B?Q2NsNWJQbHRnQUxESDY0ZmUvOFppMU9Xbyt4NWZ5ZDdCYk4vUyt2S29Vd1Iy?=
 =?utf-8?B?dUpITmMycWNVOCs5bms3WkhwZ1pRamh5N1FVc21qY2NDaVpGdzdhU2hIYUFN?=
 =?utf-8?B?aERtYmdubGtybmVVMnB5VXpTbmVFcEFaVWJQRVBYczdXaFo0cUZ5VkdMVUlC?=
 =?utf-8?B?cWRHZEIwNzhtWkFZY1dZQnlMd3lUQ1h5ay9yRkxVbXFQQmFzV0tEMW1RUmMw?=
 =?utf-8?B?OVI3aVNFVlV4T241ek5qTmNwRDNsejFzRDJPa1NTMzVmUTlQRkJRcnYxUTJZ?=
 =?utf-8?B?dlZqMERFK29iQ1M0VU91aThzQnRmQTc2ZkxwUENXUWdScTlVRktoQkovY2pv?=
 =?utf-8?B?MTlIMThrRHVGTW1HZnpHMnlsNS9aSmhIaDJWVFd1elFDWWRIS0R2SVhhUVUz?=
 =?utf-8?B?aVhtKzZieGtmbmx2emFTc01jaVpndFRnS2J3Wnl2YTA3Zmpvdng1Z21BS0s3?=
 =?utf-8?B?N3VXaFlJNzdySGsrNUVlWWczQUpPODN1eXVxUHRJdnlQd2pjSDBuYWhJUkZq?=
 =?utf-8?B?RGxaTnUvaDUrbW9Ma1VmejdoOFlsWG5jWlFoYTBLSjhoekU1SzZ6YUVZSWZh?=
 =?utf-8?B?RVdoYlY2MXBlZlR4THM5Y3REa29KRXVDR0ZaendhWTlWVHMxTW5ZdjloM1dP?=
 =?utf-8?B?MytsR0dSaW85OEx6bmR6VDJwbWxNbnBKQjh5bDYxNEp4eEZDaVIrd3FrNHhI?=
 =?utf-8?B?YW16b2VvN3NoQWJNNWFJRUwzc2ViRVZhN05tK0g0MFJzOVQ1T1pGcCtjT2xn?=
 =?utf-8?B?VEFJdlFKUVFnbDZsa0FVcTYwUGRCUUxxaHNKSk9iMzl2UHdjN2sxSDA1YU1Z?=
 =?utf-8?B?Vmx1WmNITXQzQjVxdEtEaGppZk9MYWZSc2YwVWE4NWpWUExJZGJta1hLVThw?=
 =?utf-8?B?eVVwT3NQL0VNc1V2cHVYbnF5Z3VNaVEwTjJLZUFITTV6UlZqZXF5eGNwTXN5?=
 =?utf-8?B?dFZIQ3ErWUhhM1NCWTVOenJkUVRMUVZDNDdNdi9QZVJvbFlQZnhQV0wrVEdD?=
 =?utf-8?B?d0h1Y3VHOGRvNHA3cTlrRGpFQjJZRkpiVDdXY3ROSHdEaHhOTkNCeVpWWmlI?=
 =?utf-8?B?M0dqbndETHhnOFpNNVM4cVJvVmZ0VFFCY3c5N3NMd0JlZzU0RjBxdnh2bXhn?=
 =?utf-8?B?cHpzZy9SZXJSYTRkazl3dnFiVjVMZUprTEFmeTAxVnlyNmhTYS9oYkd5T05Z?=
 =?utf-8?B?cEdZQVlmOGRFNXY0NFZjNDU0Y1N3Rlg2NVNuRVppMlhpQTIwSXU2QStaa1RP?=
 =?utf-8?B?RmU3MWdkU0pVTEZWdU5HWGQvYjRXUmhzeDFKSXh2VkxDaFNaWkIwcmFFNG1K?=
 =?utf-8?B?eDRBSGZVQjU3S0hLZDJqK1BuczVoeEdhT0NCaVhrQnVZUU56SU1qYVpta01j?=
 =?utf-8?B?Y3Mvd3E0eGdyd3RwOCtHQmdDNGx1VDlHeUROeHM3QUNoSjNLamk0TVloRGVU?=
 =?utf-8?Q?0iWt+hQ7BiwwdFbE35s6mTs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 78a3e307-5d53-4e18-5be8-08db10f72498
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 14:56:26.1707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cIXEpqXb02D2DtWlVM1RwUDpaZxRbOuOR/zW2NNmbP4+MUAkl7fOYWPTCsNIpvx5ZYl3KWFwZxG2io/ZhvdvGsBKwa4fWpSJYc4+/M9oER0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6504
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
Date: Fri, 17 Feb 2023 16:32:06 +0530

> [PATCH v2 net-next 0/5] add ethtool categorized statistics

I'd like to see the cover letter's subject prefixed as well, e.g.

[PATCH v2 net-next 0/5] net: dsa: microchip: add ethtool categorized
statistics

...or so, depending on the usual prefix for ksz.
Otherwise, it looks like you're adding something generic and only
realize it targets a particular driver only after opening the thread itself.

> Patch series contain following changes:
> - add categorized ethtool statistics for Microchip KSZ series switches,
>   support "eth-mac",  "eth-phy", "eth-ctrl", "rmon" parameters with
>   ethtool statistics command. mib parameter index are same for all
>   KSZ family switches except KSZ8830. So, functions can be re-used
>   across all KSZ Families (except KSZ8830) and LAN937x series. Create
>   separate functions for KSZ8830 with their mib parameters.
> - Remove num_alus member from ksz_chip_data structure since it is unused
> 
> v2
> - updated all constants as capital
> - removed counters that are not supported in hardware
> - updated the FramesTransmittedOK and OctetsTransmittedOK counters as
>   per standards
> 
> v1
> - Initial submission
> 
> Rakesh Sankaranarayanan (5):
>   net: dsa: microchip: add rmon grouping for ethtool statistics
>   net: dsa: microchip: add eth ctrl grouping for ethtool statistics
>   net: dsa: microchip: add eth mac grouping for ethtool statistics
>   net: dsa: microchip: add eth phy grouping for ethtool statistics
>   net: dsa: microchip: remove num_alus_variable
> 
>  drivers/net/dsa/microchip/Makefile      |   1 +
>  drivers/net/dsa/microchip/ksz_common.c  |  70 +++--
>  drivers/net/dsa/microchip/ksz_common.h  |  10 +-
>  drivers/net/dsa/microchip/ksz_ethtool.c | 348 ++++++++++++++++++++++++
>  drivers/net/dsa/microchip/ksz_ethtool.h |  31 +++
>  5 files changed, 443 insertions(+), 17 deletions(-)
>  create mode 100644 drivers/net/dsa/microchip/ksz_ethtool.c
>  create mode 100644 drivers/net/dsa/microchip/ksz_ethtool.h
> 
Thanks,
Olek