Message-ID: <84835bee-a074-eb46-f1e4-03e53cd7f9ec@intel.com>
Date:   Fri, 17 Feb 2023 16:01:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac grouping
 for ethtool statistics
Content-Language: en-US
To:     Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <woojung.huh@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <andrew@lunn.ch>, <f.fainelli@gmail.com>, <olteanv@gmail.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>
References: <20230217110211.433505-1-rakesh.sankaranarayanan@microchip.com>
 <20230217110211.433505-4-rakesh.sankaranarayanan@microchip.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230217110211.433505-4-rakesh.sankaranarayanan@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eERhYW1IdVhIaUIrU0Z2aFE2anZpSmRsSTdNcnBuUUpRdUtFM3g4T2FYK1FE?=
 =?utf-8?B?MTlsUlBsdGp6SFZpeW5lWGsremgvQXNPVkdHdWh3VjNNRU9aeDVkbnVXT2tQ?=
 =?utf-8?B?NUd4UGo4d3craWJTNnhhNW4vd1BmU3BFSWNYTmtiaTlRZUl0aElUTUY4WUcw?=
 =?utf-8?B?aENETTZNbmxWVEMvVjFoc1liZzhmbVgyd0xIWllYRE5WSUU4a2xTZ3RRVE5G?=
 =?utf-8?B?QnNhWm04YndYdFlyUm5DOXp6WGh3RlFDRzRmekNKdDA2N093c00yU2ZuMGky?=
 =?utf-8?B?YWJ1azNIUjZSYkpxMFRxTkw3MDZST1dYUFpqYWpOdEFEVGE0UUxhTUZWZFJI?=
 =?utf-8?B?Y1k1UHcyanhxakFsVDVxVDBTWkJLcDlLQjRlTHhQS0tZcmg5NFl6ZDh6WEVw?=
 =?utf-8?B?RURGZXR2TnR4Q2pzNHdPOGJLQ2pUUFZGQlFUU0Zra1ZLNjNMRVA0aHRTRDZa?=
 =?utf-8?B?NlhPM0szanE5eE5XUU1mVm1aV3kvbjk1TVZZK2ZXcUhlS0dUQW5vR2t5eE9l?=
 =?utf-8?B?eVNYbDUvSWt3TncyL2NzV3BCVGlJZUJIb2F3M0themVKR1NnWE8xTlMrc3Rq?=
 =?utf-8?B?NkEzNHpxV3NWYVRkQWhYYmpNdWVEOEZEL1hlMW9WQmpyVlkvQ0N2RTJYeXE4?=
 =?utf-8?B?SEtWRk5EdnExL1duZVR5WDJnQjRUSTBMcC9LN1Y0VDBnQW80MnhnTC9Ca2hy?=
 =?utf-8?B?bmVxbUgxSzJGZnQwQXRQd1FaZVRONzRLeWpIRVk2MGpIQTBXUzYyNVc4S1M3?=
 =?utf-8?B?VUNMWjEwdEhyTTJkcE9JQ3krRkpRb09ySU1NUFlaNEJYUHY5WFBwbk1IOFR3?=
 =?utf-8?B?akFiclhjZlh4SnRVbzI5MDFUUjQvNDV5S1VWb0dxS0FLdCtnMTR6UGdybWRv?=
 =?utf-8?B?L0RTV1M0UG50WnpYSnRoWEtMS1ZVc3lKN0JLZ1lYREpmZTdJSG1xZ1dIR2Yw?=
 =?utf-8?B?M2syRW5PdWwwcDFjU2VCWDc4MHJ3dmdEVWVYWDByQS94NjYrdlFBWmNSU3ds?=
 =?utf-8?B?NmJQVG1PWDhPVlBBeGNtcGVHOWlRYUg0b0NhRGIrS241WENZb1BkcSsvQmll?=
 =?utf-8?B?LzFsbDNKRStKMW9walNOSEJ2dGE1OXRxcE9uUE9yS0x5SzZ0VFgyb1Z0NG9w?=
 =?utf-8?B?cFpTZWlsNkFwY2N4Tk9QaGt6T0crKzFKYkREYWxaUTFDcWRPK3ZEQUlrZkZh?=
 =?utf-8?B?ekVsY0F2U2VSMFdDTEhBWVJwOWNocHpWSlF1Q0tuUURYck1veDJYbzcyOEtS?=
 =?utf-8?B?S1FtT1F1Wkp0Rk9zTkJmbzZnWVlvWW9aOXFCSDZ3dmpnMk95eDFlcTN0OXh0?=
 =?utf-8?B?RnE0V3lYN1JiWFlRQVRZdkU5cWttNkJYRm5PeU1UdnBnVERTUmFQZkxOSWxy?=
 =?utf-8?B?V0t4RFE5VkZIMDl6TWx0eDRXZmkrQmVkRUwwOFBRRDFJZEpTUVJvODgyUHdL?=
 =?utf-8?B?L0NuVlpIMjZGb2NHUk5PTkNNQm43RWZyNExvbzc4dWdMYjVBV21kVzhoVzFM?=
 =?utf-8?B?TXhVYXlRZUxDWWpFT1ZFRmFYTmVlbzJkOEFRemdtWGNaelJZendDUk8rSzVi?=
 =?utf-8?B?NkwyN2t6c1NiSkdJZytRbWN0bFJnWjNZVXNnb1FPbW1QNDFWcTdtOStXdWVi?=
 =?utf-8?B?aVZock5lRUxrWHFtT3Y5SGd1KzVOZFh1aisvckUxeFpkSXBXSk1yYmdTUTJ3?=
 =?utf-8?B?eDN5UjdKV3FVcWREdWVOVmVRZTV0a0xVWDBxZ0VIRG1TOWlJdGlKQXZZNXZQ?=
 =?utf-8?B?WEtoYSs5OXNHZXUrZmZtME5PT3BtSjE2WFhsMi9OZjJDN0NUQ01XVkZDS1gx?=
 =?utf-8?B?cDVxbENXSS8zdDRYeWsyeWV3MXlmT09RbHJZLzBlNkhnaWM1YWUvRENzN2NP?=
 =?utf-8?B?UnlrQU90WnR5bTZXbWxhNkJkY1NieWlsUWEwSWY0L2Vyd2FTWjJXbWJqYXNr?=
 =?utf-8?B?bzRHdk5zWkRMdktRdGN0d0gyYzhWY2I5NTZIOERybG1yOTRLd3p0Y250cldo?=
 =?utf-8?B?VjY1cnR4MTkxTmlScmhadDhaazQ3SnNURkdyMXZ0ODdWTmRkbitjNE5Uek1N?=
 =?utf-8?B?ZjZoVVFJbUlicEZybm03ZW9xWm8xMVFPQXRhQlF6Ujc4TzE2b21lcmhpSDJP?=
 =?utf-8?B?aGZuUStxTlBab0dwR1Y0UTN2YWkzbklxemI2NDk0b3JJWXUycFBQUE42VGRF?=
 =?utf-8?Q?TzIEX+jxWYnEtsraS//p7DM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 34a3810a-90fe-42bd-1ad9-08db10f80a83
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 15:02:51.9855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m2AqLz3QGSVzy2fkEwqRzqscs7Qhwl/SW26+koL5+2hy4cnESmmB4c8bNi+NFHk1YoWAj3Iw0kSquPb3la0/fVZfOe2ca9VoorgLUEaEDUQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4660
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
Date: Fri, 17 Feb 2023 16:32:09 +0530

>     Add support for ethtool standard device statistics grouping.
>     Support ethernet mac statistics grouping using eth-mac groups
>     parameter in ethtool command.
> 
> Signed-off-by: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>

[...]

> +void ksz8_get_eth_mac_stats(struct ksz_device *dev, int port,
> +			    struct ethtool_eth_mac_stats *mac_stats)
> +{
> +	struct ksz_port_mib *mib;
> +	u64 *ctr;
> +
> +	mib = &dev->ports[port].mib;
> +
> +	mutex_lock(&mib->cnt_mutex);
> +	ctr = mib->counters;
> +
> +	while (mib->cnt_ptr < dev->info->mib_cnt) {
> +		dev->dev_ops->r_mib_pkt(dev, port, mib->cnt_ptr,
> +			       NULL, &mib->counters[mib->cnt_ptr]);

(for example here)

> +		++mib->cnt_ptr;

Reason for the pre-increment? :)

> +	}
> +
> +	mac_stats->FramesTransmittedOK = ctr[KSZ8_TX_MCAST] +
> +					 ctr[KSZ8_TX_BCAST] +
> +					 ctr[KSZ8_TX_UCAST] +
> +					 ctr[KSZ8_TX_PAUSE] -
> +					 ctr[KSZ8_TX_DISCARDS];
[...]

Thanks,
Olek