Message-ID: <e85d5bed-6c62-d055-d696-085f447f8fd2@intel.com>
Date:   Fri, 17 Feb 2023 16:06:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH net-next v3] net: lan966x: Use automatic selection of VCAP
 rule actionset
Content-Language: en-US
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <richardcochran@gmail.com>,
        <UNGLinuxDriver@microchip.com>, <larysa.zaremba@intel.com>
References: <20230217132831.2508465-1-horatiu.vultur@microchip.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230217132831.2508465-1-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0tnamdoSFVPUHVGSGttOFJpNG8zam9FMDRubHhHcERKRHVKUGZTQ0Qwd1ZX?=
 =?utf-8?B?S0VrTHdJMGdONko2UXFNSU9hc1FHanlnd29jaitDTnZkNjBDQUpLaGpUbWRR?=
 =?utf-8?B?R3hVRzMvUkFxZDNPRURBb1pPeWY5cmRKNGJxQy85blN0OGE1UVE5UVp6RCty?=
 =?utf-8?B?NktWaFdXNU94UkQyQ25rcS9TZVQvYjZNa0tmZEZ1SCtOYURrYzBVRUdCRzFI?=
 =?utf-8?B?djhSazhPdU9sRFk0clBpTjhGaTlJNFR1TjNmclhTVGdsTkV2aGt3RUJDVDFX?=
 =?utf-8?B?bmE0SXFrZ1IvdzVRdUNyeHlqSXFIMUZvbktnVWk4R1FMSlRuRXN3Nm9UVll1?=
 =?utf-8?B?eWZ2UjZPNGE0NTMzWEVwZnRxMzBVYUtRd3F6M0ZiU3F5TWhESWEzaDVaVVdv?=
 =?utf-8?B?UU5oNHV5MWJJMC9BeTl2N3NpdDRHbHRWV1M0eWlEUG9iTmgvallGOGozUTg2?=
 =?utf-8?B?UkErMGJtR25qTWxaL2dsVDZud1QwSExVNEoxSkRlNWNuZUgxc1FFd2lGdmgy?=
 =?utf-8?B?cHk1V1dUR0NVY0pRMFN0bU9zZmxKaHBBYnRQSTNidzVZazdBaVJ5d0RqdU83?=
 =?utf-8?B?dE9UaVJpVDFpWnNjOGxOVDh3anlqcGpOYXgwZnZLNHBzZ1RXNm9mYUplVXZY?=
 =?utf-8?B?Y1BLSGVuYzZ3WmpLUURxZjBXalJrUGk5eDJTdEt6eWQzT0I2OWEySUZUaVEz?=
 =?utf-8?B?L0o3TmVRQWVtRHlONFh6NVR0aHBkMGtwOThkVUlESURIYld2Y0xZN0xoN21P?=
 =?utf-8?B?Mzk5YUVUeWViMFh4WWJsVTZieTNtL1hOTGpscThwWk1hdXFqc0RsWmhvbXdG?=
 =?utf-8?B?eitDbGhtSkx4S1ZydVJmVFRWMERPdEloYklOclEvcTBRMDdOb3lnRytlb0dT?=
 =?utf-8?B?TkJtNFEvdlJxbkx6NFZzei9BMFVHbUFsY0U0c0xNSXgvUDJVUHFLT0pMRXZs?=
 =?utf-8?B?YVdCTCtSdnFmQzd5N0MvekYrMUNLait5WHBJRGV1K1ovZStkekVuUUV5TWlT?=
 =?utf-8?B?ODRGQ0V6Mkh3RFlSdTFTa2o2Rmt5dFBnMjIyWVpRVSsxSk80TGpVUTRMaVlv?=
 =?utf-8?B?UWJQVzNPcTdCdzhJVVgrVlpUekYvc1FQOVQ4cm9MSTNSa0tQQ0tXakdHWklp?=
 =?utf-8?B?cHdJLzFFTUdlWjU3RlhET0J0M2xWamdyN3l6YTRBM1R4WU0vN3pHdUc1VWhz?=
 =?utf-8?B?Uk4wbDh2N0UweTJpTktmN1BON0JrTWVqYi9YcFVLM1NZcmM2RDZzQlN1RjJP?=
 =?utf-8?B?c1FESnFMcVNxRUFUQ3lOak1QZThWVjdDdjU0aklETkRuOUtmbnVtRSt6Yy8z?=
 =?utf-8?B?SnNXUTI2YlhERk9hQjlZMjZLVWZtaW1YeTUxUmdFeTQ5U3VCRWcvTjZ0TUdN?=
 =?utf-8?B?TDRjLzhaVEdsNHlCMzgxMnRXOGVEb1pKSnJTVmlzTEVrQ3BYUWVxdEdRbjEr?=
 =?utf-8?B?RVVEUGRQK2VuUmdHWjMyWWdvaEt3c1JQUUs3TWFHNUI1T2I1Y2JFLzk5SVFj?=
 =?utf-8?B?RVBaWmlIVWJMaFU5TzVFNmI1REhwNys1ZzdJK1dFRUxSVG5NQW9iRlJ6K1lC?=
 =?utf-8?B?NlBBVHEvd09LQ3FKL2NRMmkwcTRXVmhDWGpDSXEwR0YwR1YvR3NhR2JNNkxP?=
 =?utf-8?B?Z1B6SEpZdTVwR0RmdWg3aU9SUHFDMi8xQldQT2NCTGhLVGhRN3dhUWR4RGN5?=
 =?utf-8?B?N3N2QTdoN3hMVVJvV0JHK242QnR6WElvT3Ywb090L1F6SW5GQ21MODgwTnJt?=
 =?utf-8?B?enkrMXlSc3FYWFFsYStUTjZrUG1mS1V6QnFWZVNpdFk0aU42YXMxZkhnNk84?=
 =?utf-8?B?cDAzNTlpZUN6SXF4MndaZ2UxMTNoTXhCRDFKN3YxemlkSnUxVm1KaXhQdE9L?=
 =?utf-8?B?aWF5QU9hd01HcDY1S2pJbDQ5VW0vcHA2V0ZjUWlMSGtpeXZUSmFLWnJ0MEhE?=
 =?utf-8?B?bDVuSW5XM3I2MFJnQW4vQkVyM0kxb24vWCtuMFF2dXlRQ2d6THpCamN1SEZv?=
 =?utf-8?B?VGs5ODIrRVBTNGFSR3ExeXNZZkljcEpZOU8vczAxMG1NYmwxMjB3a1dzOXJt?=
 =?utf-8?B?KzJOVzk5aWlaUGh5U3l4ck9vUm9NMUdrdWEwWkpZTGNRa2Y3YjVIOElzQWtv?=
 =?utf-8?B?S0NoUGgzWXZENU40WVRnZWlpSENCNStsMGpOcXlaU0I4cFV3djYvUXVLK0Zw?=
 =?utf-8?Q?jti8h+bfqoB4UyGgym7t4qk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 23b1732f-0ba9-4cb9-f00b-08db10f8d2ea
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 15:08:28.2415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dZUl+r2mbQLb8UJRJXY6vU2jApurGJ5fjowsGZ3FsNvezEDo91254J940hW5O/YF2DVSAqu2vaNCFq3gBHgrbVToc+Vt0xGAt2jtwXLjtaM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4669
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Horatiu Vultur <horatiu.vultur@microchip.com>
Date: Fri, 17 Feb 2023 14:28:31 +0100

> Since commit 81e164c4aec5 ("net: microchip: sparx5: Add automatic
> selection of VCAP rule actionset") the VCAP API has the capability to
> select automatically the actionset based on the actions that are attached
> to the rule. So it is not needed anymore to hardcode the actionset in the
> driver, therefore it is OK to remove this.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> v2->v3:
> - fix typo hardcore -> hardcode

:D

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> - remove vcap_set_rule_set_actionset also for PTP rules
> v1->v2:
> - improve the commit message by mentioning the commit which allows
>   to make this change
> ---
>  drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c       | 3 +--
>  drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c | 2 --
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c b/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
> index a8348437dd87f..ded9ab79ccc21 100644
> --- a/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
> +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
> @@ -83,8 +83,7 @@ static int lan966x_ptp_add_trap(struct lan966x_port *port,
>  	if (err)
>  		goto free_rule;
>  
> -	err = vcap_set_rule_set_actionset(vrule, VCAP_AFS_BASE_TYPE);
> -	err |= vcap_rule_add_action_bit(vrule, VCAP_AF_CPU_COPY_ENA, VCAP_BIT_1);
> +	err = vcap_rule_add_action_bit(vrule, VCAP_AF_CPU_COPY_ENA, VCAP_BIT_1);
>  	err |= vcap_rule_add_action_u32(vrule, VCAP_AF_MASK_MODE, LAN966X_PMM_REPLACE);
>  	err |= vcap_val_rule(vrule, proto);
>  	if (err)
> diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
> index bd10a71897418..f960727ecaeec 100644
> --- a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
> +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
> @@ -261,8 +261,6 @@ static int lan966x_tc_flower_add(struct lan966x_port *port,
>  							0);
>  			err |= vcap_rule_add_action_u32(vrule, VCAP_AF_MASK_MODE,
>  							LAN966X_PMM_REPLACE);
> -			err |= vcap_set_rule_set_actionset(vrule,
> -							   VCAP_AFS_BASE_TYPE);
>  			if (err)
>  				goto out;
>  

Thanks,
Olek