Date:   Fri, 17 Feb 2023 11:07:20 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        Matthew Brost <matthew.brost@intel.com>,
        "John Harrison" <John.C.Harrison@intel.com>,
        Michal Wajdeczko <michal.wajdeczko@intel.com>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, Arnd Bergmann <arnd@arndb.de>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/i915/guc: avoid FIELD_PREP warning
Message-ID: <Y++mOIxOQFCmchM5@intel.com>
References: <20230217124724.1324126-1-arnd@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230217124724.1324126-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c6DKaHmP3eFwudk7+bOdC+uBNQJxWhQ8CufNSjbTMReOgGkrQGrqMhu1qy6C?=
 =?us-ascii?Q?BOOArGJqAstKWqkHx6Vwc8GjQUdNzsdJCIDW0DQHDrTJd5kJf9iwjCqhjLSA?=
 =?us-ascii?Q?oiKJe31eQe3DBLkIBhSZ6BqpzlHWLtBMbm9nJYQNNMhPc6zdNvB7lN5ChX+g?=
 =?us-ascii?Q?cLDYowBH5FafyGnPO8qEgvxuS/YG8Sc2D5sCT3U5Bbtz5BPH4t5TE6CZrYTU?=
 =?us-ascii?Q?6KaGx2hGT32HnP5R0pE78nK+ShJh4vpr+omWwr8UKWXdtfBOwQTqard/E1MS?=
 =?us-ascii?Q?W5YtZwWMpQ6j/58T4TS3PkDSVLZCdCXekFgWlAO6bvlBPVEaV300pAQUJu3A?=
 =?us-ascii?Q?aD6oERbsB5414bDJcVwpCcUsA8lDO+0zyPtY2YBywZqXRqv0mGrnE0FJJUMt?=
 =?us-ascii?Q?JQvDEMTsG9ZRzW240b1F02ah/ZrUp86Wp3BXxkB5C0JIo9db5XXl8pnA2ib7?=
 =?us-ascii?Q?osS6I0cTJzD6GCwGDnGx8+uuH/FtcQ/UHfFW3T0mVvtB9TXD0cHDhy8dVBzc?=
 =?us-ascii?Q?aMSQguNYUPeqBuwG1BrY0w/l17AR15kMpQDqkb269nxU9GleZBgmmDiTyoHB?=
 =?us-ascii?Q?/jJXZOPWflkWfeSHA/x1oLrkLNOrKJPWX0H/X+dz60rFHlFlgHqg2nhmE6/p?=
 =?us-ascii?Q?T4hzuTmRDiprK1c6Luy2ehxax7mWztyn8L+zimh6efILnsyIpwanWvbaiS+A?=
 =?us-ascii?Q?fekY0CzdGE0iUrLdvGxl3sAw+DIsvg4/8RQFyge/kvqHfLcGVGSAzW89WHeR?=
 =?us-ascii?Q?JT0DBQc+vCp+/JV0cBbr0OOlChsD1p5ZoCywaYttzAc/CJZBvwW9Wtg51MWT?=
 =?us-ascii?Q?nYwUxULsFIt0CgxaxMljENB+0mSUM7VUt0vJ6OSDfGXtYg1irWOF/2pcsM8H?=
 =?us-ascii?Q?JpMt0X8Ql21YZYwtDFHU0Et6EnrV7yYl5S7Os0tuwxj5DGb4eW1FXCTeXwL9?=
 =?us-ascii?Q?Ts1PN1DVTZhyhzFQz5mu45FPV2NwtU4hLjkvF3OHId0tJgU0uAnsaCc+uvyU?=
 =?us-ascii?Q?eSZk2MxhQEX0LbX5LqtS+o+gz6gFOoGc/zAv6ODQVLZb/DWS3O6Jb8jQFXrJ?=
 =?us-ascii?Q?PA/xr4vzkVDq/FHJDNjXw4PUN8afeEdDYmzp/wWyqyU+Oby69r/nxtqdvkxC?=
 =?us-ascii?Q?QhVyInlmp4WTj/GS6qT52zEfN4q2GW97OddwbMkRnf+C007qUT4E3PKkLxpZ?=
 =?us-ascii?Q?X0SVGETcGF5x+gYzEFPHAIbqFOVsNP0teVa4FJP6vvMoPzKGG2joxuBQuHbm?=
 =?us-ascii?Q?XI/dl1keXa1kbWVCkdIevCqO3sCmMk5w5zgkRhE0c5M3qkBPvuGPztqP/692?=
 =?us-ascii?Q?ET2Wb1KZ3WecsUPI3XoWpV8Qu8ZywiCgvrzFklWu5XmGRxQf84LqjDR2quWj?=
 =?us-ascii?Q?ouDIB8Q15QxQOrtqgFh4HBGRUN0wyeWtAy6oz/F/3DE2dGOAygO3zTVrqfnv?=
 =?us-ascii?Q?ZsNr17tY5inF2u6eG2NIF7o5kGGqh4RID6I+UmSy/XNDmCzhfTsHW+72viUd?=
 =?us-ascii?Q?dyCcwlhy7lbZKlfYfMxKYwx7Oba/q+QA9X0i9VoGbeHLr4PhAaRGKKzK2vp2?=
 =?us-ascii?Q?v1GdSjjFp/QXTG/goKM+2TA4VcINsIs3JebVyLX+dgMXIsbohkDyJQFquY/6?=
 =?us-ascii?Q?dA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 60f5f1c6-ea0f-4856-3cbc-08db1101109b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 16:07:27.7586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: caIjNIXwnhpjA54/vQzRwR/SahdQe++VTotLlIcYd5t+0MyTecyZaqeaTwJsIkO1YXGYzejLSU9Km+3qDTqhdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8003
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 17, 2023 at 01:46:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> With gcc-7 and earlier, there are lots of warnings like
> 
> In file included from <command-line>:0:0:
> In function '__guc_context_policy_add_priority.isra.66',
>     inlined from '__guc_context_set_prio.isra.67' at drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3292:3,
>     inlined from 'guc_context_set_prio' at drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3320:2:
> include/linux/compiler_types.h:399:38: error: call to '__compiletime_assert_631' declared with attribute error: FIELD_PREP: mask is not constant
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                       ^
> ...
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2422:3: note: in expansion of macro 'FIELD_PREP'
>    FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>    ^~~~~~~~~~
> 
> Make sure that GUC_KLV_0_KEY is an unsigned value to avoid the warning.
> 
> Fixes: 77b6f79df66e ("drm/i915/guc: Update to GuC version 69.0.3")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
> index 58012edd4eb0..4f4f53c42a9c 100644
> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
> @@ -29,9 +29,9 @@
>   */
>  
>  #define GUC_KLV_LEN_MIN				1u
> -#define GUC_KLV_0_KEY				(0xffff << 16)
> -#define GUC_KLV_0_LEN				(0xffff << 0)
> -#define GUC_KLV_n_VALUE				(0xffffffff << 0)
> +#define GUC_KLV_0_KEY				(0xffffu << 16)
> +#define GUC_KLV_0_LEN				(0xffffu << 0)
> +#define GUC_KLV_n_VALUE				(0xffffffffu << 0)

what about changing them to GENMASK?

>  
>  /**
>   * DOC: GuC Self Config KLVs
> -- 
> 2.39.1
>