Date:   Fri, 17 Feb 2023 08:32:40 -0800
From:   Jacob Pan <jacob.jun.pan@linux.intel.com>
To:     Fenghua Yu <fenghua.yu@intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, <iommu@lists.linux.dev>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Will Deacon <will@kernel.org>,
        "David Woodhouse" <dwmw2@infradead.org>,
        Raj Ashok <ashok.raj@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        X86 Kernel <x86@kernel.org>, Dave Jiang <dave.jiang@intel.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v3 4/5] iommu/ioasid: Rename INVALID_IOASID
Message-ID: <20230217083240.147d2c76@jacob-builder>
In-Reply-To: <25fbbc7f-f137-c2c4-ddf8-d143fce1dcc5@intel.com>
References: <20230216235951.3573059-1-jacob.jun.pan@linux.intel.com>
        <20230216235951.3573059-5-jacob.jun.pan@linux.intel.com>
        <25fbbc7f-f137-c2c4-ddf8-d143fce1dcc5@intel.com>
Organization: OTC
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Fenghua,

On Thu, 16 Feb 2023 17:23:15 -0800, Fenghua Yu <fenghua.yu@intel.com> wrote:

> > --- a/drivers/dma/idxd/irq.c
> > +++ b/drivers/dma/idxd/irq.c
> > @@ -80,7 +80,7 @@ static void idxd_int_handle_revoke_drain(struct
> > idxd_irq_entry *ie) desc.opcode = DSA_OPCODE_DRAIN;
> >   	desc.priv = 1;
> >   
> > -	if (ie->pasid != INVALID_IOASID)
> > +	if (ie->pasid != IOMMU_PASID_INVALID)  
> 
> It's better to change to:
> +	if (pasid_valid(ie->paid))
> 
> If pasid_vaild() is called, any invalid PASID value change in the future 
> will be hidden in pasid_valid() and won't impact this code any more.
> 
> And checking pasid_valid() is more readable and meaninful than direct 
> checking the invalid PASID value.
Sounds good, here I'm just renaming. I will submit another patch to
convert.

Thanks,

Jacob