Subject: Re: [PATCH bpf-next] selftests/bpf: Remove not used headers
To:     Stanislav Fomichev <sdf@google.com>,
        Tiezhu Yang <yangtiezhu@loongson.cn>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>, bpf@vger.kernel.org,
        acme@kernel.org, linux-kernel@vger.kernel.org
References: <1676533861-27508-1-git-send-email-yangtiezhu@loongson.cn>
 <Y+52auqAlfPy/cNS@google.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <a07641f4-5d92-94c0-9ca6-963c27869fc8@iogearbox.net>
Date:   Fri, 17 Feb 2023 17:36:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <Y+52auqAlfPy/cNS@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/16/23 7:31 PM, Stanislav Fomichev wrote:
> On 02/16, Tiezhu Yang wrote:
>> The following three uapi headers:
> 
>>      tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
>>      tools/arch/s390/include/uapi/asm/bpf_perf_event.h
>>      tools/arch/s390/include/uapi/asm/ptrace.h
> 
>> were introduced in commit 618e165b2a8e ("selftests/bpf: sync kernel headers
>> and introduce arch support in Makefile"), they are not used any more after
>> commit 720f228e8d31 ("bpf: fix broken BPF selftest build"), so remove them.
> 
> Let's maybe CC Arnaldo to make sure it doesn't affect perf? BPF build
> bots are happy it seems.
> 
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>   tools/arch/arm64/include/uapi/asm/bpf_perf_event.h |   9 -
>>   tools/arch/s390/include/uapi/asm/bpf_perf_event.h  |   9 -
>>   tools/arch/s390/include/uapi/asm/ptrace.h          | 458 ---------------------
>>   3 files changed, 476 deletions(-)
>>   delete mode 100644 tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
>>   delete mode 100644 tools/arch/s390/include/uapi/asm/bpf_perf_event.h
>>   delete mode 100644 tools/arch/s390/include/uapi/asm/ptrace.h

Lgtm, I think test_verifier.c was the only user via ...

   - include/uapi/linux/bpf_perf_event.h
     -> include/uapi/asm/bpf_perf_event.h
        -> arch/*/include/uapi/asm/bpf_perf_event.h

... but we're actually pulling in the arch includes instead of the tooling
arch include. So these look indeed unused.