Date:   Fri, 17 Feb 2023 19:08:22 +0200
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
        andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v2 net-next 2/5] net: dsa: microchip: add eth ctrl
 grouping for ethtool statistics
Message-ID: <20230217170822.w65c72hsbbnoqcab@skbuf>
References: <20230217110211.433505-1-rakesh.sankaranarayanan@microchip.com>
 <20230217110211.433505-3-rakesh.sankaranarayanan@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230217110211.433505-3-rakesh.sankaranarayanan@microchip.com>
Precedence: bulk

On Fri, Feb 17, 2023 at 04:32:08PM +0530, Rakesh Sankaranarayanan wrote:
> +void ksz8_get_eth_ctrl_stats(struct ksz_device *dev, int port,
> +			     struct ethtool_eth_ctrl_stats *ctrl_stats)
> +{
> +	struct ksz_port_mib *mib;
> +	u64 *cnt;
> +
> +	mib = &dev->ports[port].mib;
> +
> +	mutex_lock(&mib->cnt_mutex);
> +
> +	cnt = &mib->counters[KSZ8_TX_PAUSE];
> +	dev->dev_ops->r_mib_pkt(dev, port, KSZ8_TX_PAUSE, NULL, cnt);
> +	ctrl_stats->MACControlFramesTransmitted = *cnt;
> +
> +	cnt = &mib->counters[KSZ8_RX_PAUSE];
> +	dev->dev_ops->r_mib_pkt(dev, port, KSZ8_RX_PAUSE, NULL, cnt);
> +	ctrl_stats->MACControlFramesReceived = *cnt;
> +
> +	mutex_unlock(&mib->cnt_mutex);
> +}

These should be reported as standard pause stats as well (ethtool -I --show-pause swpN).