Message-ID: <5a7cb1e1-1cee-431a-485b-55913a5766e2@amd.com>
Date:   Fri, 17 Feb 2023 11:39:02 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [RFC v2 PATCH 6/7] x86/resctrl: Display the RMID and COSID for
 resctrl groups
Content-Language: en-US
To:     Fenghua Yu <fenghua.yu@intel.com>, Babu Moger <babu.moger@amd.com>,
        reinette.chatre@intel.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        corbet@lwn.net, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, eranian@google.com,
        peternewman@google.com
References: <167537433143.647488.9641864719195184123.stgit@bmoger-ubuntu>
 <167537445137.647488.9039585071837467840.stgit@bmoger-ubuntu>
 <0b42ee96-32cf-b929-6033-7898821b54cb@intel.com>
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <0b42ee96-32cf-b929-6033-7898821b54cb@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzJpZC8xMS94T0prZDYvdFNubFBPeUdqQ2l5ZDhrQnBac2RRN21RYmM3d0wv?=
 =?utf-8?B?ai9wS3o3TnhQRkZSMllDY3liR093R1h1eldzYytTVWlBYjVwaDA4NHRZUVRy?=
 =?utf-8?B?d1JJNnppdzJwQWkzZUk0SWtRWHF6UC9acE5pd1pweGhaTUppMXp2Qm43TW9l?=
 =?utf-8?B?OFZESUhkR20xMG83ZTFRZ3Y4eU02WFZsNlAvbFlwT3pjS2RCYWhMaUprOTRR?=
 =?utf-8?B?bDhQOG4yMkpRVG5uSEt1WVQ0V3NxdDlBTlowQkh2K1NVSlZQRTFBVjYwczNv?=
 =?utf-8?B?eGRIb2lJcFYxN2xicklQT0JVclc3aHZISFlYY01rb1FvU0QrSU1QTXhic2RG?=
 =?utf-8?B?N1dwMW12cDVwTERIdE1IZFkrbWI1aldGMWhYL1RITVRxN1lWVGZ0ZjRwa05W?=
 =?utf-8?B?ZkpFclMxeE9FbmF1dkQ1MExIeE9qU290a3lIUzhUc3JhLzVCdUEvRmNHaXNQ?=
 =?utf-8?B?ZUV1OW54QTEzOXgrSjRXWktlL0F5azI0RGxpZ29PV0hrQUM2Mzg0Z2s2WTF4?=
 =?utf-8?B?cXVCblU4K1dXV1lpcjRkQ2ZhdHpSM3R6bzMyRDgxOHF2SVFUVVNJcHdwTmlH?=
 =?utf-8?B?S2M5NXV6UU1QNER1dEhqTkNpSjNNVmdWQ1dsQ2xrZEk5aWJRekFFQUFEN3hQ?=
 =?utf-8?B?c3dkS3hXNnBGRHBYVVk3UGZFeEdKT09GRHRLbmhPRGI5dCsweFBXNG0xNlJv?=
 =?utf-8?B?TDBLb1BIa1B4WXZOcTBkWUJ2bFZjc1JVd1VDdzRvNVVDMFlVWW9rUlFieFpX?=
 =?utf-8?B?NStMZlRrdlkzUG1PYlgxd2ZYNWV1ZTE5TWhPdDdlb0ZSdGdFQTkrOUIrNEVJ?=
 =?utf-8?B?eFdWbDAxNFlzRzJSOGs5THk2N2NVOSs0bjh4a1k2d244L1hJUzE2QkZPYVpM?=
 =?utf-8?B?T0Q3OTJtSVFSQldrYU9UVHpqNkFEcmlwNFBrN29aeW1tOWtQaDdoYUUxeVRS?=
 =?utf-8?B?dWpOcVpReGZ4bmJZUlNSdlFhVVR6Vy9mc1JWMWs5R2ZlUWxSZmtYT1BVR2Jv?=
 =?utf-8?B?ZnhSZGZzQzV1K01rWFI1YkhCWGRNaUpCQ2RHZndLSExSbjh4dFloOUxKZk1n?=
 =?utf-8?B?RUcwSld2cnJxVUxzSzlHR2VvTEorMEI4UG53RzY3RWV2bGM5Q2NrQ1dqVXNy?=
 =?utf-8?B?VndiRDZ3Qm1MSTNJOUFjQ0c2YzlWVW1oUGVNOEJlZUwrT2RaRkpoYUNnQ3hH?=
 =?utf-8?B?cVUyYkZ2bEZiTWJRNTdBejFIR3NsaWRaZDlOMVc0QnVySE93aCtLZFpDSEpV?=
 =?utf-8?B?MkdtMDZXUVlablpoSWZpTGh6dmFmZWIzRElManNnYU51MnFSRFRrWmJ3V29R?=
 =?utf-8?B?cTVITUlLY3BETjZOc0Q2b1pDUjB0UDk5N2NzSW1mMkNWT1gwVFV0ZktLMEtp?=
 =?utf-8?B?TFVnb3RtWVI4MlR2OE9BQXM1bTlnZmJqVmZGTXFPSzQ2ZGhpVzJSWnJpeS9P?=
 =?utf-8?B?cUhCTFFTSHZHdXZPRWV4QWdRSndRa05TVkJzZFhIQ28yVFFCaTAwVWpOQ1o5?=
 =?utf-8?B?WGVadk5ROGJ0RkdVcEN6aHh1WTNxMlkrNTdHTjc0TEhFZ3czTDU2UFpNVE1x?=
 =?utf-8?B?WDNFd2ZieGEwaDZPTVU3QWtkNCtDVW1IZGZkMDNyS25HWThVTDE3MjV1SWsr?=
 =?utf-8?B?TDF2ZEZLV2YvZTV2U0MwT3lOTldjN3dzRitab1Y2V3JEMXZPSHVrTUJRK3ZK?=
 =?utf-8?B?RmY3b2R5ZXRXYU1BeE5Sem5JV0J3NmJEUk1FOFpIdUdZYnhKS2lNK2FLR0tR?=
 =?utf-8?B?ejUvYTZnSGdSZ05SeUZ5SXBvM3kvZGN6UjNFTFlOZmxYWElHQ2hHZnJLR0Fs?=
 =?utf-8?B?TWhJV2RmemQ1YnhvUGc1cisvc2kzZGFCUXE3d2pMR3EwcXo0dEkyMDFuNTgz?=
 =?utf-8?B?KzNxVFlTRnI1aFVhbzVTaitPcjM0TGRsWGtHNjdVR2FoN0owOG45Q0l6K20r?=
 =?utf-8?B?SEpkc0ZEdS9mRHoyckMzZjhlYStMWjN5SWlIeG5yYmt6c3VDYzBWaEVETWFD?=
 =?utf-8?B?YUw0QjNYVVFSZXE4Qnoyb0hEQWgxKy84Nks4SVhTNnovaEJHdS9iaDh4dU9a?=
 =?utf-8?B?a1BhbVcySjZkaS8vMC9iSHJra1BwdjdSNjlSOFQ3bU5vR2tsWnBVYjlLYndM?=
 =?utf-8?Q?Nn8JRpudRWEhdb8zjd7Xj7tkm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9a1304b-49f3-4348-9db2-08db110ddead
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 17:39:07.3425
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VzmmwuLwkE7bXPsOtu4AYOL0PM9V8IeaVWeMBUEqYSnvBqq5TchnjEBg6G/ZCMnB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7283
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/16/2023 7:46 PM, Fenghua Yu wrote:
> Hi, Babu,
>
> On 2/2/23 13:47, Babu Moger wrote:
>> When a user creates a control or monitor group, the CLOSID or RMID
>> are not visible to the user. These are architecturally defined entities.
>> There is no harm in displaying these in resctrl groups. Sometimes it
>> can help to debug the issues.
>>
>> Add CLOSID and RMID to the control/monitor groups display in resctrl
>> interface.
>>
>> $cat /sys/fs/resctrl/clos1/closid
>> 1
>> $cat /sys/fs/resctrl/mon_groups/mon1/rmid
>> 3
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>>   Documentation/x86/resctrl.rst          |   17 ++++++++++++
>>   arch/x86/kernel/cpu/resctrl/rdtgroup.c |   44 
>> ++++++++++++++++++++++++++++++++
>>   2 files changed, 61 insertions(+)
>>
>> diff --git a/Documentation/x86/resctrl.rst 
>> b/Documentation/x86/resctrl.rst
>> index 2c013c5d45fd..de332c242523 100644
>> --- a/Documentation/x86/resctrl.rst
>> +++ b/Documentation/x86/resctrl.rst
>> @@ -321,6 +321,15 @@ All groups contain the following files:
>>       Just like "cpus", only using ranges of CPUs instead of bitmasks.
>>     +"rmid":
>> +        Available only with debug option.Reading this file shows the
>> +        resource monitoring id (RMID) for monitoring the resource
>
> Capitals Resource Monitoring ID (RMID).
Sure.
>
>> +        utilization. Monitoring is performed by tagging each core(or
>> +        thread) or process via a Resource Monitoring ID (RMID). Kernel
>
> s/Resource Monitoring ID (RMID)/RMID/

Sure.

Thanks

Babu