Date:   Fri, 17 Feb 2023 20:58:07 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl, broonie@kernel.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] gpio: 104-dio-48e: Utilize no_status regmap-irq flag
Message-ID: <Y+/OP5pj7OBZ9M8g@smile.fi.intel.com>
References: <cover.1675876659.git.william.gray@linaro.org>
 <0feb25265128808d4487c49238fdd9f3ca3bb725.1675876659.git.william.gray@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0feb25265128808d4487c49238fdd9f3ca3bb725.1675876659.git.william.gray@linaro.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Feb 08, 2023 at 12:18:17PM -0500, William Breathitt Gray wrote:
> The 104-DIO-48E lacks an IRQ status register. Rather than use the Clear
> Interrupt register as the status register, set the no_status flag to
> true and thus avoid such a hack.

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> ---
>  drivers/gpio/gpio-104-dio-48e.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-104-dio-48e.c b/drivers/gpio/gpio-104-dio-48e.c
> index a3846faf3780..fe3c93bfe4bd 100644
> --- a/drivers/gpio/gpio-104-dio-48e.c
> +++ b/drivers/gpio/gpio-104-dio-48e.c
> @@ -195,13 +195,9 @@ static int dio48e_probe(struct device *dev, unsigned int id)
>  		return -ENOMEM;
>  
>  	chip->name = name;
> -	/* No IRQ status register so use CLEAR_INTERRUPT register instead */
> -	chip->status_base = DIO48E_CLEAR_INTERRUPT;
>  	chip->mask_base = DIO48E_ENABLE_INTERRUPT;
>  	chip->ack_base = DIO48E_CLEAR_INTERRUPT;
> -	/* CLEAR_INTERRUPT doubles as status register so we need it cleared */
> -	chip->clear_ack = true;
> -	chip->status_invert = true;
> +	chip->no_status = true;
>  	chip->num_regs = 1;
>  	chip->irqs = dio48e_regmap_irqs;
>  	chip->num_irqs = ARRAY_SIZE(dio48e_regmap_irqs);
> -- 
> 2.39.1
> 

-- 
With Best Regards,
Andy Shevchenko