Date:   Fri, 17 Feb 2023 21:07:19 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl, broonie@kernel.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] gpio: pci-idio-16: Migrate to the regmap API
Message-ID: <Y+/QZ7VX2EAxweIt@smile.fi.intel.com>
References: <cover.1675876659.git.william.gray@linaro.org>
 <1bac3155e366fc7da7dbb48f54ab96d4a9649e57.1675876659.git.william.gray@linaro.org>
 <Y+/PwYe3pvtausbe@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+/PwYe3pvtausbe@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Feb 17, 2023 at 09:04:33PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 08, 2023 at 12:18:20PM -0500, William Breathitt Gray wrote:
> > The regmap API supports MMIO accessors so we can take advantage of
> > regmap abstractions rather than handling access to the device registers
> > directly in the driver. Migrate the pci-idio-16 module to the new
> > idio-16 library interface leveraging the gpio-regmap API.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Don't you need to allow PIO accessors in the regmap configuration?

If not, update a commit message accordingly.

-- 
With Best Regards,
Andy Shevchenko