MIME-Version: 1.0
References: <20230216-kobj_type-amdgpu-v1-1-b382ab606dc7@weissschuh.net> <ba5c8e8d-2418-aca0-59b0-721d08af452c@amd.com>
In-Reply-To: <ba5c8e8d-2418-aca0-59b0-721d08af452c@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 17 Feb 2023 15:13:06 -0500
Message-ID: <CADnq5_OBX4E0TZWrRdZY5opiWXJ9NWUvscYsY59jeujYMHjtng@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: make kobj_type structures constant
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
        Alex Deucher <alexander.deucher@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Thu, Feb 16, 2023 at 1:59 AM Christian K=C3=B6nig
<christian.koenig@amd.com> wrote:
>
> Am 16.02.23 um 02:07 schrieb Thomas Wei=C3=9Fschuh:
> > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> > the driver core allows the usage of const struct kobj_type.
> >
> > Take advantage of this to constify the structure definitions to prevent
> > modification at runtime.
> >
> > Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 10 +++++-----
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c      |  2 +-
> >   2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gp=
u/drm/amd/amdgpu/amdgpu_discovery.c
> > index 1bbd56029a4f..8e04952e5144 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> > @@ -704,7 +704,7 @@ static void ip_hw_instance_release(struct kobject *=
kobj)
> >       kfree(ip_hw_instance);
> >   }
> >
> > -static struct kobj_type ip_hw_instance_ktype =3D {
> > +static const struct kobj_type ip_hw_instance_ktype =3D {
> >       .release =3D ip_hw_instance_release,
> >       .sysfs_ops =3D &ip_hw_instance_sysfs_ops,
> >       .default_groups =3D ip_hw_instance_groups,
> > @@ -723,7 +723,7 @@ static void ip_hw_id_release(struct kobject *kobj)
> >       kfree(ip_hw_id);
> >   }
> >
> > -static struct kobj_type ip_hw_id_ktype =3D {
> > +static const struct kobj_type ip_hw_id_ktype =3D {
> >       .release =3D ip_hw_id_release,
> >       .sysfs_ops =3D &kobj_sysfs_ops,
> >   };
> > @@ -786,18 +786,18 @@ static const struct sysfs_ops ip_die_entry_sysfs_=
ops =3D {
> >       .show =3D ip_die_entry_attr_show,
> >   };
> >
> > -static struct kobj_type ip_die_entry_ktype =3D {
> > +static const struct kobj_type ip_die_entry_ktype =3D {
> >       .release =3D ip_die_entry_release,
> >       .sysfs_ops =3D &ip_die_entry_sysfs_ops,
> >       .default_groups =3D ip_die_entry_groups,
> >   };
> >
> > -static struct kobj_type die_kobj_ktype =3D {
> > +static const struct kobj_type die_kobj_ktype =3D {
> >       .release =3D die_kobj_release,
> >       .sysfs_ops =3D &kobj_sysfs_ops,
> >   };
> >
> > -static struct kobj_type ip_discovery_ktype =3D {
> > +static const struct kobj_type ip_discovery_ktype =3D {
> >       .release =3D ip_disc_release,
> >       .sysfs_ops =3D &kobj_sysfs_ops,
> >   };
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm=
/amd/amdgpu/amdgpu_xgmi.c
> > index 4b9e7b050ccd..6d13ce6ec9cc 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> > @@ -228,7 +228,7 @@ static const struct sysfs_ops amdgpu_xgmi_hive_ops =
=3D {
> >       .show =3D amdgpu_xgmi_show_attrs,
> >   };
> >
> > -struct kobj_type amdgpu_xgmi_hive_type =3D {
> > +static const struct kobj_type amdgpu_xgmi_hive_type =3D {
> >       .release =3D amdgpu_xgmi_hive_release,
> >       .sysfs_ops =3D &amdgpu_xgmi_hive_ops,
> >       .default_groups =3D amdgpu_xgmi_hive_groups,
> >
> > ---
> > base-commit: 033c40a89f55525139fd5b6342281b09b97d05bf
> > change-id: 20230216-kobj_type-amdgpu-4d3f0e1e05d4
> >
> > Best regards,
>