MIME-Version: 1.0
References: <20230216-kobj_type-amdkfd-v1-1-337abb104da2@weissschuh.net>
In-Reply-To: <20230216-kobj_type-amdkfd-v1-1-337abb104da2@weissschuh.net>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 17 Feb 2023 15:15:39 -0500
Message-ID: <CADnq5_MX7gnjaZziktVUxbCo+GCfnKo_RvAD6ELpoE0VGo_eTQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amdkfd: Make kobj_type structures constant
To:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     Felix Kuehling <Felix.Kuehling@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Wed, Feb 15, 2023 at 8:09 PM Thomas Wei=C3=9Fschuh <linux@weissschuh.net=
> wrote:
>
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definitions to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_process.c  |  8 ++++----
>  drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 10 +++++-----
>  2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/a=
md/amdkfd/kfd_process.c
> index 51b1683ac5c1..8d719f90db40 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -344,7 +344,7 @@ static const struct sysfs_ops kfd_procfs_ops =3D {
>         .show =3D kfd_procfs_show,
>  };
>
> -static struct kobj_type procfs_type =3D {
> +static const struct kobj_type procfs_type =3D {
>         .release =3D kfd_procfs_kobj_release,
>         .sysfs_ops =3D &kfd_procfs_ops,
>  };
> @@ -469,7 +469,7 @@ static const struct sysfs_ops procfs_queue_ops =3D {
>         .show =3D kfd_procfs_queue_show,
>  };
>
> -static struct kobj_type procfs_queue_type =3D {
> +static const struct kobj_type procfs_queue_type =3D {
>         .sysfs_ops =3D &procfs_queue_ops,
>         .default_groups =3D procfs_queue_groups,
>  };
> @@ -478,7 +478,7 @@ static const struct sysfs_ops procfs_stats_ops =3D {
>         .show =3D kfd_procfs_stats_show,
>  };
>
> -static struct kobj_type procfs_stats_type =3D {
> +static const struct kobj_type procfs_stats_type =3D {
>         .sysfs_ops =3D &procfs_stats_ops,
>         .release =3D kfd_procfs_kobj_release,
>  };
> @@ -487,7 +487,7 @@ static const struct sysfs_ops sysfs_counters_ops =3D =
{
>         .show =3D kfd_sysfs_counters_show,
>  };
>
> -static struct kobj_type sysfs_counters_type =3D {
> +static const struct kobj_type sysfs_counters_type =3D {
>         .sysfs_ops =3D &sysfs_counters_ops,
>         .release =3D kfd_procfs_kobj_release,
>  };
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/=
amd/amdkfd/kfd_topology.c
> index 3fdaba56be6f..8e4124dcb6e4 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -278,7 +278,7 @@ static const struct sysfs_ops sysprops_ops =3D {
>         .show =3D sysprops_show,
>  };
>
> -static struct kobj_type sysprops_type =3D {
> +static const struct kobj_type sysprops_type =3D {
>         .release =3D kfd_topology_kobj_release,
>         .sysfs_ops =3D &sysprops_ops,
>  };
> @@ -318,7 +318,7 @@ static const struct sysfs_ops iolink_ops =3D {
>         .show =3D iolink_show,
>  };
>
> -static struct kobj_type iolink_type =3D {
> +static const struct kobj_type iolink_type =3D {
>         .release =3D kfd_topology_kobj_release,
>         .sysfs_ops =3D &iolink_ops,
>  };
> @@ -350,7 +350,7 @@ static const struct sysfs_ops mem_ops =3D {
>         .show =3D mem_show,
>  };
>
> -static struct kobj_type mem_type =3D {
> +static const struct kobj_type mem_type =3D {
>         .release =3D kfd_topology_kobj_release,
>         .sysfs_ops =3D &mem_ops,
>  };
> @@ -395,7 +395,7 @@ static const struct sysfs_ops cache_ops =3D {
>         .show =3D kfd_cache_show,
>  };
>
> -static struct kobj_type cache_type =3D {
> +static const struct kobj_type cache_type =3D {
>         .release =3D kfd_topology_kobj_release,
>         .sysfs_ops =3D &cache_ops,
>  };
> @@ -566,7 +566,7 @@ static const struct sysfs_ops node_ops =3D {
>         .show =3D node_show,
>  };
>
> -static struct kobj_type node_type =3D {
> +static const struct kobj_type node_type =3D {
>         .release =3D kfd_topology_kobj_release,
>         .sysfs_ops =3D &node_ops,
>  };
>
> ---
> base-commit: 033c40a89f55525139fd5b6342281b09b97d05bf
> change-id: 20230216-kobj_type-amdkfd-abd9fe9ab060
>
> Best regards,
> --
> Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
>