Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-156-g081acc5ed5-fm-20230206.001-g081acc5e
Mime-Version: 1.0
Message-Id: <157c5ae1-b294-4587-8d39-5c5f8b1512e0@app.fastmail.com>
In-Reply-To: <20230217202301.436895-5-thuth@redhat.com>
References: <20230217202301.436895-1-thuth@redhat.com>
 <20230217202301.436895-5-thuth@redhat.com>
Date:   Fri, 17 Feb 2023 22:08:11 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Thomas Huth" <thuth@redhat.com>, linux-kernel@vger.kernel.org
Cc:     Linux-Arch <linux-arch@vger.kernel.org>,
        "Chas Williams" <3chas3@gmail.com>,
        "Palmer Dabbelt" <palmer@dabbelt.com>, linux-block@vger.kernel.org,
        linux-fsdevel@vger.kernel.org,
        linux-atm-general@lists.sourceforge.net,
        Netdev <netdev@vger.kernel.org>,
        "Andrew Waterman" <waterman@eecs.berkeley.edu>,
        "Albert Ou" <aou@eecs.berkeley.edu>
Subject: Re: [PATCH 4/4] Move USE_WCACHING to drivers/block/pktcdvd.c
Content-Type: text/plain
Precedence: bulk

On Fri, Feb 17, 2023, at 21:23, Thomas Huth wrote:
> From: Palmer Dabbelt <palmer@dabbelt.com>
>
> I don't think this was ever intended to be exposed to userspace, but
> it did require an "#ifdef CONFIG_*".  Since the name is kind of
> generic and was only used in one place, I've moved the definition to
> the one user.
>
> Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
> Reviewed-by: Andrew Waterman <waterman@eecs.berkeley.edu>
> Reviewed-by: Albert Ou <aou@eecs.berkeley.edu>
> Message-Id: <1447119071-19392-11-git-send-email-palmer@dabbelt.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  drivers/block/pktcdvd.c      | 11 +++++++++++
>  include/uapi/linux/pktcdvd.h | 11 -----------
>  2 files changed, 11 insertions(+), 11 deletions(-)

I'm fairly sure there are more bits in uapi/linux/pktcdvd.h that should
be in drivers/block/pktcdvd.c instead, along with all of
include/linux/pktcdvd.h, but this change is obvious and safe by itself,
so 

Reviewed-by: Arnd Bergmann <arnd@arndb.de>