Message-ID: <02d4b4b5-4292-aef0-8e20-7ec031348e91@linux.ibm.com>
Date:   Fri, 17 Feb 2023 16:20:06 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.7.2
Content-Language: en-US
To:     "Elliott, Robert (Servers)" <elliott@hpe.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc:     "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "leitao@debian.org" <leitao@debian.org>,
        "nayna@linux.ibm.com" <nayna@linux.ibm.com>,
        "appro@cryptogams.org" <appro@cryptogams.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ltcgcw@linux.vnet.ibm.com" <ltcgcw@linux.vnet.ibm.com>,
        "dtsen@us.ibm.com" <dtsen@us.ibm.com>
References: <20230217161805.236319-1-dtsen@linux.ibm.com>
 <20230217161805.236319-2-dtsen@linux.ibm.com>
 <MW5PR84MB1842DB9DF917B9B3B83A005BABA19@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
From:   Danny Tsen <dtsen@linux.ibm.com>
In-Reply-To: <MW5PR84MB1842DB9DF917B9B3B83A005BABA19@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: RE: [PATCH v3 1/6] Update Kconfig and Makefile.
Precedence: bulk

Hi Robert,

Power10+ means Power10 or later.  Other modes were not stripped by the 
perl script.

Thanks for the comments I will fix the suggestions.

-Danny

On 2/17/23 3:44 PM, Elliott, Robert (Servers) wrote:
>> +config CRYPTO_P10_AES_GCM
>> +	tristate "Stitched AES/GCM acceleration support on P10+ CPU (PPC)"
>> +	depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
>> +	select CRYPTO_LIB_AES
>> +	select CRYPTO_ALGAPI
>> +	select CRYPTO_AEAD
>> +	default m
>> +	help
>> +	  Support for cryptographic acceleration instructions on Power10+ CPU.
>> +	    This module supports stitched acceleration for AES/GCM in
>> hardware.
> Is "Power10+" a specific architecture or does that mean "Power10 or later"?
>
> Please follow the newer wording conventions for the menu item and
> help text, more like:
>
> config CRYPTO_AES_GCM_PPC_P10
>          tristate "AEAD cipher: AES in GCM mode (Power10)"
>
>          help
>            AEAD cipher: AES cipher algorithms (FIPS-197) with
> 	   GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
>
>            Architecture: powerpc64 using:
>            - little-endian
>            - Power10 features
>
>            [some description here]
>
> Also, all the other powerpc cra_driver_names follow
> 	alg-arch
> not
> 	arch-alg
>
> so
> 	.base.cra_driver_name	= "p10_aes_gcm",
> might be better as
> 	.base.cra_driver_name	= "aes-gcm-p10",
>
> Patch 4 seems to have code for lots of other modes like CBC and XTS.
> Does the perl script strip out all of that?
>
>
>