Message-ID: <63f0084a.df0a0220.6220b.fb5a@mx.google.com>
Date:   Fri, 17 Feb 2023 06:58:39 +0100
From:   Christian Marangi <ansuelsmth@gmail.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Jonathan Corbet <corbet@lwn.net>,
        "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        John Crispin <john@phrozen.org>, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-doc@vger.kernel.org,
        Tim Harvey <tharvey@gateworks.com>,
        Alexander Stein <alexander.stein@ew.tq-group.com>,
        Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Arun.Ramadoss@microchip.com
Subject: Re: [PATCH v8 11/13] dt-bindings: leds: Document netdev trigger
References: <20230216013230.22978-1-ansuelsmth@gmail.com>
 <20230216013230.22978-12-ansuelsmth@gmail.com>
 <20230217230346.GA2217008-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230217230346.GA2217008-robh@kernel.org>
Precedence: bulk

On Fri, Feb 17, 2023 at 05:03:46PM -0600, Rob Herring wrote:
> On Thu, Feb 16, 2023 at 02:32:28AM +0100, Christian Marangi wrote:
> > Document the netdev trigger that makes the LED blink or turn on based on
> > switch/phy events or an attached network interface.
> 
> NAK. What is netdev?

But netdev is a trigger, nothing new. Actually it was never documented.
Is the linux,default-trigger getting deprecated? 

> 
> Don't add new linux,default-trigger entries either. We have better ways 
> to define trigger sources, namely 'trigger-sources'.
> 
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/leds/common.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> > index d34bb58c0037..6e016415a4d8 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -98,6 +98,8 @@ properties:
> >              # LED alters the brightness for the specified duration with one software
> >              # timer (requires "led-pattern" property)
> >            - pattern
> > +            # LED blink and turns on based on netdev events
> > +          - netdev
> >        - pattern: "^cpu[0-9]*$"
> >        - pattern: "^hci[0-9]+-power$"
> >          # LED is triggered by Bluetooth activity
> > -- 
> > 2.38.1
> > 

-- 
	Ansuel