Date:   Fri, 17 Feb 2023 17:10:20 -0600
From:   Rob Herring <robh@kernel.org>
To:     Christian Marangi <ansuelsmth@gmail.com>
Cc:     Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        devicetree@vger.kernel.org, John Crispin <john@phrozen.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Tim Harvey <tharvey@gateworks.com>,
        Alexander Stein <alexander.stein@ew.tq-group.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
        Jakub Kicinski <kuba@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
        netdev@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>, Arun.Ramadoss@microchip.com
Subject: Re: [PATCH v8 12/13] dt-bindings: net: phy: Document support for
 leds node
Message-ID: <20230217231020.GB2217008-robh@kernel.org>
References: <20230216013230.22978-1-ansuelsmth@gmail.com>
 <20230216013230.22978-13-ansuelsmth@gmail.com>
 <167651373836.1183034.17900591036429665419.robh@kernel.org>
 <63ee9801.df0a0220.a106.72a3@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <63ee9801.df0a0220.a106.72a3@mx.google.com>
Precedence: bulk

On Thu, Feb 16, 2023 at 11:00:49AM +0100, Christian Marangi wrote:
> On Wed, Feb 15, 2023 at 08:32:11PM -0600, Rob Herring wrote:
> > 
> > On Thu, 16 Feb 2023 02:32:29 +0100, Christian Marangi wrote:
> > > Document support for leds node in phy and add an example for it.
> > > Phy led will have to match led-phy pattern and should be treated as a
> > > generic led.
> > > 
> > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > > ---
> > >  .../devicetree/bindings/net/ethernet-phy.yaml | 22 +++++++++++++++++++
> > >  1 file changed, 22 insertions(+)
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ethernet-phy.example.dtb: ethernet-phy@0: leds:led-phy@0:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > 	'netdev' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > 	'netdev' does not match '^mmc[0-9]+$'
> > 	'netdev' does not match '^cpu[0-9]*$'
> > 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> > 
> 
> Hi, I could be wrong but this should be fixed by the previous patch that
> adds netdev to the trigger list.

If so, then it didn't apply for me which is what PW says. So what tree 
does this series apply too? linux-next? That's a tree no one can apply 
patches from.

Rob