Message-ID: <fec9d8ca-b385-b2e4-8f20-db427c2ae964@infradead.org>
Date:   Fri, 17 Feb 2023 15:24:04 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH] MIPS: vpe-mt: provide a default 'physical_memsize'
Content-Language: en-US
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>,
        linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
        Dengcheng Zhu <dzhu@wavecomp.com>,
        John Crispin <john@phrozen.org>, linux-mips@vger.kernel.org,
        Qais Yousef <qyousef@layalina.io>
References: <20230214010942.25143-1-rdunlap@infradead.org>
 <7a2eca01-8420-dd98-9d4d-edf192f099fb@linaro.org>
 <a2a7806b-ba53-9f37-938b-d3f48ea217f2@infradead.org>
 <20230217115713.GA7701@alpha.franken.de>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230217115713.GA7701@alpha.franken.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/17/23 03:57, Thomas Bogendoerfer wrote:
> On Wed, Feb 15, 2023 at 10:59:35PM -0800, Randy Dunlap wrote:
>>> I agree this is where this variable has be be declared / initialized,
>>> but having this dependent on CONFIG_MIPS_MALTA/CONFIG_LANTIQ machines
>>> doesn't seem right.
>>
>> So far I have been able to consolidate the LANTIQ code into a general
>> patch, but not MALTA.
> 
> if I didn't miss something physical_memory is always 0 for LANTIQ 
> and something for MALTA depending on command line/DT. Now
> 
> arch/mips/kernel/vpe-mt.c contains
> 
>         /*
>          * The sde-kit passes 'memsize' to __start in $a3, so set something
>          * here...  Or set $a3 to zero and define DFLT_STACK_SIZE and
>          * DFLT_HEAP_SIZE when you compile your program
>          */
>         mttgpr(6, v->ntcs);
>         mttgpr(7, physical_memsize);
> 
> so the 0 for LANTIQ is fine with the correct VPE payload. But for
> MALTA could cause major problems, if the VPE payload uses the top
> of memory for it's stack. So I would guess nobody uses this "mode".
> Therefore let's get rid of physical_memory in vpe.c completly.

Hi Thomas,

What is this line doing?
          mttgpr(6, v->ntcs);

Does it need to stay?
But the comment and mttgpr(7, physical_memsize); can be deleted?

thanks.
-- 
~Randy