Date:   Sat, 18 Feb 2023 12:48:19 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Rishit Bansal <rishitbansal0@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        Dan Murphy <dmurphy@ti.com>
Subject: Re: API for setting colors of RGB backlit keyboard zones (was [PATCH
 V3] platform/x86: hp-wmi: Support omen backlight control wmi-acpi methods)
Message-ID: <Y/C7A9eCjpdbzYbz@duo.ucw.cz>
References: <20230131235027.36304-1-rishitbansal0@gmail.com>
 <9b761996-d522-b0f8-6472-10e40e09e036@redhat.com>
 <65a11a89-e780-6d60-a40e-cd3245780762@gmail.com>
 <b83ad6ba-7d55-f309-5d7b-4a5ff77ff5a3@redhat.com>
 <02c96cfe-ab10-513f-fc36-f474dd227656@gmail.com>
 <544484b9-c0ac-2fd0-1f41-8fa94cb94d4b@redhat.com>
 <Y+I7xNqkq/X6Lag+@duo.ucw.cz>
 <3c48e204-780c-f78c-8219-267e297dc1e3@gmail.com>
 <ec5bc4a6-dc9f-90dd-0cf6-5fab47bb5fa6@redhat.com>
 <b11185d3-fbf3-a461-39bc-67bee4739e40@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="qAV0Wrzlh/6x7U/V"
Content-Disposition: inline
In-Reply-To: <b11185d3-fbf3-a461-39bc-67bee4739e40@gmail.com>
Precedence: bulk


--qAV0Wrzlh/6x7U/V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!


> > I do agree with you that we need to avoid kbd_backlight in the name to =
avoid causing existing upower code to have weird interactions with this (it=
 supports / assumes there is only 1 kbd_backlight LED class device).
> >=20
> > So lets go with just these 4:
> >=20
> > /sys/class/leds/hp_omen::kbd_zoned_backlight-1/
> > /sys/class/leds/hp_omen::kbd_zoned_backlight-2/
> > /sys/class/leds/hp_omen::kbd_zoned_backlight-3/
> > /sys/class/leds/hp_omen::kbd_zoned_backlight-4/
> >=20
> > Using the _zoned_ between kbd and baclight to avoid confusing the exist=
ing upower code. Then once this has landed we can look into extending upowe=
r support for this.
> >=20
> > Note the requested documentation patch should probably also explain tha=
t the _zoned_ was done deliberately to make current upower code ignore the =
devices.
> >

>=20
> This makes sense, I agree that the global LED file will cause more confus=
ion
> and hacks in the code. I'll start working on the  _zoned_ naming scheme w=
ith
> 4 files + documentation changes and make a patch for this soon!
>

/sys/class/leds/:rgb:kbd_zoned_backlight-4/ is better than what was
suggested above. But we already use _1 suffix to deduplicate the, so
I'm not sure this is best naming.

There are keyboards with per-key backlight. How do you suggest to
solve those?

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--qAV0Wrzlh/6x7U/V
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY/C7AwAKCRAw5/Bqldv6
8pXMAKCIdI8KbS5mAISKNMRztO7602shGACbBpeBHzXsXIPq1r6rMBoYzfUSFwk=
=G7yz
-----END PGP SIGNATURE-----

--qAV0Wrzlh/6x7U/V--