Date:   Sat, 18 Feb 2023 13:10:39 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <richardcochran@gmail.com>
Subject: Re: [PATCH net-next] net: phy: micrel: Add support for PTP_PF_PEROUT
 for lan8841
Message-ID: <20230218121039.4kgejvhbi4ppkij6@soft-dev3-1>
References: <20230217075213.2366042-1-horatiu.vultur@microchip.com>
 <Y/Ah/MRYKdohtXZH@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <Y/Ah/MRYKdohtXZH@lunn.ch>
Precedence: bulk

The 02/18/2023 01:55, Andrew Lunn wrote:
> 
> > +static void lan8841_ptp_update_target(struct kszphy_ptp_priv *ptp_priv,
> > +                                   const struct timespec64 *ts);
> > +
> 
> Please avoid this. Move the code around so everything is in
> order. Generally, i do such moves in an initial patch which only moves
> code, making it easy to review.

Thanks for the suggestion. I will update this in the next version.

> 
>       Andrew

-- 
/Horatiu