Date:   Sat, 18 Feb 2023 15:01:03 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Sia Jee Heng <jeeheng.sia@starfivetech.com>
Cc:     paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, leyfoon.tan@starfivetech.com,
        mason.huo@starfivetech.com
Subject: Re: [PATCH 3/3] RISC-V: Add arch functions to support
 hibernation/suspend-to-disk
Message-ID: <Y/DaH0vjMsln4Ghr@duo.ucw.cz>
References: <20230106060535.104321-1-jeeheng.sia@starfivetech.com>
 <20230106060535.104321-4-jeeheng.sia@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="IqFhkKEgSBAYZtOE"
Content-Disposition: inline
In-Reply-To: <20230106060535.104321-4-jeeheng.sia@starfivetech.com>
Precedence: bulk


--IqFhkKEgSBAYZtOE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> @@ -21,6 +21,11 @@ struct suspend_context {
>  #endif
>  };
> =20
> +/* This parameter will be assigned to 0 during resume and will be used by
> + * hibernation core for the subsequent resume sequence
> + */
> +extern int in_suspend;

"/*" should be on separate line. (This occurs multiple times.)

> +ENTRY(core_restore_code)
> +	/* switch to temp page table */
> +	csrw satp, s1
> +	sfence.vma
> +	beqz	s4, done
> +loop:
> +	/* The below code will restore the hibernated image. */
> +	ld	a1, HIBERN_PBE_ADDR(s4)
> +	ld	a0, HIBERN_PBE_ORIG(s4)
> +
> +	lui     a4, 0x1
> +	add     a4, a4, a0

Do you have enough registers to move a4 =3D 0x1 assignment before the
loop:?

> +static int __init riscv_hibernate__init(void)
> +{
> +	hibernate_cpu_context =3D kcalloc(1, sizeof(struct suspend_context), GF=
P_KERNEL);
> +

kzalloc?

> +	if (WARN_ON(!hibernate_cpu_context))
> +		return -ENOMEM;
> +
> +	return 0;
> +}
> +
> +early_initcall(riscv_hibernate__init);

Does this really need to be done early?

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--IqFhkKEgSBAYZtOE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY/DaHwAKCRAw5/Bqldv6
8pCeAKCtimnpUoABKl6hy7nwxKtdyFuhZACgi6PwWGe/AwJqB4ECjFEjbteesHg=
=/hSf
-----END PGP SIGNATURE-----

--IqFhkKEgSBAYZtOE--