Message-ID: <f4a1531d-954b-ae68-a202-8ae4e7e78485@amd.com>
Date:   Sat, 18 Feb 2023 08:55:38 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 2/5] KVM: x86: Shrink struct kvm_queued_exception
Content-Language: en-US
To:     Mathias Krause <minipli@grsecurity.net>, kvm@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20230213163351.30704-1-minipli@grsecurity.net>
 <20230213163351.30704-3-minipli@grsecurity.net>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230213163351.30704-3-minipli@grsecurity.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUVsRy81b04vQnN3dVRiUVI2VUp0czVkVGJmUmJpRG9TNEdTWFhtOHZMdDlz?=
 =?utf-8?B?VnBGZWNPaG96alFndDUzMU82YWo1b1hzRHc3emw4a3hlejd4am14Ykk4aWM0?=
 =?utf-8?B?Z3FaZmFrOTRkQ09YcFYxMnF3QmJPQXlpNG9oL0FWY2lpc01UdFlIODhPbitI?=
 =?utf-8?B?dzNMaTdOODRpdGozRXZmL1ZvZldnNVNvUENoWVNHanVZZnovSC9lYVJkMzg0?=
 =?utf-8?B?SUE4VlhVM1Q0VDRtL05zUG9CQ2RlUFBIYnFhQ3JDWVovb0w1OXF5em53dENL?=
 =?utf-8?B?cmhYVmpyTGJteGE1UnB0MGZNanc0TVdVMm1TMDUxNGJMUUZsK2U2aGdkM0pD?=
 =?utf-8?B?bWlWbnZ6a2tpc2dMdHhiZ0lHb3RsTWhSb2VrODBxbzl2cVc4VVZRSFI1QVN3?=
 =?utf-8?B?azUwV2xKWHVVTnJoS212OE1Ub0wwQUZ4SERqc2JROXd0S1lYWjlKdm9rRmxO?=
 =?utf-8?B?dXdURnpJUWh0SjQ3cjBWTlo1SmxCZEtrT21RSVB3Wm02L0d2Nng4ckdUNmRB?=
 =?utf-8?B?dnVSNU5mWWRoZXd3ZVJmYUdEVkdQc0FKMmptd0lWU053L2RxQnJiTjg3VSs1?=
 =?utf-8?B?WTVvK0NrbmZ1T2lsdUlnRUVFZTR6NWNZdFRCOXN5S1YyVWFXMzZhbWVnRm5D?=
 =?utf-8?B?THNvUWFNR2cyYmhxRlNKaTc5Q1hEdElycCtlbXovRlREYnI3VkM4QVJoNmc1?=
 =?utf-8?B?S2RMamJ4c3djQzF4MlE5TjNUbDY0aWJ5M2pzc2FJTkhhcENnYmNXR28rQlF6?=
 =?utf-8?B?T090NFNZbHJIejk0YUFFM2R4QVFUeEVmQmtNejNSWko0Z0pldkFOaWZJL3hS?=
 =?utf-8?B?THd5bUs0bmlGZUtaTGVKVXFXeFUwVWpwTWduWEU1SUhlblloSzl2MDFwdVoy?=
 =?utf-8?B?akRzMEpNalJCMDJhaGREb3pJeUlpNFdyd2xGVWpSS1dPa1pMU3Yzd2lzM1VI?=
 =?utf-8?B?MHJyWFNQd2Q5ektZZjRFRGoyTFczM0YwMm5mL0s0OFlNejBSVkV6RlNmbXcw?=
 =?utf-8?B?MTFaSXZZU0pBZUJKTCtRSFkvWTZpS0JXdVVObEcxWHYzWk82M052YzI2cmJY?=
 =?utf-8?B?b1BiOHUyc2NaNkY3SUpQOUdCNExQN242aHZLaDhkRFZraUdZSWpPdFYxV2Vk?=
 =?utf-8?B?bCs3QW56M0hnaU5OY081eG10OU9PVFlIRzRvK2gwVmg0ZFQzNXhranNNdUpv?=
 =?utf-8?B?MVZEbC9uMG5Sc05GT25XWnZTSC9ycFJUWEFRVXJOQzdZUzFGMG9UTFZYMVRM?=
 =?utf-8?B?YnNiTXUwVUVuWDBVUEErZ2o1bHhqakliRUI0bXkvZHFyK2V5WGNUcnNTTFVL?=
 =?utf-8?B?T0VMZXl3dFo2YkRrdTZlMkdsQkVLMmpKQlhpK0VTQ2VNclpaaWtoQjlCVk0w?=
 =?utf-8?B?TlBBRHRKMlF2cVpEODVDS2EyV1kwS0JDT1lkYUJwWitLa1R5S0FZcjhPS2da?=
 =?utf-8?B?YzJLQUVWd1dmTXpyS1hhTldxZ2IwcmljN0Z0VHpiajQ2QTFvS1RmR1hkR25G?=
 =?utf-8?B?aUxOZlNiTitKcHFKMVhxYmpBR1ZFSm15QVN6Z0QwWnZyUHEzZE1zSWxrTjI5?=
 =?utf-8?B?eW9sZks0QmZJUVJOdEFsVm05d2tkQlU0VmFVM2FPM1RNNll5RG1VU1RXSG9Q?=
 =?utf-8?B?N1lXSEVpZk9ySUROSVl5SmxVcmVDSExPVFU0cnZpemErb0FSc2QzeVdDZGoz?=
 =?utf-8?B?STNDc3VMeTBvUVhtRHJUSmlINlBlaDNaRjZGb1owcDd0QUVweEh0MjIrV2t0?=
 =?utf-8?B?WU56VUtUME5SQWZSY2hHU01EeGdSQ0J1Zzl3eklvSTd0UXJBd2lOQ2dLa3Ni?=
 =?utf-8?B?SHBLRFZsZVhMVFhKcFF3NXZuQTdwaVJ0b29kSzc2bnRrZXdscE82UUh2UDNW?=
 =?utf-8?B?RUJoNjFHdjNFeWRCQ0djcDQ4eGwvdDZtREYvNHZpZzlrd0wrYkk2c0N4dlM5?=
 =?utf-8?B?YTM1RExoNisrbmlPaWxzNjFQdUJwaTFsWkk2cEROVE4wK2VGcUNxVDN6NGUr?=
 =?utf-8?B?dUNYVFBpeDFpTXBQR09DUjhsU3JWTHMyVHVMNU1vVkk0WlArR0JuTzVlOXM5?=
 =?utf-8?B?cjVqejhHRExQaktRS1RPeGVzYmU1ZFovQTRQWE8wbVpKank0VUNRSlBBSVBF?=
 =?utf-8?Q?NnBsJFgY3b7AecDL4flBcfER0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a48763bf-6b8e-4ef7-cf2b-08db11c033bc
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2023 14:55:40.4806
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OsPMrmaH6ZyEybkfdS9MwcgPOX+iicCcFbLFn6bIr93RVlntovv0W04eQ5NkTHfw/X1kQzxFJ/gWeSLPLK2qAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5076
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/13/23 10:33, Mathias Krause wrote:
> Reshuffle the boolean members of struct kvm_queued_exception and make
> them individual bits, allowing denser packing.
> 
> This allows us to shrink the object size from 24 to 16 bytes for 64 bit
> builds.
> 
> Signed-off-by: Mathias Krause <minipli@grsecurity.net>
> ---
>   arch/x86/include/asm/kvm_host.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 43329c60a6b5..040eee3e9583 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -701,13 +701,13 @@ struct kvm_vcpu_xen {
>   };
>   
>   struct kvm_queued_exception {
> -	bool pending;
> -	bool injected;
> -	bool has_error_code;
> +	u8 pending : 1;
> +	u8 injected : 1;
> +	u8 has_error_code : 1;
> +	u8 has_payload : 1;

I find doing something like this is clearer and easier to read:

	u8 pending		: 1,
	   injected		: 1,
	   has_error_code	: 1,
	   has_payload		: 1,
	   __reserved		: 4;

(you don't have to have the __reserved, though). Just throwing it out there.

Thanks,
Tom

>   	u8 vector;
>   	u32 error_code;
>   	unsigned long payload;
> -	bool has_payload;
>   };
>   
>   struct kvm_vcpu_arch {