Date:   Sat, 18 Feb 2023 17:20:21 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        linux-kernel@vger.kernel.org,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>
Subject: Re: [PATCH net-next 00/12] Add tc-mqprio and tc-taprio support for
 preemptible traffic classes
Message-ID: <20230218152021.puhz7m26uu2lzved@skbuf>
References: <20230216232126.3402975-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230216232126.3402975-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hsFCxtPvEMDn7QnqPgTYT8ZIMjZYV3X42bUiDlXmQ0eLkHzDNNj4VaLM4LwZ?=
 =?us-ascii?Q?6aIHR6DJvCNfj37WzPTYrM49rtKE66Vt64bh8xwziyLF/tz6nthacKvWlLPk?=
 =?us-ascii?Q?6EdmhIrN6cBR8LOtf0HbB4/Bydmsdw9N5dW8lVogXPpMpuz9+kV2BS+sS0xv?=
 =?us-ascii?Q?jxXsdXe4uyrI1+x0YmpoBN1Qk7EItmy8SekftT0QeXCVN6yF3pDaBIeoVis5?=
 =?us-ascii?Q?9AQvQEYoTRKo2M8nrpFxFGdLcA7KTngcI1UzrJ4mNaIEgcYdPTIA1lsvIfvg?=
 =?us-ascii?Q?QGjX0rl22pHzuUiz1e9Tme+nb1UnfKOUrbu8xBOgzuanz7HmX9cbNMEAhUX+?=
 =?us-ascii?Q?ndRELdMgPExQvsoMrHSnXSDMaIr795/VrekeO0tOU+oviWMoRFz9HcDP4r51?=
 =?us-ascii?Q?KmBYwM16bA7ch28gWehgD22HpZ0KY8Jhe1i8vhUqHmr7OxvETR8GhdE3Cf6I?=
 =?us-ascii?Q?LSAop0q5SJ63BXQ1wy5MFIpfZlTIvGMS0lpgmjNxlbbe4I62Jd4Qo2p0cyso?=
 =?us-ascii?Q?WEh7/HMVgYCWfo6qY9TxkwLBRL90VqUwmNOJcUp/u3t1XRfwTzR4Pioeucuj?=
 =?us-ascii?Q?sUtoozymenDHGhm2kTznGccfoPZRZXH3rxpHeGpCmikbPxyUR1AWU7XBG5j4?=
 =?us-ascii?Q?2wkoDZhyg5jOsthascDBZXs8NkxnnQbz/okOzNrEnAY35ygu8bDnTjOTLDkt?=
 =?us-ascii?Q?gyC0sz+ayJAkm2HQ0LVa+xoHVRU7lqxXjbUduIxsQMwTAJsWdGNWow9Qwd77?=
 =?us-ascii?Q?Iodr6LJxqvBZHHok61vXcn/h1Xs9bH1zoYoyntpugUiYnEDagWBhEEsKisDo?=
 =?us-ascii?Q?9EWmrtwqQE3Kil2B0ZJSWc18Q0YXvGyABzhrXQniYdcmMlrJJwr1VoLoI5di?=
 =?us-ascii?Q?AIfzaes4VXj5zQaZm9mdtdGO4XmYUahR5KK0qPvr9larW2pB9KdGTqR+NP5G?=
 =?us-ascii?Q?UXEaod3dvfcKptadtGBtArbeb4MqiwuBYFYsocb5CEQsIUg1MzD6uzPb9g4B?=
 =?us-ascii?Q?XZPLOzdOP6vgi9y+JmaANTbdMdAsNM6Hr85DtbTDMcGBV0JIzgfaaWOm2VRj?=
 =?us-ascii?Q?rtq/15K/nq880KQCmc+BM+5B2V58z4gAM/I2TmLiS2P9q7nJqfW3jnbJL9ie?=
 =?us-ascii?Q?K00hOTbI/fZGFX1M0AAf6b1bIzPJQ7GSz6+9guACiWNv2TOOXWAHxBg/lGC6?=
 =?us-ascii?Q?tZOQcW6+AL2v1IWyjFOxV/WnEc5xZw+sxHGo3iLWrSfooppXKD0HlMmgsXgW?=
 =?us-ascii?Q?eeRFOqc4GJWtDEJtDM/BT5Ga4z3o31CmNpX8yj092+E+rr+p4YKMYiJDL5Bh?=
 =?us-ascii?Q?YCPzzLaxb9nHIkm/JGnhMS+/tXRhBBIj3HdJUwFtHc2KtCh6icahJofJ6g9U?=
 =?us-ascii?Q?ejpDlE8k3wckrGSxPwTJC/KZ/k03TOQtGI0E+vpWVSJE7MbLpDP7Iv+a4zNZ?=
 =?us-ascii?Q?srUdIVxbhN+K6e45DK8GZ7yaC9aQ8X3tkiF/RiA6QpchtamCzTDbY+3tEuhe?=
 =?us-ascii?Q?/5lrKJtWPBZIBFNxEXlDc3CyVRRLeyiWyKfi36tydFHaLWD7iiThIN+EmzlJ?=
 =?us-ascii?Q?wDe5EYaB5KQvEDFnLnbyxjCM9WMI5CNHJO7m5oOEceGVhj3BlS0hR/6nf9he?=
 =?us-ascii?Q?BA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb1b5f2a-ec5b-48e8-441a-08db11c3a954
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2023 15:20:26.2723
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t1ram4op6p+PNDYek9iBhp3t7YtqJY+Q9G6V2fZ1I86UUgfoFMt7vKDhM06k+La+U0TPxgtzvOtiQV7fRXWVVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8444
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 17, 2023 at 01:21:14AM +0200, Vladimir Oltean wrote:
> The last RFC in August 2022 contained a proposal for the UAPI of both
> TSN standards which together form Frame Preemption (802.1Q and 802.3):
> https://patchwork.kernel.org/project/netdevbpf/cover/20220816222920.1952936-1-vladimir.oltean@nxp.com/
> 
> It wasn't clear at the time whether the 802.1Q portion of Frame Preemption
> should be exposed via the tc qdisc (mqprio, taprio) or via some other
> layer (perhaps also ethtool like the 802.3 portion).
> 
> So the 802.3 portion got submitted separately and finally was accepted:
> https://patchwork.kernel.org/project/netdevbpf/cover/20230119122705.73054-1-vladimir.oltean@nxp.com/
> 
> leaving the only remaining question: how do we expose the 802.1Q bits?
> 
> This series proposes that we use the Qdisc layer, through separate
> (albeit very similar) UAPI in mqprio and taprio, and that both these
> Qdiscs pass the information down to the offloading device driver through
> the common mqprio offload structure (which taprio also passes).
> 
> Implementations are provided for the NXP LS1028A on-board Ethernet
> (enetc, felix).
> 
> Some patches should have maybe belonged to separate series, leaving here
> only patches 09/12 - 12/12, for ease of review. That may be true,
> however due to a perceived lack of time to wait for the prerequisite
> cleanup to be merged, here they are all together.
> 
> Vladimir Oltean (12):
>   net: enetc: rename "mqprio" to "qopt"
>   net: mscc: ocelot: add support for mqprio offload
>   net: dsa: felix: act upon the mqprio qopt in taprio offload
>   net: ethtool: fix __ethtool_dev_mm_supported() implementation
>   net: ethtool: create and export ethtool_dev_mm_supported()
>   net/sched: mqprio: simplify handling of nlattr portion of TCA_OPTIONS
>   net/sched: mqprio: add extack to mqprio_parse_nlattr()
>   net/sched: mqprio: add an extack message to mqprio_parse_opt()
>   net/sched: mqprio: allow per-TC user input of FP adminStatus
>   net/sched: taprio: allow per-TC user input of FP adminStatus
>   net: mscc: ocelot: add support for preemptible traffic classes
>   net: enetc: add support for preemptible traffic classes
> 
>  drivers/net/dsa/ocelot/felix_vsc9959.c        |  44 ++++-
>  drivers/net/ethernet/freescale/enetc/enetc.c  |  31 ++-
>  drivers/net/ethernet/freescale/enetc/enetc.h  |   1 +
>  .../net/ethernet/freescale/enetc/enetc_hw.h   |   4 +
>  drivers/net/ethernet/mscc/ocelot.c            |  51 +++++
>  drivers/net/ethernet/mscc/ocelot.h            |   2 +
>  drivers/net/ethernet/mscc/ocelot_mm.c         |  56 ++++++
>  include/linux/ethtool_netlink.h               |   6 +
>  include/net/pkt_sched.h                       |   1 +
>  include/soc/mscc/ocelot.h                     |   6 +
>  include/uapi/linux/pkt_sched.h                |  17 ++
>  net/ethtool/mm.c                              |  24 ++-
>  net/sched/sch_mqprio.c                        | 182 +++++++++++++++---
>  net/sched/sch_mqprio_lib.c                    |  14 ++
>  net/sched/sch_mqprio_lib.h                    |   2 +
>  net/sched/sch_taprio.c                        |  65 +++++--
>  16 files changed, 459 insertions(+), 47 deletions(-)
> 
> -- 
> 2.34.1
>

Seeing that there is no feedback on the proposed UAPI, I'd be tempted
to resend this, with just the modular build fixed (export the
ethtool_dev_mm_supported() symbol).

Would anyone hate me for doing this, considering that the merge window
is close? Does anyone need some time to take a closer look at this, or
think about a better alternative?