Message-ID: <62832516-d4b9-add6-4925-1caeaa33d167@linux.dev>
Date:   Sat, 18 Feb 2023 16:13:19 +0000
MIME-Version: 1.0
Subject: Re: [PATCH] bnx2: remove deadcode in bnx2_init_cpus()
Content-Language: en-US
To:     Maxim Korotkov <korotkov.maxim.s@gmail.com>,
        Rasesh Mody <rmody@marvell.com>
Cc:     GR-Linux-NIC-Dev@marvell.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Michael Chan <mchan@broadcom.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
References: <20230218130016.42856-1-korotkov.maxim.s@gmail.com>
From:   Vadim Fedorenko <vadim.fedorenko@linux.dev>
In-Reply-To: <20230218130016.42856-1-korotkov.maxim.s@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18.02.2023 13:00, Maxim Korotkov wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> As a result, bnx2_init_cpus will also return only zero
> 
In this case it's safe to convert both load_cpu_fw and bnx2_init_cpus to void 
and remove the check in bnx2_init_chip. This will reduce the code a bit.