Message-ID: <5c98c586-680c-29de-2bd8-f95a7fc7e432@intel.com>
Date:   Sat, 18 Feb 2023 09:19:58 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 1/1] x86/topology: fix erroneous smp_num_siblings on Intel
 Hybrid platform
Content-Language: en-US
To:     "Zhang, Rui" <rui.zhang@intel.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc:     "Brown, Len" <len.brown@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "zhang.jia@linux.alibaba.com" <zhang.jia@linux.alibaba.com>,
        "x86@kernel.org" <x86@kernel.org>
References: <20230217163724.581513-1-rui.zhang@intel.com>
 <20230217163724.581513-2-rui.zhang@intel.com>
 <fcd46e9d-c6d0-4a01-141b-11173602475e@intel.com>
 <a0242c82631b19f3de7a223d8dd38f21308cd3cc.camel@intel.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <a0242c82631b19f3de7a223d8dd38f21308cd3cc.camel@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/18/23 08:11, Zhang, Rui wrote:
> yes. I totally agree with this.
> 
> But when showing the (cpu topology info and lscpu) problem below, I
> want to deliver a clear message that
> 1. there are two bugs and *both* of them are required in order to
>    trigger the problem
> 2. this patch just fixes one of the bugs

That's fine, but please deliver that message in the cover letter, not
the patch changelog.

> Do you mean that I don't need to mention the x86_max_cores issue here?

Yes.