Message-ID: <5de7b776-4fbe-f6f8-ffa9-fdef337c9c20@gmail.com>
Date:   Sat, 18 Feb 2023 20:11:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] Staging: r8188eu: Fixed block comment
Content-Language: en-US
To:     Khadija Kamran <kamrankhadijadj@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        paskripkin@gmail.com, gregkh@linuxfoundation.org
References: <Y+8p7Hyaf4LhO/Sw@khadija-virtual-machine>
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <Y+8p7Hyaf4LhO/Sw@khadija-virtual-machine>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/17/23 08:17, Khadija Kamran wrote:
> Fixed block comment by adding '*' in each line. The Check message was
> shown by using checkpatch.pl script.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>   drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> index a7c67014dde0..03025dc89533 100644
> --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> @@ -36,15 +36,16 @@
>   #define WAIT_TIME_PPPOE	5	/*  waiting time for pppoe server in sec */
>   
>   /*-----------------------------------------------------------------
> -  How database records network address:
> -	   0    1    2    3    4    5    6    7    8    9   10
> -	|----|----|----|----|----|----|----|----|----|----|----|
> -  IPv4  |type|                             |      IP addr      |
> -  IPX   |type|      Net addr     |          Node addr          |
> -  IPX   |type|      Net addr     |Sckt addr|
> -  Apple |type| Network |node|
> -  PPPoE |type|   SID   |           AC MAC            |
> ------------------------------------------------------------------*/
> + * How database records network address:
> + *	    0    1    2    3    4    5    6    7    8    9   10
> + *	 |----|----|----|----|----|----|----|----|----|----|----|
> + * IPv4  |type|                             |      IP addr      |
> + * IPX   |type|      Net addr     |          Node addr          |
> + * IPX   |type|      Net addr     |Sckt addr|
> + * Apple |type| Network |node|
> + * PPPoE |type|   SID   |           AC MAC            |
> + * ----------------------------------------------------------------
> + */
>   
>   /* Find a tag in pppoe frame and return the pointer */
>   static unsigned char *__nat25_find_pppoe_tag(struct pppoe_hdr *ph, unsigned short type)

Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>