Date:   Sun, 19 Feb 2023 16:46:23 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Mingwei Zhang <mizhang@google.com>
CC:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Jim Mattson" <jmattson@google.com>,
        Venkatesh Srinivas <venkateshs@google.com>,
        Aaron Lewis <aaronlewis@google.com>,
        "Chang S. Bae" <chang.seok.bae@intel.com>
Subject: Re: [PATCH v2 2/7] KVM: selftests: x86: Fix an error in comment of
 amx_test
Message-ID: <Y/Hh31GLftx3eZJY@gao-cwp>
References: <20230214184606.510551-1-mizhang@google.com>
 <20230214184606.510551-3-mizhang@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230214184606.510551-3-mizhang@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YX7i2G3lRoeCnL0VyupyrPAXKd3np8ZhzBWLDRFrhNFC9DTT/PRgKnstXEdJ?=
 =?us-ascii?Q?NHV2B0Xrc8GRGEd/RDrd7bdMFz/SjvJ0eIeXGp6GRTr1vJa4eGkUFjAMHKHE?=
 =?us-ascii?Q?OctLp/jZ8snITBjjlUpObgKECwBtAgHFyqrP6TRA2NAcoWZkXD01JOr8LH7h?=
 =?us-ascii?Q?8fJVv6bXdK45k9/i1R4ganuAxcOts3FzHbTy0cJvW4L+2dVRzQQdy23+KObS?=
 =?us-ascii?Q?avlxauGfCvUctsmmqqTE1PMPoJyWyhWeDRUXmU9K5frkvlRogKnuBqHnI8UU?=
 =?us-ascii?Q?Aeq/Wpwl/MCDg5xEAX4t6x9o1VBNNlaRUNh54Z+3hHer+KGRo1oLDtHGroVD?=
 =?us-ascii?Q?dKrlPu+5fUwRjKOqeCy3lXTIqvHt/h/ew0DtMZQ6BB7J0+Z5wSZ1KfYYmndY?=
 =?us-ascii?Q?TB8ozWgiqA6EfuSQOtbQwzWQLAlxvjvsO1kuy8SHM5USsupIhvAvYQgY9z/F?=
 =?us-ascii?Q?Pze0gzuPbJM44unp7KzxK3b6XiRKrG/CkHHai8iXxJhhSOpgu88elROY6AZe?=
 =?us-ascii?Q?h6mF189d+d3z8qzned0n8xO+CSwLPIZcfwsox6IRzmLOolyGPwPw6I+OJ2ad?=
 =?us-ascii?Q?/2a2eK/GS7Gm/B8gLCFVpQj4My6bJ2z9AzmHcRohrGowzb0FCCcDtlqWkgxj?=
 =?us-ascii?Q?I63Sf/uDfsemL2iM9k5FAsYTJzFIK5e1lnmA+Gh6NT+6X3qzyHJEuJM8dB8x?=
 =?us-ascii?Q?Mi9+s7GA4dB5MKekGCgZsLOULxOr2Sbw16d7ASP9FOw1498SOfEcBlYfSorx?=
 =?us-ascii?Q?L6vOZRPArvVKPZvPN0RNPuXNRMXYg4AWlQ7vhA0RgdsQn1/ZQbg4+lVA9fdC?=
 =?us-ascii?Q?6sids+A31OSFZVj3F88BpbyFoJt1eFWAMsrwD0IPPOnzp6vNW0kCkDRMsgsM?=
 =?us-ascii?Q?Xc0haO0mwI0+MVSKDixs2WnJU4Nu8U8VTq+NkfX0C2nRAQ0Nn0+VhC68lYzq?=
 =?us-ascii?Q?GAlXAVq/YvGYh8oQJHX08NgqQaWkLe8KHs1tfJlFtlAwxYfj/+pRJyKrmxBZ?=
 =?us-ascii?Q?FDp39rlNCJ1is/nTN1HySdT505XT7cS2jXdLYWN39dAi64KCf5I5zIIovtDt?=
 =?us-ascii?Q?S6Iicm58bj2cttS4koAP885twc+YJ6gF5b7GHRfdoN5z+K2w8ihixxxHfNa8?=
 =?us-ascii?Q?r+kKebxvIj9bLt5BYV3m4+gPyOFnQttTgA6nB0Sf61GHC8y9/mZmf8BX9t5R?=
 =?us-ascii?Q?PVkL6hr2HHcmQuTSi2fC6IQMeDj22P1O7SvOUfEQ6xtkOeypFZUV9cRGPtln?=
 =?us-ascii?Q?zMusT4ppqn6jv5Pqd3BwBDwWa2AoKOoedMec3dwVCdvkDLBYi5aWTQTTf8nk?=
 =?us-ascii?Q?o/t8mZSiuJlTkrqA+gazRjAkVBwpH7Zan862VKcFljnTtQLt/yF4sYjWvsQ+?=
 =?us-ascii?Q?/ON6QL0F55vek3Ae9vriYwJKAjLgHsUK93p/EU83dVq2G5OdjdYNklmmdg/r?=
 =?us-ascii?Q?aR+AYnYhiZzNSJRuCQJHbxfiUFZKjJObtariQy5Rq9Mz0yyDZauIrQZq/Yiu?=
 =?us-ascii?Q?AtTzEWGyzIIYx/zrb4akQYSFybLbvI9h3Fa7djTIidGFO7QBrLTNMrqEttzX?=
 =?us-ascii?Q?VSIXnbDOnvIl353O3iHCB9rPySwFp+Jq9U68jLor?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ddb096b-acd4-40ba-d40b-08db1255bbf0
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 08:46:03.9418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HKsvq+l90iSAj8f2BKmhzkVgOCcLvwHOqjytWo6cjScixrGXhwR1o3JhrlqxgI5988e64PCTIX5Zj0/Uio+HEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5406
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 14, 2023 at 06:46:01PM +0000, Mingwei Zhang wrote:
>After the execution of __tilerelease(), AMX component will be in INIT
>state. Therefore, execution of XSAVEC saving the AMX state into memory will
>cause the xstate_bv[18] cleared in xheader. However, the xcomp_bv[18] will
>remain set. Fix the error in comment. Also, update xsavec() to XSAVEC
>because xcomp_bv[18] is set due to the instruction, not the function.
>Finally, use XTILEDATA instead 'bit 18' in comments.
>
>Cc: Jim Mattson <jmattson@google.com>
>Cc: Venkatesh Srinivas <venkateshs@google.com>
>Cc: Aaron Lewis <aaronlewis@google.com>
>Signed-off-by: Mingwei Zhang <mizhang@google.com>
>---
> tools/testing/selftests/kvm/x86_64/amx_test.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c
>index d506821a5a26..aac727ff7cf8 100644
>--- a/tools/testing/selftests/kvm/x86_64/amx_test.c
>+++ b/tools/testing/selftests/kvm/x86_64/amx_test.c
>@@ -190,7 +190,10 @@ static void __attribute__((__flatten__)) guest_code(struct tile_config *amx_cfg,
> 	GUEST_SYNC(4);
> 	__tilerelease();
> 	GUEST_SYNC(5);
>-	/* bit 18 not in the XCOMP_BV after xsavec() */
>+	/*
>+	 * After XSAVEC, XTILEDATA is cleared in the xstate_bv but is set in
>+	 * the xcomp_bv.
>+	 */
> 	xstate->header.xstate_bv = XFEATURE_MASK_XTILEDATA;
> 	__xsavec(xstate, XFEATURE_MASK_XTILEDATA);
> 	GUEST_ASSERT(!(xstate->header.xstate_bv & XFEATURE_MASK_XTILEDATA));

maybe it would be better to add another GUEST_ASSERT() to enforce that
XTILEDATA is set in the xcomp_bv.

>-- 
>2.39.1.581.gbfd45094c4-goog
>