Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757315AbXIINqQ (ORCPT ); Sun, 9 Sep 2007 09:46:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755953AbXIINqG (ORCPT ); Sun, 9 Sep 2007 09:46:06 -0400 Received: from one.firstfloor.org ([213.235.205.2]:37126 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755902AbXIINqF (ORCPT ); Sun, 9 Sep 2007 09:46:05 -0400 Date: Sun, 9 Sep 2007 15:46:02 +0200 From: Andi Kleen To: "James C. Georgas" Cc: Andi Kleen , Randy Dunlap , linux-kernel@vger.kernel.org Subject: Re: [PATCH] KCONFIG: fix pseudo dependency between K8_NUMA and X86_64_ACPI_NUMA config options Message-ID: <20070909134602.GA25798@one.firstfloor.org> References: <1189291899.13467.20.camel@Tachyon.home> <20070908180904.656f3d03.randy.dunlap@oracle.com> <1189300961.13467.47.camel@Tachyon.home> <1189343945.7365.9.camel@Tachyon.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1189343945.7365.9.camel@Tachyon.home> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 28 On Sun, Sep 09, 2007 at 09:19:05AM -0400, James C. Georgas wrote: > On Sun, 2007-09-09 at 11:07 +0200, Andi Kleen wrote: > > "James C. Georgas" writes: > > > > > > It's 2.6.22.6. I'm thinking a fix would be to add "select PM" to > > > X86_64_ACPI_NUMA. > > > > > > I'm also thinking that maybe K8_NUMA should be changed from "depends on > > > PCI" to "select PCI", like X86_64_ACPI_NUMA is. That would fix the > > > pseudo dependency they have between them (i.e. selecting > > > X86_64_ACPI_NUMA causes PCI to be selected, which then makes K8_NUMA > > > visible, because its PCI dependency is now satisfied). > > > > Sounds reasonable. Can you please submit a tested patch with proper > > description and Signed-off-by lines? > > > > -Andi > > How's this? Thanks. How about a fix for the other problem (ACPI_NUMA- PM) too? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/