Subject: Re: [PATCH] irq: ipi: fix NULL pointer deref in
 irq_data_get_affinity_mask()
To:     Thomas Gleixner <tglx@linutronix.de>,
        <linux-kernel@vger.kernel.org>
References: <b541232d-c2b6-1fe9-79b4-a7129459e4d0@omp.ru>
 <774e2812-2856-f146-b8b3-e4f772c5e38a@omp.ru> <875ycb2jwe.ffs@tglx>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <028ccd43-1474-1f90-653e-044641cc533f@omp.ru>
Date:   Sun, 19 Feb 2023 13:20:22 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <875ycb2jwe.ffs@tglx>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled
X-KSE-Antivirus-Interceptor-Info: scan successful
X-KSE-Antivirus-Info: Clean, bases: 2/19/2023 9:03:00 AM
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/9/23 1:49 PM, Thomas Gleixner wrote:
[...]

>>> Iff ipi_send_{mask|single}() get called with e.g. an invalid IRQ #, all the
>>> local variables there will be NULL -- the problem is that ipi_send_verify()
>>> (that's called first thing) doesn't verify its 'data' parameter, resulting
>>> in a kernel oops in irq_data_get_affinity_mask() as the passed NULL pointer
>>> gets dereferenced.  Add a missing NULL check in ipi_send_verify()...
>>>
>>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>>> analysis tool.
>>>
>>> Fixes: 3b8e29a82dd1 ("genirq: Implement ipi_send_mask/single()")
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>>    Patch fell thru the cracks? :-/
> 
> Obviously :)
> 
> /me goes to find trash tongs to pick it up

   Need help? :-)

MBR, Sergey