Date:   Sun, 19 Feb 2023 20:52:57 +0800
From:   Zhenyu Wang <zhenyuw@linux.intel.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        Zhi Wang <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu
 presentation
Message-ID: <Y/IbqTv0yOcPl3yP@debian-scheme>
Reply-To: Zhenyu Wang <zhenyuw@linux.intel.com>
References: <20230215044533.4847-1-rdunlap@infradead.org>
 <Y+7d7xKjjzRnV9eI@debian-scheme>
 <bd1597ba-21c9-e1a8-8851-4e7c95b28b65@infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="bCCMBWSwmp2FPuGZ"
Content-Disposition: inline
In-Reply-To: <bd1597ba-21c9-e1a8-8851-4e7c95b28b65@infradead.org>
Precedence: bulk


--bCCMBWSwmp2FPuGZ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2023.02.16 22:32:33 -0800, Randy Dunlap wrote:
> Hi,
>=20
> On 2/16/23 17:52, Zhenyu Wang wrote:
> > On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
> >> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_G=
VT)
> >> into a list of other symbols that do have a dependency (on DRM_I915)
> >> breaks the driver menu presentation in 'make *config'.
> >>
> >=20
> > I'm not sure what's the actual failure in presentation, I'm not quite f=
amiliar
> > with Kconfig, could you help to elaborate?
> >=20
> > thanks!
>=20
> For menuconfig and nconfig, it's a subtle difference. The following menu
> items are indented more after the patch (i.e., they are not indented enou=
gh
> before the patch):
>=20
>  =E2=94=82 <M>   Enable KVM host support Intel GVT-g graphics virtualizat=
ion          =E2=94=82
>  =E2=94=82 [*]   Enable Intel PXP support                                =
             =E2=94=82
>  =E2=94=82       drm/i915 Debugging  --->                                =
             =E2=94=82
>  =E2=94=82       drm/i915 Profile Guided Optimisation  --->
>=20
> Same menu items for gconfig: they should all be subordinate (so indented)
> to the main
> <M> Intel 8xx/9xx/G3x/G4x/HD Graphics
> menu.
>=20
> For xconfig, it's worse. "drm/i915 Debugging" and "drm/i915 Profile Guide=
d Optimisation"
> are shown on the left side window, while are of the other i915 options ar=
e shown in the
> right side window (before the patch).
> After the patch, all subordinate options are listed in the right side win=
dow under the
> main "Intel 8xx/9xx/G3x/G4x/HD Graphics" menu item.
>=20
> See attached photos for comparisons.
>=20

I wasn't awared of the wrong indentation. Thanks a lot, Randy!

Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>

--bCCMBWSwmp2FPuGZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCY/IbpQAKCRCxBBozTXgY
J7KqAJ9ai4/UyyDGoRUOJQD34MJmFdFyvQCfYnyyPgV1EKMhMrDKUnh9nVBfBeY=
=nrt2
-----END PGP SIGNATURE-----

--bCCMBWSwmp2FPuGZ--