From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Roger Quadros <rogerq@kernel.org>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        linux-kernel@vger.kernel.org,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Wong Vee Khee <vee.khee.wong@linux.intel.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
        Jacob Keller <jacob.e.keller@intel.com>
Subject: [PATCH v2 net-next 04/12] net: ethtool: fix __ethtool_dev_mm_supported() implementation
Date:   Sun, 19 Feb 2023 15:53:00 +0200
Message-Id: <20230219135309.594188-5-vladimir.oltean@nxp.com>
In-Reply-To: <20230219135309.594188-1-vladimir.oltean@nxp.com>
References: <20230219135309.594188-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tpv/veH8FN4HiKcdueRMYHZ9xqXrZ2omjrgCKV1GjlPmy1bpi/ziNi47DUJ6?=
 =?us-ascii?Q?QmJNDifhOa+Ga6aluTJpmXcUs3YFG+no8P3NTEi2CccmWx1yVuQXj8efv1Bs?=
 =?us-ascii?Q?ZNcHJBC3Ps/j/T0vOgisB9fODScT8gr/a9+ubKlXtsW4ceSzp9x7W/m+Fusy?=
 =?us-ascii?Q?Mi4qAepjPZASJmPFtcshQLqw5JbbKJzwbZTxV4S0eU2jcc+tycgfuX73A2Ty?=
 =?us-ascii?Q?GmMioRYjy63L3tsVfeVt5HERkS2URLK6m1eJpQa+ctqBi2GXzrnf49eSV2De?=
 =?us-ascii?Q?5R5trSfThM7OQgNbrdmXbLWUibsRWfFdOK4+n5RIr2H9W1iKeFOoM8aHwYzV?=
 =?us-ascii?Q?ubuXwmQ2ms9uxtcqHS+iboIl+kVn4N5YgsBU1XUJvDLkmE6UcVlutnPfNzZJ?=
 =?us-ascii?Q?JUz9He6TPCdPvUXuLMvjMwhSqM4DXMHMFd40uZRnyzoDGTQdVH9v4pjJVJUY?=
 =?us-ascii?Q?AHSI8yKC2rc/u4SVEGgtg2g7EuFN4TGF2+6bntYhdueno3whAw8ECa8+2tyK?=
 =?us-ascii?Q?K9nK4HFv/H+WBTfpa7Gl70LrHjUpt/DX4a3nBkp74sIQfe0Bc8T0uuXFnR3d?=
 =?us-ascii?Q?AhSMZJW1WvbPxua9jrfflNNEghOop8mBPmUEuqfzci3JwHWBCXibC7O5gqBY?=
 =?us-ascii?Q?KMYtp9ZYWGI3KKf0BrK4PvmpA0sui+n3hhm2rqdx3z5Ps3quGg4u7JD0DacK?=
 =?us-ascii?Q?iGaCjOJxvrNnsfIAxET46piVdeMV0EQB0IJC3N1Hd9k0qPforEka5wceJzuf?=
 =?us-ascii?Q?nkqjMa2GPzOerY43RkW6wbJm/fynW8ht8CigE8Mfbxj5yhYk31gZCcPJoXNL?=
 =?us-ascii?Q?O4b/mBiLajyVhrb5idUy8F+CbfgzsNvGEXjmsTPxtfWhzumH8updhy9p60FN?=
 =?us-ascii?Q?caMirGN68ZoPdqSgcAd//0NJQ/omacXY96/kun6ftpgj6B+T2MDc72ZZfMbg?=
 =?us-ascii?Q?8p6jQ1iScl8e0/95Zpkwf5pDxrLztCwp/BbEsaThwqHzinAkah3XUWe7PbsT?=
 =?us-ascii?Q?9/gW5UK8gYtZvLVsfEY9A1w03kJkx85gF+gyklcHtrHRIeAJeaku76DI+y0R?=
 =?us-ascii?Q?ac37abZjgmr+SCwZd/wiZZHXI+4GbtjDo+YITWx4Kw9MDNmpbFORi5lp2ZXH?=
 =?us-ascii?Q?Mb3hpADRlbixY6KXImsiItCJlAfMyP4kUdc+PtyJ+G5v+PuXFz8dNOFJ4xqv?=
 =?us-ascii?Q?pGGGcoRuXu9KOojTUNiFbnLngrfFYzl23eXODM6lLtAD+hnAY/Cg3fmkZdoH?=
 =?us-ascii?Q?nMpnDIDttgHg3CC3Gm/X5j4Jsklx8EVtXJDq0Ru6oETCKJYApA9xrCjU+0X0?=
 =?us-ascii?Q?dhwb+PiffWM9Ioyr4krQQMNS0ERniIh9IvJYA8A1h6gxp3npgfczZPUAiOP5?=
 =?us-ascii?Q?AeindV/wQVzvbuVo7A19I+0ikjqovuTaeFLLKxcnTuV7gsr1RVVc9aqERIK7?=
 =?us-ascii?Q?ZdrWmZcYfT4NMaVvd0zlovTXJEcQiN3B4I6dLxf5M6OgKZgbzCCeQij8fq4q?=
 =?us-ascii?Q?MHXD7SzO/27U1q38Lxqr6RjLcIbDdgjzzTBprhKiXXg66GdeXkfG9tISS6g0?=
 =?us-ascii?Q?3X40Y1GDb6j6CKUXBkO+Mwgrre6cNhIlHnoFGQ+huJZmnZrTL8kpdzVzl1DB?=
 =?us-ascii?Q?tg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1065324f-985e-4e8e-ce7a-08db1280b79e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 13:53:45.0996
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nEK9m9NPv52IjDXXbjP1S8ov+aD30ndPd8tAS7Srj3/dt9BN9ANYB6Hk3MR6C/jq2L9qtiwAOFcDukWb6yGOXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8238
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The MAC Merge layer is supported when ops->get_mm() returns 0.
The implementation was changed during review, and in this process, a bug
was introduced.

Link: https://patchwork.kernel.org/project/netdevbpf/patch/20230111161706.1465242-5-vladimir.oltean@nxp.com/
Fixes: 04692c9020b7 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: none

 net/ethtool/mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c
index e612856eed8c..fce3cc2734f9 100644
--- a/net/ethtool/mm.c
+++ b/net/ethtool/mm.c
@@ -247,5 +247,5 @@ bool __ethtool_dev_mm_supported(struct net_device *dev)
 	if (ops && ops->get_mm)
 		ret = ops->get_mm(dev, &state);
 
-	return !!ret;
+	return !ret;
 }
-- 
2.34.1