Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D7DC05027 for ; Sun, 19 Feb 2023 14:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbjBSOKG (ORCPT ); Sun, 19 Feb 2023 09:10:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbjBSOKE (ORCPT ); Sun, 19 Feb 2023 09:10:04 -0500 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 219CDD510; Sun, 19 Feb 2023 06:10:03 -0800 (PST) Received: by mail-qk1-x72e.google.com with SMTP id w4so28593qkw.4; Sun, 19 Feb 2023 06:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7fr2lIso7bpIUD7Ha1nqI8K+I3x8DLSNI6+bQlnGF+k=; b=IX4GE9MaRsieijPWNpdzJP4LX1Q29TIa+xP+iUIR9KvBiN1zjhKHaiCNuTpGiKnTiH Leb17rrsVfxr6rxPPTn9UD+4zp/93qOZnFG0Zz3MTRJVNX7B8edZ+JIn+cm9usrxfcFt md1NELfQrvWYidiKR9508qDxUewGMvpQeQoHgM49swqpMSb6bZopgwli14eexUejf0J0 o6z1PpCy8E1ehfulj4xHoJOa2Q+EjqWZWVU480pH27rCouUPrwORvSuuqdlcd2CrIhLM GPg7C6sRAoC1kgohoDymxXW4zTnkmNNbeFN+G5GUb1cxEoFacYcp/oh2Xj99/yW0/LE8 jN8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7fr2lIso7bpIUD7Ha1nqI8K+I3x8DLSNI6+bQlnGF+k=; b=wFdqTWNN+ecrGM5g6pYwTixUQy6wcOaJetikM8bqu6i7KMjs1EqNhOrH82ewfNZfJL SaRKrUo4L7l3Z+FFK2s/BN/cZDMk1RUtcI+YwqoRy+rb6NrOO5dU1YUxOVxRnn/9apqH WQAfOZNS26C+xkV0vHTHns/rvNsbqeDP7mogWm+0204t7OjhHeUiOVUBMGpyRbK01BLW ZejopZrjYhO8v9X0ThxW0iWebq/Y+SQrPZ1JwVxfyV8qyYkKD6YWjiwUCQMhLfV1UsX/ mOgkkCBIYXIxa8SAUb9j2SRloIS1rfeM/KEk8d5Fzb/zhyUQPDubtwuiUxsK+lqyXeS+ UpUA== X-Gm-Message-State: AO0yUKUCsHSBCOT+DLvcB/ZzLQ89muf0hPdvbmAmgZrHm1LVZD1XYnGZ xUmib2F5yg8xCTEU4/h/8UYNC0VVM9reVavUMTM= X-Google-Smtp-Source: AK7set+clf2xmfexuw1XmRCmusE/KdeVHwwYxVr5A/glHe9HDYyvGTmY8ad5/pz4ykamUQVOdCKpAsgMIacdUwAEdgk= X-Received: by 2002:ae9:f716:0:b0:71f:b8ba:ff4c with SMTP id s22-20020ae9f716000000b0071fb8baff4cmr614308qkg.10.1676815802247; Sun, 19 Feb 2023 06:10:02 -0800 (PST) MIME-Version: 1.0 References: <20230218090709.7467-1-orlandoch.dev@gmail.com> <20230218090709.7467-3-orlandoch.dev@gmail.com> In-Reply-To: <20230218090709.7467-3-orlandoch.dev@gmail.com> From: Andy Shevchenko Date: Sun, 19 Feb 2023 16:09:26 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] HID: hid-apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards To: Orlando Chamberlain Cc: linux-doc@vger.kernel.org, linux-input@vger.kernel.org, Jonathan Corbet , Jiri Kosina , Benjamin Tissoires , linux-kernel@vger.kernel.org, Pavel Machek , Aditya Garg , Aun-Ali Zaidi , Kerem Karabay , Andy Shevchenko , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 18, 2023 at 11:08 AM Orlando Chamberlain wrote: > > This driver adds support for the keyboard backlight on Intel T2 Macs > with internal Magic Keyboards (MacBookPro16,x and MacBookAir9,1) ... > + help > + Say Y here if you want support for the keyboard backlight on Macs with > + the magic keyboard (MacBookPro16,x and MacBookAir9,1). Note that this > + driver is not for external magic keyboards. > + > + To compile this driver as a module, choose M here: the > + module will be called hid-apple-magic-backlight. Is it my email client or is the indentation of the help text incorrect? Hint: the text of the help should be indented. I believe checkpatch.pl at least in --strict mode should complain about this. -- With Best Regards, Andy Shevchenko