Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D4AC64EC4 for ; Sun, 19 Feb 2023 14:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230149AbjBSOhg (ORCPT ); Sun, 19 Feb 2023 09:37:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbjBSOhc (ORCPT ); Sun, 19 Feb 2023 09:37:32 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1E1A11168 for ; Sun, 19 Feb 2023 06:37:26 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id m7so532477wrr.13 for ; Sun, 19 Feb 2023 06:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pnsqbAY13Isy9Q4vAmb7bu7Jt4464vvs/IoNIYDr6xU=; b=hSKy+u5AgwaR/pjI3BVInARul9SXO0sQyw0n7yjY6yRDSg8BEuFLd5I5qrTlEpimNM Xjpl9UAbCCo9nok1y4IpVJ9MLE2XeHXG98wOfKu2d3NCxoPBH32UMAye1vooyYx1ErnD ricWKv9mPs3ba1qo4onNdonbsz4f+fGKOjQzVkGBoYVRHfTNp0sTV4wutDcxSYtnm8CH pxpYUDxS0coiNJcCa7tzwePTrwb9jeloVabBqo+ddLL3pZ7VUpIfX0IhEiKOfXtx1d/8 1rUFK2J6S7yGqO9Iwiv++xzaS+2n7XjMuTbyAivc3fVQKvuBI/RXADB6caPXI29TjPRh O0eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pnsqbAY13Isy9Q4vAmb7bu7Jt4464vvs/IoNIYDr6xU=; b=Pway4/Q4x0XhBssw8xSo/FGAmNdSFjqVSD4zRCxT+0Bk/P5y/StqzQiLy9jC0hhtoN LoNU+6krtiW/5ZKGFeYXJsTl5bpiOpyZ8cMRNODQGIaC+t6V8jVxs7Cz9dRFxJUphixB B91zJ0ZVjXjxBLfWPrP23Rm1c0A+uZMLUprtDMTwDP+Mia/ngXYsBZJXYkZrDwUw1OG+ L8oUgLnv81BV6N4JFOAOW/YcJ5bRoYntrJFOO48qVIUdKcH2C7WV+8G0ng8sL0OXXCeb q3yuFG9QvpCc3W+RSEhIhUk910GGjWvH3T7A6Uu06bJPv9BuAoZdlWcnFo7XdlmCITj7 CU8Q== X-Gm-Message-State: AO0yUKW350jURHoQs5TOAIhbwhED/KUF3GH5apLiVG+9ERBVmuJv6BIW pZZ28mKBiWJqVP2z9gS92FEkdQ== X-Google-Smtp-Source: AK7set9gXafURZgOj1Yem7EqSUruiomk29jrLU507lTzAdGLNHnFcqKBP+ki22tLjJJTUzMVG5WPYw== X-Received: by 2002:adf:f84e:0:b0:2c5:5048:8a6a with SMTP id d14-20020adff84e000000b002c550488a6amr1432164wrq.60.1676817444373; Sun, 19 Feb 2023 06:37:24 -0800 (PST) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:6f43:b92:7670:463]) by smtp.gmail.com with ESMTPSA id a18-20020adfe5d2000000b002be505ab59asm86176wrn.97.2023.02.19.06.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 06:37:23 -0800 (PST) From: Daniel Lezcano To: rafael@kernel.org, daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Rui , Len Brown , Damien Le Moal , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Jean Delvare , Guenter Roeck , Jonathan Cameron , Lars-Peter Clausen , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Dmitry Torokhov , Raju Rangoju , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ido Schimmel , Petr Machata , Gregory Greenman , Kalle Valo , Sebastian Reichel , Liam Girdwood , Mark Brown , Miquel Raynal , Amit Kucheria , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Markus Mayer , Support Opensource , Andy Gross , Bjorn Andersson , Konrad Dybcio , Thara Gopinath , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Heiko Stuebner , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Orson Zhai , Baolin Wang , Chunyan Zhang , Vasily Khoruzhick , Yangtao Li , Thierry Reding , Jonathan Hunter , Talel Shenhar , Eduardo Valentin , Keerthy , Kunihiko Hayashi , Masami Hiramatsu , Matthias Brugger , AngeloGioacchino Del Regno , Stefan Wahren , Zheng Yongjun , Yang Li , Srinivas Pandruvada , Daniel Golle , Balsam CHIHI , Mikko Perttunen , linux-acpi@vger.kernel.org, linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v1 00/17] Self-encapsulate the thermal zone device structure Date: Sun, 19 Feb 2023 15:36:40 +0100 Message-Id: <20230219143657.241542-1-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The exported thermal headers expose the thermal core structure while those should be private to the framework. The initial idea was the thermal sensor drivers use the thermal zone device structure pointer to pass it around from the ops to the thermal framework API like a handler. Unfortunately, different drivers are using and abusing the internals of this structure to hook the associated struct device, read the internals values, take the lock, etc ... rn order to fix this situation, let's encapsulate the structure leaking the more in the different drivers: the thermal_zone_device structure. This series revisit the existing drivers using the thermal zone private structure internals to change the access to something else. For instance, the get_temp() ops is using the tz->dev to write a debug trace. Despite the trace is not helpful, we can check the return value for the get_temp() ops in the call site and show the message in this place. With this set of changes, the thermal_zone_device is almost self-encapsulated. As usual, the acpi driver needs a more complex changes, so that will come in a separate series along with the structure moved the private core headers. Cc: "Rafael J. Wysocki" Cc: Zhang Rui Cc: Len Brown Cc: Damien Le Moal Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Jean Delvare Cc: Guenter Roeck Cc: Jonathan Cameron Cc: Lars-Peter Clausen Cc: Chen-Yu Tsai Cc: Jernej Skrabec Cc: Samuel Holland Cc: Dmitry Torokhov Cc: Raju Rangoju Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Ido Schimmel Cc: Petr Machata Cc: Gregory Greenman Cc: Kalle Valo Cc: Sebastian Reichel Cc: Liam Girdwood Cc: Mark Brown Cc: Miquel Raynal Cc: Daniel Lezcano Cc: Amit Kucheria Cc: Florian Fainelli Cc: Broadcom internal kernel review list Cc: Ray Jui Cc: Scott Branden Cc: Markus Mayer Cc: Support Opensource Cc: Andy Gross Cc: Bjorn Andersson Cc: Konrad Dybcio Cc: Thara Gopinath Cc: "Niklas Söderlund" Cc: Heiko Stuebner Cc: Bartlomiej Zolnierkiewicz Cc: Krzysztof Kozlowski Cc: Alim Akhtar Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Cc: Vasily Khoruzhick Cc: Yangtao Li Cc: Thierry Reding Cc: Jonathan Hunter Cc: Talel Shenhar Cc: Eduardo Valentin Cc: Keerthy Cc: Kunihiko Hayashi Cc: Masami Hiramatsu Cc: Matthias Brugger Cc: AngeloGioacchino Del Regno Cc: Stefan Wahren Cc: Zheng Yongjun Cc: Yang Li Cc: Srinivas Pandruvada Cc: Daniel Golle Cc: Balsam CHIHI Cc: Mikko Perttunen Cc: linux-acpi@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-ide@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-hwmon@vger.kernel.org Cc: linux-iio@vger.kernel.org Cc: linux-sunxi@lists.linux.dev Cc: linux-input@vger.kernel.org Cc: netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org Cc: linux-pm@vger.kernel.org Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-tegra@vger.kernel.org Cc: linux-omap@vger.kernel.org Cc: linux-mediatek@lists.infradead.org Daniel Lezcano (17): thermal/core: Add a thermal zone 'devdata' accessor thermal/core: Show a debug message when get_temp() fails thermal: Remove debug or error messages in get_temp() ops thermal/hwmon: Do not set no_hwmon before calling thermal_add_hwmon_sysfs() thermal/hwmon: Use the right device for devm_thermal_add_hwmon_sysfs() thermal: Don't use 'device' internal thermal zone structure field thermal/hwmon: Use the thermal API instead tampering the internals thermal/drivers/spear: Don't use tz->device but pdev->dev thermal: Add a thermal zone id accessor thermal: Do not access 'type' field, use the tz id instead thermal/drivers/da9062: Don't access the thermal zone device fields thermal/hwmon: Use the thermal_core.h header thermal/drivers/tegra: Remove unneeded lock when setting a trip point thermal/tegra: Do not enable the thermal zone, it is already enabled thermal/drivers/acerhdf: Make interval setting only at module load time thermal/drivers/acerhdf: Remove pointless governor test thermal/traces: Replace the thermal zone structure parameter with the field value drivers/acpi/thermal.c | 18 +++---- drivers/ata/ahci_imx.c | 2 +- drivers/hwmon/hwmon.c | 4 +- drivers/hwmon/pmbus/pmbus_core.c | 2 +- drivers/hwmon/scmi-hwmon.c | 4 +- drivers/hwmon/scpi-hwmon.c | 2 +- drivers/iio/adc/sun4i-gpadc-iio.c | 2 +- drivers/input/touchscreen/sun4i-ts.c | 2 +- .../ethernet/chelsio/cxgb4/cxgb4_thermal.c | 2 +- .../ethernet/mellanox/mlxsw/core_thermal.c | 18 +++---- drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 4 +- drivers/platform/x86/acerhdf.c | 19 ++------ drivers/power/supply/power_supply_core.c | 2 +- drivers/regulator/max8973-regulator.c | 2 +- drivers/thermal/amlogic_thermal.c | 2 +- drivers/thermal/armada_thermal.c | 14 ++---- drivers/thermal/broadcom/bcm2711_thermal.c | 3 +- drivers/thermal/broadcom/bcm2835_thermal.c | 3 +- drivers/thermal/broadcom/brcmstb_thermal.c | 8 ++-- drivers/thermal/broadcom/ns-thermal.c | 2 +- drivers/thermal/broadcom/sr-thermal.c | 2 +- drivers/thermal/da9062-thermal.c | 13 +++-- drivers/thermal/dove_thermal.c | 7 +-- drivers/thermal/gov_fair_share.c | 2 +- drivers/thermal/gov_power_allocator.c | 4 +- drivers/thermal/gov_step_wise.c | 2 +- drivers/thermal/hisi_thermal.c | 5 +- drivers/thermal/imx8mm_thermal.c | 4 +- drivers/thermal/imx_sc_thermal.c | 9 ++-- drivers/thermal/imx_thermal.c | 47 +++++-------------- drivers/thermal/intel/intel_pch_thermal.c | 2 +- drivers/thermal/intel/intel_soc_dts_iosf.c | 13 ++--- drivers/thermal/intel/x86_pkg_temp_thermal.c | 4 +- drivers/thermal/k3_bandgap.c | 4 +- drivers/thermal/k3_j72xx_bandgap.c | 2 +- drivers/thermal/kirkwood_thermal.c | 7 +-- drivers/thermal/max77620_thermal.c | 6 +-- drivers/thermal/mediatek/auxadc_thermal.c | 4 +- drivers/thermal/mediatek/lvts_thermal.c | 9 ++-- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 6 +-- drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 6 +-- drivers/thermal/qcom/tsens.c | 4 +- drivers/thermal/qoriq_thermal.c | 4 +- drivers/thermal/rcar_gen3_thermal.c | 5 +- drivers/thermal/rcar_thermal.c | 8 +--- drivers/thermal/rockchip_thermal.c | 8 +--- drivers/thermal/rzg2l_thermal.c | 3 +- drivers/thermal/samsung/exynos_tmu.c | 4 +- drivers/thermal/spear_thermal.c | 10 ++-- drivers/thermal/sprd_thermal.c | 2 +- drivers/thermal/st/st_thermal.c | 2 - drivers/thermal/sun8i_thermal.c | 4 +- drivers/thermal/tegra/tegra-bpmp-thermal.c | 6 ++- drivers/thermal/tegra/tegra30-tsensor.c | 31 ++++++------ drivers/thermal/thermal-generic-adc.c | 7 ++- drivers/thermal/thermal_core.c | 17 ++++++- drivers/thermal/thermal_helpers.c | 3 ++ drivers/thermal/thermal_hwmon.c | 19 +++----- drivers/thermal/thermal_hwmon.h | 4 +- drivers/thermal/thermal_mmio.c | 2 +- .../ti-soc-thermal/ti-thermal-common.c | 10 ++-- drivers/thermal/uniphier_thermal.c | 2 +- include/linux/thermal.h | 4 ++ include/trace/events/thermal.h | 24 +++++----- .../trace/events/thermal_power_allocator.h | 12 ++--- 65 files changed, 203 insertions(+), 265 deletions(-) -- 2.34.1