Message-ID: <OS3P286MB2295A23718762BB07BCB6007F5A79@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM>
Date:   Sun, 19 Feb 2023 22:46:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH net-next v1 1/1] net: openvswitch: ovs_packet_cmd_execute
 put sw_flow mainbody in stack
To:     Simon Horman <simon.horman@corigine.com>
Cc:     netdev@vger.kernel.org, Pravin B Shelar <pshelar@ovn.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, dev@openvswitch.org,
        linux-kernel@vger.kernel.org
References: <OS3P286MB229509B8AD0264CC84F57845F5A69@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM>
 <Y/IqJvWEJ+UNOs6i@corigine.com>
Content-Language: en-US
From:   Eddy Tao <taoyuan_eddy@hotmail.com>
In-Reply-To: <Y/IqJvWEJ+UNOs6i@corigine.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: OS3P286MB2295:EE_|TYCP286MB2640:EE_
X-MS-Office365-Filtering-Correlation-Id: 80e989fa-d9ae-4879-576f-08db12881e44
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +MHbCZHWtbEpvnUTmYzHQnEnn0bhbqEHbrZ/c1mthKqXz+Zyh4fZIPvUBra0+r2/Cxe+aGr+iQhNa7UIQsS+ML4Xh5ILYa3Elx1It/F7xOv7fR4HtPUCLiYiarKk005zlU3BrxcNqCkyPs+RaoRiLLHMhjDtnTayzvMO3YdpRgkodBYLaHVogSADioJPKrOeZnjC8tCKpXHfZk0bJLtL2Vu46s2qNFCRgtPhPqybi34bVU7nhMfUc4zPFqsheCNuFXX3gNzaf8msl6O9q7zxTOldqia9j/rGLqiTjFKU46JZWHXsVfwXLh/dGZfek8OMwjTVFBWmVnOdZ1hmFaL0BlmzjgyfF6Um6fGmE0yHAna7uBGNST53jDMKk/+mzDnPWnfTpP/JGuvboxVfpyExNec7P6krIgCA6p0CYgmeoDLl4D/07C15imX6NCKdSfTwA0gOg2INBwLinvhq0Sty1KY4fBTJ1W7uJ75zdSCf74N2omk3XQHZdQisEoestXTNk4AaWee8fnSZzO+zi647/UUjsblEQi6EdTc+yBNAIfGNML2Q0I1ShI9506C7iiBnhviBk346EyUggeFbIg9rn2dZ9fpTa4yGwRuQDVyQjgVjZdVbQVomz7IMi0ik4XpSbVZKIhca0FAcWEAneyxfQQ==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWNnRWM3ZGFxQXFaNzVZcTRHTndVcys4Uk5rU0I4N3ZGYmJRczgyVDZGc1Qv?=
 =?utf-8?B?SFlvU0JST05QNnIwT1B6T0JGSmxNRXA3OXduU20wYWtpTWhMNjBReUQzYzdU?=
 =?utf-8?B?bWIya3ZmV0R6eEgyTGhadktERWdDZFhtcjlaWWlBNC82TnRQWWNuL1NlV0Jk?=
 =?utf-8?B?c0dLV05sTTkxaER0VkpoNWNNY1U5MXpSemcrTlVPbkZ6Q3FTRU5qNkdaQ24w?=
 =?utf-8?B?eFZoSjZ4aUFtajMxSkFYR3BWY3FZM2tXR2NXc2xTcmlyby9QVUN0aDYyN01h?=
 =?utf-8?B?M2FNRUJwQlNZTTJFZ3FsWUJHcHRwUXNiM0hLWlByRjVOZTVRa29rOW9ZYU96?=
 =?utf-8?B?YlRwYnRPM1hyY3J4UWZRU2tWNTFJL3FYdTY2NVZhQkJOc0lEL1FhckwzME9u?=
 =?utf-8?B?T2x4bVo5WlNBQ05KdXpOZVBGNzF1SUhLWjBaTHd6UDhuaXZIbzZXRUpkUUJx?=
 =?utf-8?B?U1BBempwdStEbzI4OENSZ3UvVFp6YnlHOXQydHNaQmJNa3BCRThRUmFJS0xG?=
 =?utf-8?B?VVRDQlBxMCsxNUU4Mml2K0tNdUc5UHRMTG94L1BZTjU1S3JIMGRJMWV4cjU1?=
 =?utf-8?B?TCtmSHdOTERreERPQWxBT1gzaEdUNHhMSlNtVGdEUTUrNXFJN29GOFBoK1oy?=
 =?utf-8?B?aU5NcEk2a2VXRVBXa1NWZ3J1Z3YrUG92OW5lQklPc2xUWTVmV2ppTkJtbktE?=
 =?utf-8?B?Ym84OUUyV2tWOG1sQkRNNzQxWGVuOC9kRzRSZUQ1Ry9vTXloNWZhSUdET1pC?=
 =?utf-8?B?ZTYvWUk5alZ2biswbm1wZXZGNTNncGpvd1VvazB6YXc0YnE4Y25JYmtQTmJ4?=
 =?utf-8?B?UFN6dUxOOU9aVnRyWFdxM3lmREtGR3NFRThucXB5emxoY3NxcGxsUVpRUEV4?=
 =?utf-8?B?c1pVc2NYM3Y3eDhwNG53TkIrSGxjWGRwL0srREhwakRNUFYrZEpadEFqVlJC?=
 =?utf-8?B?bEJJK0RKbGgvQU0wNFBuSnZaV3l3N0tVQ1RINXB6S3hZc1VNbysvUGJ0OVpC?=
 =?utf-8?B?RUkxeUZRTlNScmdwVXFQTUhhd1JHYzJxdmdPT2tDaFNOLys0aDlLUUVkZXkz?=
 =?utf-8?B?OTc1R0N5QXQyVVk0cUFTOWNqdkJNZzhQQnVWUU5zL0pCdEhYM3FDcVpUUlZv?=
 =?utf-8?B?L1lWbzMzSkJqYlFsS3cwcU50aFV6dW9NZEszWjRyOFBTSEpLWHpYTlBSZk9T?=
 =?utf-8?B?eUNQZElDUkZ3VjltcjJqREgvSzF4cmhVVFloYzJlalUvTUlKb1ZCYlV5L1lm?=
 =?utf-8?B?Z2VGckJLVnppa3BGOE5INUdKTzhlUzZKQ3FxaXNpcXA4RFI2TnhCeFI5a1Jq?=
 =?utf-8?B?Q2VXU3JKZ0pBRjBmeUVIamwrRTJTNlJRSkl2RkhVQ3NNK0lqTmtVR3hGRFBH?=
 =?utf-8?B?L1g5UEI1NzhsNE5mNThZVWpRRGQwL2thcVpqTXlzRDhEcGltOFdQU20wMm42?=
 =?utf-8?B?SEtFMGdWZStjRndLVDV0TzhSZjZhREs1cDJzTlk4T1NBSG5Yb3JUQUEwVVMw?=
 =?utf-8?B?MkxmOGlBaVhSRnJxN2I4OXYraU9UWDQrdmlsS0xpdjlnaldXYWFiS0xxTExX?=
 =?utf-8?B?SVQ4bHhnT0pjRnRaa3JzRHdCS05FNXJXbFhPNjhTV0tuUWVRbGV5UVFGcGw1?=
 =?utf-8?B?eFM4WHZrdlZwTkVrayswcGI3Z3o4SVlDcS90TG8ySU92Z3MyVHFHSXhHNk10?=
 =?utf-8?B?Y1R3MjJFTDZiTi9lUVRFRlh5Mm1lWC91L0JUYWNENm4raHNrYWJzNUpBPT0=?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 80e989fa-d9ae-4879-576f-08db12881e44
X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 14:46:43.8203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB2640
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Simon:

     Thanks for looking into this.

The revisions i proposed are complementary for the same purpose, and 
also reside in the same code segment.

I named them 2 items to clarify the details. Maybe it would be better to 
name them 2 steps in the same revision to avoid confusion.


And yes, i do have some performance result below

Testing topology

             |-----|
       nic1--|     |--nic1
       nic2--|     |--nic2
VM1(16cpus) | ovs |   VM2(16 cpus)
       nic3--|     |--nic3
       nic4--|     |--nic4
             |-----|
2 netperf client threads on each vnic

netperf -H $peer -p $((port+$i)) -t UDP_RR  -l 60 -- -R 1 -r 8K,8K
netperf -H $peer -p $((port+$i)) -t TCP_RR  -l 60 -- -R 1 -r 120,240
netperf -H $peer -p $((port+$i)) -t TCP_CRR -l 60 -- -R 1 -r 120,240

   Mode Iterations   Variance    Average

UDP_RR         10      %1.33      48472 ==> before the change
UDP_RR         10      %2.13      49130 ==> after  the change

TCP_RR         10      %4.56      79686 ==> before the change
TCP_RR         10      %3.42      79833 ==> after  the change

TCP_CRR        10      %0.16      20596 ==> before the change
TCP_CRR        10      %0.11      21179 ==> after  the change

Thanks

eddy