Date:   Sun, 19 Feb 2023 21:29:02 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Gavin Li <gavinl@nvidia.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, roopa@nvidia.com,
        eng.alaamohamedsoliman.am@gmail.com, bigeasy@linutronix.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        gavi@nvidia.com, roid@nvidia.com, maord@nvidia.com,
        saeedm@nvidia.com
Subject: Re: [PATCH net-next v3 4/5] ip_tunnel: constify input argument of
 ip_tunnel_info_opts( )
Message-ID: <Y/KGJvFutRN0YjFr@corigine.com>
References: <20230217033925.160195-1-gavinl@nvidia.com>
 <20230217033925.160195-5-gavinl@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230217033925.160195-5-gavinl@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GPGQltAwmzwR3DNJLzQIRrrdkXgvgmD1TsjdLEvhfo582qFNT9tH3Ow9MQWB?=
 =?us-ascii?Q?9y2XXKyC8xF/nfGZgbxMu3JIetWIwJKZHqcBRT6+Stul3iIoBNqLgDEDGI11?=
 =?us-ascii?Q?QR91+LzAsGghAZszw+FuPMT35wbSgc5tshA9pRUFIJAJMpioiVhuIMUrk1+9?=
 =?us-ascii?Q?mcycgVSM9irhQRRY8OoMj2L1i/5RYD+9Fs2Jh59jJo9JqJtKzahVzUVJteZT?=
 =?us-ascii?Q?OYKOuR8013edS6VMWmiwFFRwNhmqURmRmiQ4los0gjPF+qMI7vLs7ISuvlTT?=
 =?us-ascii?Q?rUpzLkXLjRqXY0Mj9WaMC3ZyULztpG0KmFNGziK9WqY/1bMg3K8CptvwjBKa?=
 =?us-ascii?Q?IZNvYIBVUJYWDX3cyrpeIr7Rs8vTVoaUsbeSqZYXO612VeAZ/y+iy8MYRtZk?=
 =?us-ascii?Q?2VXPvyOSAy0rtxgVmXRTDDzokgCcHw9AfAdWruAWe+84STt3/wYvNFfBVKAr?=
 =?us-ascii?Q?Rv7R8Bd1zEOc0aXOnoZeDfbtj41c7Js2GJm3m5ZcCRZ4uYLBDhSKGBle/SRM?=
 =?us-ascii?Q?QrtVL/R0FhjjkT6Y33v+BLEUu3CTOWTvqfxOF8/3kHWBN+w7YReel7WaGG/2?=
 =?us-ascii?Q?Akcx+Bhlphnq/a2jzafccKw5Bf77c7AE6zQe6NqucTSGA+kD9ew2a90n4iUF?=
 =?us-ascii?Q?D4bm8nQLE7GM2ayFeYIj/TNhcexHN2ihr/ceJXeZhqTRRBM7uushAPaGGuQg?=
 =?us-ascii?Q?wLf0xFv+2RXlWt3nVr3HD92NIhEqjcu5Yo5pK1rrXSKI+/cirePlOKRAkzvx?=
 =?us-ascii?Q?SV+Nf0n3MrYPPdfFVeUThXYTs2c6mIccbsA3qWF+iyAslIkDP6ejE4yP5OK3?=
 =?us-ascii?Q?YDZVqtirClRxb4QhiXhiY/G0z2v81l0c+dxacUtHNkUDXJzpRLLvXONbGkDn?=
 =?us-ascii?Q?lHKQX7un7ZH5S9Qp3z5W0cKWnz9FbARUNMCbJ2I4+0Hv4NbOBck2qaa0w2m+?=
 =?us-ascii?Q?d8V8Ygm5QU/VBZEuCcDS6ZYwi4/o2LdfQeJIwOq33b7ditd7qHBDIXNyhoF1?=
 =?us-ascii?Q?khdl8poHYjZuajRPzfT0QVt5w9jpWPQpsIUcIgVj2WU2e36xQxBuHhOzjsnG?=
 =?us-ascii?Q?OBpaT9MBcA56bLMqcyAnqFWurQ2Gu8b8uPqE6Rjm9zuZgyYGDE96oQv/oXUB?=
 =?us-ascii?Q?WQI0MhjNWDYrhvJ6+2GC/Q3Aq484kA6T4Adpi+M0US4PbmcGdWibebYUmuTU?=
 =?us-ascii?Q?5X65fNT6FXbasppgLyDxN12QnDTpwxoD+SEwhMZmA/hSG0PwSEBbG17TbjgJ?=
 =?us-ascii?Q?3K4TSLPEIPtDnZrouehduJVK6mj8ulbuNT96eS2QLwt8Jtz6N8J7/4tB4/E9?=
 =?us-ascii?Q?h60pG6RdlQRrYleQKgUgq1awMbqnq31mc7As4KNYSd6Efj1Izjp+T438oNmE?=
 =?us-ascii?Q?7sRWKewGKW8ECOnRplht00tt2RMEu1YykLD4HcCLcXFkfLrXJUcX1IaMUQqW?=
 =?us-ascii?Q?rC3mzzqUsOL2Zu0xgkX4Aoj8hbM9eLPfViDzHIvtWZySqvAhuSUO/eBOYwov?=
 =?us-ascii?Q?0gVk0Msy7ve0t36zGY9X+YIpN+hQi/gQ41lpm6qmYuV0HOcbfhJRg+JpUHMc?=
 =?us-ascii?Q?7pv7lgQPBlAfEuSuyG++g0I7y020tvIGtH5todC4X9UCRzUwBUVfqAS53aB9?=
 =?us-ascii?Q?v6uifIUGfgtAfQ2oTFeglAjE281KruCxaierX270GMOQFJ1TmwbGraPrpqzN?=
 =?us-ascii?Q?7RWhhQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dad278f0-01de-4d65-8164-08db12b7f9ee
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 20:29:18.6404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tHElW9MBWZZwZsTIvJ3/mX94tg1UFLMkI4b46hsqm/bJOodhf0/9lIWmOwkMWTl5SAhhHCQQ8dQDYjpLaWEY8AvY3q5Jzt+00kpLRhgANCk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB4556
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 17, 2023 at 05:39:24AM +0200, Gavin Li wrote:
> Constify input argument(i.e. struct ip_tunnel_info *info) of
> ip_tunnel_info_opts( ) so that it wouldn't be needed to W/A it each time
> in each driver.
> 
> Signed-off-by: Gavin Li <gavinl@nvidia.com>
> ---
>  include/net/ip_tunnels.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h
> index fca357679816..32c77f149c6e 100644
> --- a/include/net/ip_tunnels.h
> +++ b/include/net/ip_tunnels.h
> @@ -485,9 +485,9 @@ static inline void iptunnel_xmit_stats(struct net_device *dev, int pkt_len)
>  	}
>  }
>  
> -static inline void *ip_tunnel_info_opts(struct ip_tunnel_info *info)
> +static inline void *ip_tunnel_info_opts(const struct ip_tunnel_info *info)
>  {
> -	return info + 1;
> +	return (void *)(info + 1);

I'm unclear on what problem this is trying to solve,
but info being const, and then returning (info +1)
as non-const feels like it is masking rather than fixing a problem.

>  }
>  
>  static inline void ip_tunnel_info_opts_get(void *to,
> -- 
> 2.31.1
>