Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA25C636D6 for ; Mon, 20 Feb 2023 03:51:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbjBTDvw (ORCPT ); Sun, 19 Feb 2023 22:51:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbjBTDvr (ORCPT ); Sun, 19 Feb 2023 22:51:47 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C870CA2C for ; Sun, 19 Feb 2023 19:51:45 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4PKpPk67NMz4x7y; Mon, 20 Feb 2023 14:51:38 +1100 (AEDT) From: Michael Ellerman To: nathan@kernel.org, ndesaulniers@google.com, mpe@ellerman.id.au, Anders Roxell Cc: Christophe Leroy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, Arnd Bergmann In-Reply-To: <20220810114318.3220630-1-anders.roxell@linaro.org> References: <20220810114318.3220630-1-anders.roxell@linaro.org> Subject: Re: [PATCHv3, resend] powerpc: mm: radix_tlb: rearrange the if-else block Message-Id: <167686496037.2406274.4922238912170748440.b4-ty@ellerman.id.au> Date: Mon, 20 Feb 2023 14:49:20 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Aug 2022 13:43:18 +0200, Anders Roxell wrote: > Clang warns: > > arch/powerpc/mm/book3s64/radix_tlb.c:1191:23: error: variable 'hstart' is uninitialized when used here [-Werror,-Wuninitialized] > __tlbiel_va_range(hstart, hend, pid, > ^~~~~~ > arch/powerpc/mm/book3s64/radix_tlb.c:1175:23: note: initialize the variable 'hstart' to silence this warning > unsigned long hstart, hend; > ^ > = 0 > arch/powerpc/mm/book3s64/radix_tlb.c:1191:31: error: variable 'hend' is uninitialized when used here [-Werror,-Wuninitialized] > __tlbiel_va_range(hstart, hend, pid, > ^~~~ > arch/powerpc/mm/book3s64/radix_tlb.c:1175:29: note: initialize the variable 'hend' to silence this warning > unsigned long hstart, hend; > ^ > = 0 > 2 errors generated. > > [...] Applied to powerpc/next. [1/1] powerpc: mm: radix_tlb: rearrange the if-else block https://git.kernel.org/powerpc/c/d78c8e32890ef7eca79ffd67c96022c7f9d8cce4 cheers