MIME-Version: 1.0
References: <20230215075855.46204-1-acelan.kao@canonical.com> <141b6b13-00ca-c941-e315-6b2fe62e6515@amd.com>
In-Reply-To: <141b6b13-00ca-c941-e315-6b2fe62e6515@amd.com>
From:   AceLan Kao <acelan.kao@canonical.com>
Date:   Mon, 20 Feb 2023 14:54:11 +0800
Message-ID: <CAFv23Qk2yG+KPGd1s1JsY8rBfU_z-tFe6KSo6r=q7DsQ6ETL_w@mail.gmail.com>
Subject: Re: [PATCH] usb: xhci: Workaround for runpm issue on AMD xHC
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        "Tsao, Anson" <anson.tsao@amd.com>,
        "Gong, Richard" <Richard.Gong@amd.com>,
        Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
        "Oakes, Gregory" <Gregory.Oakes@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Mario,

Mario Limonciello <mario.limonciello@amd.com> =E6=96=BC 2023=E5=B9=B42=E6=
=9C=8820=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=8811:14=E5=AF=AB=E9=81=
=93=EF=BC=9A
>
> + a bunch of AMD guys
>
> Please don't submit quirks for AMD systems without talking to AMD about
> if they make sense.
Got it.

>
> On 2/15/23 01:58, AceLan Kao wrote:
> > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> >
> > When the xHC host is runtime suspended, the device connects to it will =
be
> > disconnected while trying to use it.
> > The quirk in commit 2a632815683d ("usb: xhci: Workaround for S3 issue o=
n
> > AMD SNPS 3.0 xHC") also works for this issue, so added its ID to the
> > quirk, too.
> >
> > 05:00.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Devic=
e [1022:1505] (prog-if 30 [XHCI])
> >          Subsystem: Dell Device [1028:0c3f]
> >          Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- Pa=
rErr- Stepping- SERR- FastB2B- DisINTx+
> >          Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=3Dfast >TAbor=
t- <TAbort- <MAbort- >SERR- <PERR- INTx-
> >          Latency: 0, Cache Line Size: 64 bytes
> >          Interrupt: pin A routed to IRQ 60
> >          IOMMU group: 21
> >          Region 0: Memory at c0000000 (64-bit, non-prefetchable) [size=
=3D1M]
> >          Capabilities: <access denied>
> >          Kernel driver in use: xhci_hcd
> >          Kernel modules: xhci_pci
> >
> > [   20.769275] xhci_hcd 0000:05:00.0: xHCI host not responding to stop =
endpoint command
> > [   20.771429] xhci_hcd 0000:05:00.0: xHCI host controller not respondi=
ng, assume dead
> > [   20.771444] xhci_hcd 0000:05:00.0: HC died; cleaning up
> > [   20.771733] usb 5-1: USB disconnect, device number 2
> >
> > Cc: stable@vger.kernel.org #v4.19+
> > Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
>
> Is this system that you're finding this bug already launched?  This
> looks like a BIOS bug.
>
> If it's not launched we should fix it from BIOS, reach out to AMD off
> list to talk about it.
This system is not launched yet, any hints about the BIOS issue?
I tried to disable D3Cold, but the symptom is the same.
The xHC enters D3Hot and then it can't be waken up.

>
> > ---
> >   drivers/usb/host/xhci-pci.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index fb988e4ea924..b8f6843a8cd1 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -177,7 +177,9 @@ static void xhci_pci_quirks(struct device *dev, str=
uct xhci_hcd *xhci)
> >           (pdev->device =3D=3D 0x15e0 || pdev->device =3D=3D 0x15e1))
> >               xhci->quirks |=3D XHCI_SNPS_BROKEN_SUSPEND;
> >
> > -     if (pdev->vendor =3D=3D PCI_VENDOR_ID_AMD && pdev->device =3D=3D =
0x15e5) {
> > +     if (pdev->vendor =3D=3D PCI_VENDOR_ID_AMD &&
> > +             (pdev->device =3D=3D 0x15e5 ||
> > +              pdev->device =3D=3D 0x1505)) {
> >               xhci->quirks |=3D XHCI_DISABLE_SPARSE;
> >               xhci->quirks |=3D XHCI_RESET_ON_RESUME;
> >       }
>