Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A07C636CC for ; Mon, 20 Feb 2023 07:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230385AbjBTHG6 (ORCPT ); Mon, 20 Feb 2023 02:06:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbjBTHG4 (ORCPT ); Mon, 20 Feb 2023 02:06:56 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8085876AC for ; Sun, 19 Feb 2023 23:06:27 -0800 (PST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31K6DJdX011792; Mon, 20 Feb 2023 07:05:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=VYRK02M8+UOTYkNRucj4LpDEGZGJqsNeidjeVxlb0wo=; b=sHYYwOkSrO3tyY3U1gC3S08gESfMdlC70kviEWecc4dafOaK+QJVo+m1MLxeBE+Ka5gs D+KnwTAh7J6s3A7GgSMYfypiD4RQQqUEjt+3gF51dVz2w293NmIIISWdk0DpYyRYDbAe atR0AwGOANIx5Kg3Q2ybQAIazNtO0DAmeBhybXKcei+0wkytNPkwJuUyyBgQ5AlMWSvX QhH46DOd5PV/r4vQOKnesag3H6cNYMhzD42c3EgSwGIsgNqhPinkjv69ZnwiorUdkPEO l/Hm/jN1s1CAz6YQVobDN2feuc96VFN5bkIsP//CYPdUHzK+VZhKVlBhOmHvKsmNgb2M LQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nv1ukb116-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 07:05:23 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31K6oiWn017242; Mon, 20 Feb 2023 07:05:23 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nv1ukb10a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 07:05:22 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31JJBvnV004300; Mon, 20 Feb 2023 07:05:21 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3ntpa6aa4h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 07:05:20 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31K75FjH24904026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Feb 2023 07:05:15 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EDB612004F; Mon, 20 Feb 2023 07:05:14 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B0702004D; Mon, 20 Feb 2023 07:05:11 +0000 (GMT) Received: from [9.43.104.140] (unknown [9.43.104.140]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 20 Feb 2023 07:05:10 +0000 (GMT) Message-ID: <2fa8dd2a-1650-4adc-de2b-0f14dca683ed@linux.ibm.com> Date: Mon, 20 Feb 2023 12:35:09 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] arch/powerpc/kvm: kvmppc_hv_entry: remove .global scope To: Kautuk Consul Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Fabiano Rosas , Alexey Kardashevskiy , Sathvika Vasireddy References: <20230220052355.109033-1-kconsul@linux.vnet.ibm.com> <20230220052355.109033-2-kconsul@linux.vnet.ibm.com> Content-Language: en-US From: Sathvika Vasireddy In-Reply-To: <20230220052355.109033-2-kconsul@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Cwd8NO1OLdnTNi1mF_vUHAj1GcEaxZdu X-Proofpoint-ORIG-GUID: Aw9IZiJVPuGigaHb28rp9aV6l__uls1T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-20_04,2023-02-17_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 suspectscore=0 bulkscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302200062 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kautuk, On 20/02/23 10:53, Kautuk Consul wrote: > kvmppc_hv_entry isn't called from anywhere other than > book3s_hv_rmhandlers.S itself. Removing .global scope for > this function. > > Signed-off-by: Kautuk Consul > --- > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > index acf80915f406..7e063fde7adc 100644 > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > @@ -502,7 +502,6 @@ END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S) > * * > *****************************************************************************/ > > -.global kvmppc_hv_entry > kvmppc_hv_entry: > > /* Required state: I see the following objtool warning with this patch applied. arch/powerpc/kvm/book3s_hv_rmhandlers.o: warning: objtool: .text+0x48: unannotated intra-function call Annotating kvmppc_hv_entry symbol with SYM_FUNC_START_LOCAL and SYM_FUNC_END macros should help fix this warning. Thanks, Sathvika