Message-ID: <0630025f-d7b5-320f-b5ec-2a459963d76d@amd.com>
Date:   Mon, 20 Feb 2023 09:16:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v4 04/14] dma-buf/dma-resv: Add a way to set fence
 deadline
Content-Language: en-US
To:     Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     freedreno@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>,
        Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Pekka Paalanen <ppaalanen@gmail.com>,
        Simon Ser <contact@emersion.fr>,
        Rob Clark <robdclark@chromium.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "open list:DMA BUFFER SHARING FRAMEWORK" 
        <linux-media@vger.kernel.org>,
        "moderated list:DMA BUFFER SHARING FRAMEWORK" 
        <linaro-mm-sig@lists.linaro.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230218211608.1630586-1-robdclark@gmail.com>
 <20230218211608.1630586-5-robdclark@gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230218211608.1630586-5-robdclark@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnVjc2JXUlpnc3I0NUF5TXNvZWhjNldpa3I3TFRqMXY2THZZQWdUZlZ6enJz?=
 =?utf-8?B?YzRQU2FpUGJHcjBHSUQ0RFJSUENlK21qb3VTdEtuUldnZXhubjJKZzlYWnVS?=
 =?utf-8?B?b3BBcUk2T1JkM3dCM2RSQWZsRHpyOUU1MTI3d1QwSnRIRGpLcGJVbTU4bjNv?=
 =?utf-8?B?MTV6MlZlN3hDeTF4eE5teHJGWmh6bkFKWUROclhqYll1N1ZHZ0ovZXhkMUxi?=
 =?utf-8?B?cUM0b3VtbzR3OE9zdGZ4OExRZlJqMHRIYVVRd0Nuanc0V0NYc2Z6VEFZYlAr?=
 =?utf-8?B?NUp5MmkwUUg0M3cvemgrNDA1N2pmV1cycnlRRy9vTXNMUGRsSWlrQkhMTlhs?=
 =?utf-8?B?c3hEVVpYOWFNYjhITk9tY016bkVJcEdKUTlmZlFUQ0Fkc2ZFWFFDanhrS3pt?=
 =?utf-8?B?MWQ1V05qOU1BSVJiL0JzYjhJZ2VsNmFmRzF1WWFpOE9MMmtQZjR0eDJweFVa?=
 =?utf-8?B?Uk9Hd0lUYkxJbHhrREEvRE5Fb3luQmxwTzZNdjhmMVVKRzROZXdyM2R1a3ht?=
 =?utf-8?B?RjBOeTdETVpyUjdWSzlYUkc1VzhQUFlMMXQwdmEvMW42UWNUMUpxaXJjTWRL?=
 =?utf-8?B?UEdLWmc2aXNYUlZIZnpHL2NoclhKT0ZIdlJkU3F6WFZsZHY0MzM3VDNHN1pU?=
 =?utf-8?B?U1MwM1JQbkdvTzVzTTY2M3VlWEZDNStmTnpON0JOeXh2MXVOL3IzRDFSWktQ?=
 =?utf-8?B?bTRrVjR6L3k0Ukl5M2xESStSSFRrVjFpN0VpemxpS3dSSktULy85aHR1U0dQ?=
 =?utf-8?B?WmhVUHVJWERyUmExUGwyQTVXOTArek5sTzBrNHhqY3VYM2p2S2RCVXEvRTAw?=
 =?utf-8?B?YWlNczc5UlUwWmhCWFBMWmltWW55MnJaVnMrTTM0SE1VNUdXWVEySndkNUdt?=
 =?utf-8?B?VFBrR1YwbTdZY3N1Y2JFdW9NZ2x4R0NuZ0VkQmlUNFlZaHU0VElSTkVIbk1B?=
 =?utf-8?B?T3VxeUtCTDNkOGh1MkQ4UUtKRmNCVEpkbVAxeld2ZDlYd2lyU0tScEpZRUxx?=
 =?utf-8?B?bkhJcUdoVWsvK0ViMWRmTmpFUUlEVENac2FSYmw5YmlNYXBmS21rZ1RubVBX?=
 =?utf-8?B?eXRZL3lHWHdBdE5yOS9HVU5VN0tTdGg3Qm1leHF3bEROcHAwMTZHekhGblhU?=
 =?utf-8?B?ZWFrenJlSSttNTBzUldjbmMrVzFCaEk3MnZZV0RWNFIvc24vMWhyM2FMY0VU?=
 =?utf-8?B?TU9pSVgyR2drYU5JWG4rMEZ0bSs5VGxVV24vS0ZhVktFOWtQd25mczZaL0F1?=
 =?utf-8?B?eTVWT0N3WEIrZmdJSWoyY3ZmVFpLSE1XVGhzZVBnajhmN1hkRUNPMCtaR1NY?=
 =?utf-8?B?T0tkWksrMlFqUDZVYmp6ZC9LT2ZSeVY5ZkxJb0l5Q2M1akI3WHhXb2xGeW8v?=
 =?utf-8?B?Vk1LY1RqY3lWc1hzN1VBaTVwWFUwMzkxQmx1TDZ3Y0dMci9VUktwTGFsTjdx?=
 =?utf-8?B?dDg2aVFpM084RkNpMXF3UXM3NFd5bXZveEZGdlFyUjV3RmZkTFBPdUdBMzZz?=
 =?utf-8?B?b1lXSWhIUUpkb0RMbU15bFc2MngvK0J6TDNKdG9OendFVGltZDlLN2ZtYTQ2?=
 =?utf-8?B?MUEzaE9RbHV0Q1RGS1NlYms4Q2x6UXhXeHR2V1ZzWnBiYjR6bitqMDFZTGdR?=
 =?utf-8?B?NCs4UjViUFNySkhTNWs5eENOUzFicGdNbnNCSVB2OERCYWYyNWg0SHpkcWk5?=
 =?utf-8?B?TGJ1Y3dZTkxFVnZWQ0hhSko1SWdpbkRINXFXWHVvL3A2VS9xWHpHclFzaTBB?=
 =?utf-8?B?eU4vVW5PcFQ3RzlrQy9iYnZhUThoVlRCeVpQWU93MzcxRzdmSGNtR3oyRytH?=
 =?utf-8?B?b2Jqb1VobVB4YjBwOFNjbFpLeFE2VGlPa0JTK2ZPT1oySWh5eTJQNVFMdEFn?=
 =?utf-8?B?aVlJM3ZDUUE5VklRNGg1Mml1bmpOOFE2N2x1RVEwNGNpWkxWY2M5NjhMSUdU?=
 =?utf-8?B?TTVhanB3WFRmZy9xTGlqc3JUSzhuWm5JWFp2VlJCTmxhclR1VFV1OE9zNTMw?=
 =?utf-8?B?SGt2RnYzWXNNUVk5Rnc0Nk1oc0l5aEVwM1o5SmNEWXRHVStRYTRSb09oQUs2?=
 =?utf-8?B?ZlkvTnZFVVNXZXR6aDhyUmczSlFPRkVjNkNGcDlyUHZDYTdMbkh4T0xDNCtX?=
 =?utf-8?B?dGtDN1Y4b3V3RXpRWmNka2VCa2pvSjFKd3hlRDROS2QyVmtZQitSUnpnSTls?=
 =?utf-8?Q?bKQ3VN6Te7DTLiOAPfls97SlbujTcVBU2YMmnuhDf1dV?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e03011e2-63be-4ae1-6ad4-08db131abd67
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 08:16:17.3774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: us4B/IElYoqI8/KaiTFaX4BOQ8RyrZILx+0gNFolmu8uBppwuxgr5OpdVUB3ukUr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7603
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 18.02.23 um 22:15 schrieb Rob Clark:
> From: Rob Clark <robdclark@chromium.org>
>
> Add a way to set a deadline on remaining resv fences according to the
> requested usage.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
>   drivers/dma-buf/dma-resv.c | 19 +++++++++++++++++++
>   include/linux/dma-resv.h   |  2 ++
>   2 files changed, 21 insertions(+)
>
> diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
> index 1c76aed8e262..0c86f6d577ab 100644
> --- a/drivers/dma-buf/dma-resv.c
> +++ b/drivers/dma-buf/dma-resv.c
> @@ -684,6 +684,25 @@ long dma_resv_wait_timeout(struct dma_resv *obj, enum dma_resv_usage usage,
>   }
>   EXPORT_SYMBOL_GPL(dma_resv_wait_timeout);
>   
> +/**
> + * dma_resv_set_deadline - Set a deadline on reservation's objects fences
> + * @obj: the reservation object
> + * @usage: controls which fences to include, see enum dma_resv_usage.
> + * @deadline: the requested deadline (MONOTONIC)

Please add an additional description line, something like "Can be called 
without holding the dma_resv lock and sets @deadline on all fences 
filtered by @usage.".

With that done the patch is Reviewed-by: Christian König 
<christian.koenig@amd.com>

Regards,
Christian.

> + */
> +void dma_resv_set_deadline(struct dma_resv *obj, enum dma_resv_usage usage,
> +			   ktime_t deadline)
> +{
> +	struct dma_resv_iter cursor;
> +	struct dma_fence *fence;
> +
> +	dma_resv_iter_begin(&cursor, obj, usage);
> +	dma_resv_for_each_fence_unlocked(&cursor, fence) {
> +		dma_fence_set_deadline(fence, deadline);
> +	}
> +	dma_resv_iter_end(&cursor);
> +}
> +EXPORT_SYMBOL_GPL(dma_resv_set_deadline);
>   
>   /**
>    * dma_resv_test_signaled - Test if a reservation object's fences have been
> diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h
> index 0637659a702c..8d0e34dad446 100644
> --- a/include/linux/dma-resv.h
> +++ b/include/linux/dma-resv.h
> @@ -479,6 +479,8 @@ int dma_resv_get_singleton(struct dma_resv *obj, enum dma_resv_usage usage,
>   int dma_resv_copy_fences(struct dma_resv *dst, struct dma_resv *src);
>   long dma_resv_wait_timeout(struct dma_resv *obj, enum dma_resv_usage usage,
>   			   bool intr, unsigned long timeout);
> +void dma_resv_set_deadline(struct dma_resv *obj, enum dma_resv_usage usage,
> +			   ktime_t deadline);
>   bool dma_resv_test_signaled(struct dma_resv *obj, enum dma_resv_usage usage);
>   void dma_resv_describe(struct dma_resv *obj, struct seq_file *seq);
>