Message-ID: <2e6e9581-6de8-6aca-3e73-946fbc6ad2a3@amd.com>
Date:   Mon, 20 Feb 2023 09:31:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI
Content-Language: en-US
To:     Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     freedreno@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <ckoenig.leichtzumerken@gmail.com>,
        =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>,
        Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Pekka Paalanen <ppaalanen@gmail.com>,
        Simon Ser <contact@emersion.fr>,
        Rob Clark <robdclark@chromium.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Gustavo Padovan <gustavo@padovan.org>,
        "open list:SYNC FILE FRAMEWORK" <linux-media@vger.kernel.org>,
        "moderated list:DMA BUFFER SHARING FRAMEWORK" 
        <linaro-mm-sig@lists.linaro.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230218211608.1630586-1-robdclark@gmail.com>
 <20230218211608.1630586-7-robdclark@gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230218211608.1630586-7-robdclark@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnZlWUxrZE5DNzFjVWtBeHBnZE1FUXh4NURFTjdTbHplSUN5NDA1cXFQU3VU?=
 =?utf-8?B?Q1pmeW9JNUFaTlFHVWV2UnhiZHJDSEUzVEEvRUFWK2xsbmhRU1owMnFMRm9E?=
 =?utf-8?B?NkRPUEEvMFVEckxqMFV4WnZhNURLSXJOY2RWR2tpZ0dvUVRkZUgzclBzYm5Z?=
 =?utf-8?B?cml6Q0UvT043cUhuVmlGYWx0SjdFQ3lQWWlQT3EzVWpSK3laSWp4QWZPaEVQ?=
 =?utf-8?B?a3JVWHowTFRrcmVPdnRoMmlxc09oeEREL09PaWZPeDk0NkJVbG9tY3RKQ2VN?=
 =?utf-8?B?Mnd6dkU3OUNaMzVaTEc3V2ZMQ04zYXJ6ZURLSUtIWFc4b05Ed3lpNnFYbVpZ?=
 =?utf-8?B?aE9pUlUya0x5eVpmWGNCNWpyWXhKYysxeVIzVnczMllHYnN2ZjBtbXcxdk1W?=
 =?utf-8?B?TWFhQkhPV3J2bWRJYTJzbXNLM0ptclVIK2VlcDJKYjRFR0hSUEpxTVRWT05G?=
 =?utf-8?B?akNXcUs5aWN0aSs0Y2pCcGFTdE41R2FVN1JNUkthV09qVExhK3JZQnJWMlZT?=
 =?utf-8?B?ZWltcWhhRUxiNGNucGRydmY1aWpqS1VjZll3ZHhVdnRMSlVXcmhuZUFqaHFN?=
 =?utf-8?B?R2pBLzNLKzBtWllTOHBDRG5pTTRXUXk0bXk2THNyemJZaGM4bkJGcW05KzBM?=
 =?utf-8?B?N2twcm8xM2c3cWsxZ0VJMTN6V2RzZ25EdTl6UmZNWi8wamFlQkRQOG9zdkJB?=
 =?utf-8?B?aUtTM1pHZU9HM1pWLzd4OElPaVIybnpUZzRSTHAvNWFwMjNLRHJ6RUhiQlhp?=
 =?utf-8?B?NjhuMEgwMjNqdGNRU1U1b1M5VmVyZlcxUnFVVXF5U2xxVC8yVjJVK2xwY0Ju?=
 =?utf-8?B?SHRtajFkVW9sUTZ4Z1pTWStnYTY2S2l3clk2WmRxYVE0cDQ5SmF3OHBYQ0N4?=
 =?utf-8?B?K0pIb3d3alhBN2VNVmtiTitubWZlRHhYZm5VUkJlMTZKZ1gzY3RENlcza0dz?=
 =?utf-8?B?THdyV1ZnTkJ3UFRZSTI2WGtwZm1hZ01jS3E1bzZXL2lWQzkybWtXa1MyKzAy?=
 =?utf-8?B?bVZYTEVxS1JRNHZFa1lZS2FlWk5wR0VlYzlFQ0ZERFVjV3ptcXNlTTMzaUpC?=
 =?utf-8?B?SU5rMEVFTStIaU1mSTVFWUhLU1l2ZFV4T1dqeDBRYnk0N1VOSFZ4OERnREto?=
 =?utf-8?B?SXlsdVJVa2hEdXdTZFRIKzNBTWgxWGV4a0J6a2NHRG5PYlZEbUIrMEhXQmhs?=
 =?utf-8?B?VEkvU2hac2lpNEQrMzdnTUFYeGMwVmlYWmtVWFhhOUthVXVzYmNDbWY1NlUr?=
 =?utf-8?B?ZStnOVN5akJCVWlnWDNmYUErUDhXTUtXRUlOY3NoKzNoS3dud2RyZkJybTFw?=
 =?utf-8?B?bitGSGRyTGFPWldDT2R4ZnJaaTF6RlM3UlJaaVM2aVVKS0RtZTZ1bjZScHRV?=
 =?utf-8?B?YlhoQk5WM0lia0M0RmFhbVRFMEY4c3piV3RRZmNqSlB4YW5iK1lEVE5ieTNq?=
 =?utf-8?B?TUNER3R5TmZTQ0JaakhPTXg4enByblRRK1czNVlLSzUxQzBvYUhQcDBXcnM0?=
 =?utf-8?B?SlRqMmFuWHpDUStOK2VFUk5xc3ZzMEpVOFdDYXcxbjZXQWhUbVF6WWZGcjRk?=
 =?utf-8?B?ZE5ROE1UUzQ0Y09yQTlaeWpzQ2RUdk5TZDZydFlZMnRvR0RSdzU4WmhxTHlB?=
 =?utf-8?B?Z3VxbzhFLzNveXR2Z0VCK1pSMktseHMvZk1HL3lFN0Fuak5SMyszdkxpMjA0?=
 =?utf-8?B?djVsTC9qSjdBNmRVZVUydTZET29uTVRiN1Fyekl4V00xeUhacXkzWmJteFFw?=
 =?utf-8?B?VG1vakkxb2NxMSsyVS9yeXRlTWRsemxXTVUwdmw4MUZOMGV0eEVMQk9rUWFG?=
 =?utf-8?B?WG5mL1dzZmNlaGhnRnphcXl1OVVla0VXRVN6dkt1QTZ5elMyWGZUazl0bmly?=
 =?utf-8?B?cEdwcFBNS2dsWVorNHNWeUpFUmNFSVdlWS9rd3NGV3A2WnVLTzZnWldJVDlV?=
 =?utf-8?B?TzdSbXA3aVFFcUV0QTNUTG16ZXBWcFZ1TENsYWJNR2RTbkUxbXVWUExsdTFZ?=
 =?utf-8?B?YjBYbnZuYWhwbE5wMEdIMTJvVG9IK3U4RElaS1hGL2Y1eTIvUzBtWXJpTWpn?=
 =?utf-8?B?czlTTWcyK2psMU55c0JOQVV4b0s3eEFPTnRub0E3SDk0azUwMk93Q2lRSUNE?=
 =?utf-8?B?bHhBa2RYZ2pxdG1QYjRNbFFUUVM2d3o3T1pob3dLMTNPMEViQSsvSmFNa2pY?=
 =?utf-8?Q?1VrgrfHBSeAMmCdwzFLh+2MiK872JC3qwTFxxhBV/aJs?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ec53a06-eb0c-4cc4-f7e0-08db131ce909
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 08:31:49.5313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ND2dKftjyXP6kHjAqttZPEPuWtvgymWMqDIuJq6VvYXERq37h1l5Taeq6XKybJly
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7337
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 18.02.23 um 22:15 schrieb Rob Clark:
> From: Rob Clark <robdclark@chromium.org>
>
> Allow userspace to use the EPOLLPRI/POLLPRI flag to indicate an urgent
> wait (as opposed to a "housekeeping" wait to know when to cleanup after
> some work has completed).  Usermode components of GPU driver stacks
> often poll() on fence fd's to know when it is safe to do things like
> free or reuse a buffer, but they can also poll() on a fence fd when
> waiting to read back results from the GPU.  The EPOLLPRI/POLLPRI flag
> lets the kernel differentiate these two cases.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>

The code looks clean, but the different poll flags and their meaning are 
certainly not my field of expertise.

Feel free to add Acked-by: Christian König <christian.koenig@amd.com>, 
somebody with more background in this should probably take a look as well.

Regards,
Christian.

> ---
>   drivers/dma-buf/sync_file.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c
> index fb6ca1032885..c30b2085ee0a 100644
> --- a/drivers/dma-buf/sync_file.c
> +++ b/drivers/dma-buf/sync_file.c
> @@ -192,6 +192,14 @@ static __poll_t sync_file_poll(struct file *file, poll_table *wait)
>   {
>   	struct sync_file *sync_file = file->private_data;
>   
> +	/*
> +	 * The POLLPRI/EPOLLPRI flag can be used to signal that
> +	 * userspace wants the fence to signal ASAP, express this
> +	 * as an immediate deadline.
> +	 */
> +	if (poll_requested_events(wait) & EPOLLPRI)
> +		dma_fence_set_deadline(sync_file->fence, ktime_get());
> +
>   	poll_wait(file, &sync_file->wq, wait);
>   
>   	if (list_empty(&sync_file->cb.node) &&