Date: Sun, 9 Sep 2007 09:43:43 -0700
From: Greg KH <greg@kroah.com>
To: David Miller <davem@davemloft.net>
Cc: matthew@wil.cx, shaohua.li@intel.com, linux-kernel@vger.kernel.org,
       linux-pci@atrey.karlin.mff.cuni.cz, akpm@linux-foundation.org,
       gregkh@suse.de
Subject: Re: [RFC] disable PCIE 'Enable No Snoop' bit by default
Message-ID: <20070909164343.GC9199@kroah.com>
References: <1189056908.24368.9.camel@sli10-conroe.sh.intel.com> <20070906115730.GE14130@parisc-linux.org> <20070906.054038.74750747.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070906.054038.74750747.davem@davemloft.net>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1618
Lines: 35

On Thu, Sep 06, 2007 at 05:40:38AM -0700, David Miller wrote:
> From: Matthew Wilcox <matthew@wil.cx>
> Date: Thu, 6 Sep 2007 05:57:31 -0600
> 
> > I'm not sure your analysis is correct.  Here's what my draft copy of
> > the pcie 2.0 spec says:
> > 
> >   Enble No Snoop ? If this bit is Set, the Function is permitted to
> >   Set the No Snoop bit in the Requester Attributes of transactions it
> >   initiates that do not require hardware enforced cache coherency (see
> >   Section 2.2.6.5). Note that setting this bit to 1b should not cause
> >   a Function to Set the No Snoop attribute on all transactions that it
> >   initiates. Even when this bit is Set, a Function is only permitted
> >   to Set the No Snoop attribute on a transaction when it can guarantee
> >   that the address of the transaction is not stored in any cache in
> >   the system.  This bit permitted to be hardwired to 0b if a Function
> >   would never Set the No Snoop attribute in transactions it initiates.
> >   Default value of this bit is 1b.
> > 
> > That implies that devices are only allowed to set it when it's safe to
> > do so ... and we don't need to turn it off.
> 
> This is my understanding of this area of PCI-E as well, and I
> also agree that therefore we should not turn this bit off.

I agree.  But Shaohua, do you see any problems that this patch fixes?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/