MIME-Version: 1.0
References: <20230215-wip-mcp2221-v2-1-109f71fd036e@redhat.com> <nycvar.YFH.7.76.2302201009430.1142@cbobk.fhfr.pm>
In-Reply-To: <nycvar.YFH.7.76.2302201009430.1142@cbobk.fhfr.pm>
From:   Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Mon, 20 Feb 2023 10:31:08 +0100
Message-ID: <CAO-hwJKQRL1Tp42yWL-+mJgy-_nFskc3kXEHQSFC-LSnk1cFzA@mail.gmail.com>
Subject: Re: [PATCH v2] HID: mcp-2221: prevent UAF in delayed work
To:     Jiri Kosina <jikos@kernel.org>
Cc:     Rishi Gupta <gupt21@gmail.com>,
        Pietro Borrello <borrello@diag.uniroma1.it>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 20, 2023 at 10:10 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Thu, 16 Feb 2023, Benjamin Tissoires wrote:
>
> > If the device is plugged/unplugged without giving time for mcp_init_work()
> > to complete, we might kick in the devm free code path and thus have
> > unavailable struct mcp_2221 while in delayed work.
> >
> > Canceling the delayed_work item is enough to solve the issue, because
> > cancel_delayed_work_sync will prevent the work item to requeue itself.
> >
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> Acked-by: Jiri Kosina <jkosina@suse.cz>

Thanks a lot.
I realized I was missing the Fixes 960f9df7c620 and Cc: stable tags.

I am adding those right now and will push it as soon as the minimum CI
reports back that it's OK.

Cheers,
Benjamin

>
> Thanks Benjamin.
>
> --
> Jiri Kosina
> SUSE Labs
>