From:   Benjamin Tissoires <benjamin.tissoires@redhat.com>
To:     Rishi Gupta <gupt21@gmail.com>, Jiri Kosina <jikos@kernel.org>,
        Pietro Borrello <borrello@diag.uniroma1.it>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <20230215-wip-mcp2221-v2-1-109f71fd036e@redhat.com>
References: <20230215-wip-mcp2221-v2-1-109f71fd036e@redhat.com>
Subject: Re: [PATCH v2] HID: mcp-2221: prevent UAF in delayed work
Message-Id: <167688619223.2031822.11362974798628061939.b4-ty@redhat.com>
Date:   Mon, 20 Feb 2023 10:43:12 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 16 Feb 2023 11:22:58 +0100, Benjamin Tissoires wrote:
> If the device is plugged/unplugged without giving time for mcp_init_work()
> to complete, we might kick in the devm free code path and thus have
> unavailable struct mcp_2221 while in delayed work.
> 
> Canceling the delayed_work item is enough to solve the issue, because
> cancel_delayed_work_sync will prevent the work item to requeue itself.
> 
> [...]

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.3/mcp2221), thanks!

[1/1] HID: mcp-2221: prevent UAF in delayed work
      https://git.kernel.org/hid/hid/c/47e91fdfa511

Cheers,
-- 
Benjamin Tissoires <benjamin.tissoires@redhat.com>