Date:   Mon, 20 Feb 2023 16:49:48 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Greg KH <greg@kroah.com>, Qi Zheng <zhengqi.arch@bytedance.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the driver-core tree
Message-ID: <Y/NCPC3rjOT7dJtE@debian.me>
References: <20230220163133.481e43d8@canb.auug.org.au>
 <896c1146-21bb-35bb-dc25-a12014eb5ccd@bytedance.com>
 <Y/Mh7uA61KMvMHAt@kroah.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uWTzqJDj9FojYxYY"
Content-Disposition: inline
In-Reply-To: <Y/Mh7uA61KMvMHAt@kroah.com>
Precedence: bulk


--uWTzqJDj9FojYxYY
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 20, 2023 at 08:31:58AM +0100, Greg KH wrote:
> On Mon, Feb 20, 2023 at 03:26:41PM +0800, Qi Zheng wrote:
> >=20
> >=20
> > On 2023/2/20 13:31, Stephen Rothwell wrote:
> > > Hi all,
> > >=20
> > > After merging the driver-core tree, today's linux-next build
> > > (htmldocs) produced this warning:
> > >=20
> > > Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WA=
RNING: Inline literal start-string without end-string.
> > >=20
> > > Introduced by commit
> > >=20
> > >    d3002468cb5d ("debugfs: update comment of debugfs_rename()")
> >=20
> > This is just a comment modification. Didn't see where my modification
> > caused this WARNING. :(
>=20
> Yeah, I don't understand either, here's the diff, what's wrong with it?
>=20
>=20
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
>   * exist for rename to succeed.
>   *
>   * This function will return a pointer to old_dentry (which is updated to
> - * reflect renaming) if it succeeds. If an error occurs, %NULL will be
> - * returned.
> + * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
> + * will be returned.
>   *
>   * If debugfs is not enabled in the kernel, the value -%ENODEV will be
>   * returned.

Hi Greg and Qi,

The simple fix is to drop the percent (which is an inline code variant):

---- >8 ----
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 58a35afb7c5d89..a7a6a0821605a8 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -802,7 +802,7 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
  * exist for rename to succeed.
  *
  * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * reflect renaming) if it succeeds. If an error occurs, ERR_PTR(-ERROR)
  * will be returned.
  *
  * If debugfs is not enabled in the kernel, the value -%ENODEV will be

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--uWTzqJDj9FojYxYY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY/NCMwAKCRD2uYlJVVFO
oyNHAQDDOW915RsZyzcbtOQMygi0ddnO2B/mXpXEfcMD+LITyAD/Ut85gOa1xWSB
R36OA91Eb+GT2b/+kMRyGgCXwTe7dwE=
=JcLD
-----END PGP SIGNATURE-----

--uWTzqJDj9FojYxYY--