Message-ID: <4cd266d0-0555-e1a3-f9d1-35d4179ccfd1@linaro.org>
Date:   Mon, 20 Feb 2023 11:28:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] dt-bindings: interrupt-controller: convert
 loongson,ls1x-intc.txt to json-schema
To:     Kelvin Cheung <keguang.zhang@gmail.com>
Cc:     linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
References: <20230218122236.1919465-1-keguang.zhang@gmail.com>
 <646cc26f-ed98-10fc-217b-5dc4416670a6@linaro.org>
 <CAJhJPsU7KmR1Z1uGsKUDW_=wUwr_Bg_7DwqsMD7tKWrZYQMPhw@mail.gmail.com>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CAJhJPsU7KmR1Z1uGsKUDW_=wUwr_Bg_7DwqsMD7tKWrZYQMPhw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/02/2023 11:25, Kelvin Cheung wrote:
> On Mon, Feb 20, 2023 at 4:04 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 18/02/2023 13:22, Keguang Zhang wrote:
>>> Convert the Loongson1 interrupt controller dt-bindings to json-schema.
>>>
>>> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
>>> ---
>>>  .../loongson,ls1x-intc.txt                    | 24 ---------
>>>  .../loongson,ls1x-intc.yaml                   | 51 +++++++++++++++++++
>>>  2 files changed, 51 insertions(+), 24 deletions(-)
>>>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt
>>>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt
>>> deleted file mode 100644
>>> index a63ed9fcb535..000000000000
>>> --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt
>>> +++ /dev/null
>>> @@ -1,24 +0,0 @@
>>> -Loongson ls1x Interrupt Controller
>>> -
>>> -Required properties:
>>> -
>>> -- compatible : should be "loongson,ls1x-intc". Valid strings are:
>>> -
>>> -- reg : Specifies base physical address and size of the registers.
>>> -- interrupt-controller : Identifies the node as an interrupt controller
>>> -- #interrupt-cells : Specifies the number of cells needed to encode an
>>> -  interrupt source. The value shall be 2.
>>> -- interrupts : Specifies the CPU interrupt the controller is connected to.
>>> -
>>> -Example:
>>> -
>>> -intc: interrupt-controller@1fd01040 {
>>> -     compatible = "loongson,ls1x-intc";
>>> -     reg = <0x1fd01040 0x18>;
>>> -
>>> -     interrupt-controller;
>>> -     #interrupt-cells = <2>;
>>> -
>>> -     interrupt-parent = <&cpu_intc>;
>>> -     interrupts = <2>;
>>> -};
>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml
>>> new file mode 100644
>>> index 000000000000..4cea3ee9fbb1
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml
>>> @@ -0,0 +1,51 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/interrupt-controller/loongson,ls1x-intc.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Loongson-1 Interrupt Controller
>>
>> You changed the title, so this binding now will cover all Loonson-1
>> interrupt controllers?
>>
> Yes.

OK, then with the dropped |


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof