Message-ID: <021dd47a-03e6-6d27-af3d-c7ff179fe0bd@nvidia.com>
Date:   Mon, 20 Feb 2023 18:42:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH net-next v3 4/5] ip_tunnel: constify input argument of
 ip_tunnel_info_opts( )
Content-Language: en-US
To:     Simon Horman <simon.horman@corigine.com>,
        Alexander Lobakin <aleksander.lobakin@intel.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, roopa@nvidia.com,
        eng.alaamohamedsoliman.am@gmail.com, bigeasy@linutronix.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        gavi@nvidia.com, roid@nvidia.com, maord@nvidia.com,
        saeedm@nvidia.com
References: <20230217033925.160195-1-gavinl@nvidia.com>
 <20230217033925.160195-5-gavinl@nvidia.com> <Y/KGJvFutRN0YjFr@corigine.com>
 <Y/KKiNHnJ5vHqWrf@corigine.com>
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <Y/KKiNHnJ5vHqWrf@corigine.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0tvdXNLRHJ2UkJjMnVacElHL3NmQ0RTZ0xwNTVxeHJXektwU2ZRK20vT0Vw?=
 =?utf-8?B?cWQzTzJvaDFScXFKMnF6ZStGMUNLU3dLS01ITUt6S1pVc09ZQUxUYmx4WFNQ?=
 =?utf-8?B?cnV6ZFcxcmtMRG5ibGpjckxNUHM1WXg3K2ZYQTBhTUhDcVBtejV3b2craFhU?=
 =?utf-8?B?c3Z3NklyNXMycHp3V2htdXRsRXdQcFdVWFhjdGJUVll5K3BnYldhdjlJQzAr?=
 =?utf-8?B?RjZWODlsd085eTZ5UzMwZktuNDkxaTBZeGZVM3h1WjI2V3pER1hIWXBzWlRy?=
 =?utf-8?B?bjBBWlV1WHdLK280U0JDWkNIY1RsVmhKdnNucDM2cmY3M09UOTdGRlZicFJC?=
 =?utf-8?B?Y1hjSTBSdmNkcHJENFFINkV0S1FlYm5zbkg4V3BnUUJtUkRTSGNYSGQwd0hy?=
 =?utf-8?B?MEIzY2kvMjg0VXdySERZbnZpM3hNMkpTWGF1Z09PY2pRMHFCcVBYRDJRZHBS?=
 =?utf-8?B?TTlEUlJld1VEQlhVV0dFMzA0alJZRE1wZ0NWeTYzZW54VUtZeGFmQStKN3JS?=
 =?utf-8?B?dEFaVXdHbkQxR1kzcytjMzlXT0Z6VU0wWFVnYUdqNktPd1haalZmelBGM241?=
 =?utf-8?B?Y1Rid3U5ODlmQ0pFd2o2NndyREp0UEN0WXV4cSt6dEF2WlBjbzNVMCtTcHox?=
 =?utf-8?B?MHJzYytaM0hEZEdOcVhhQkVVVFhPRThHRElLTk1xVEhzMmNzZVovbW9BdHVw?=
 =?utf-8?B?bmZjbzl4MVNWSSt5Y09JcWVhZFdCYjNqS1ByU1JNcHczNE5xTkRDSnZldXlp?=
 =?utf-8?B?dndCdmxmZkIrcVB4VWI3NWFDVlhxZ3BORiswbklDdTJ6aWx0NnU2UUR1aUdx?=
 =?utf-8?B?ZHBZNmVORnYyMEdPNitSbzB0RmdCMG5vMUZvcFEycE56TjFLTklqS1J0ZkZq?=
 =?utf-8?B?ZlNZMUF4cWZvcHd1Skl1bmRUYzdINm9EeCtYRXUvY0kvaTR0ZkpjQUZ6b3FK?=
 =?utf-8?B?MjhpdkE0MXo5aTJUaGVpbXc2a0p2a0pEUFRZM3Q4NTc2NjRwTDJ1ZlRzN2tX?=
 =?utf-8?B?NUxEN1R6UFQ4eEpSNzhLWE9lQlhJcWZHS0FMM1UwOU9MZUxXTjlvY0szU21S?=
 =?utf-8?B?NTFGalczeFd0eHpsd0Jwc1J5M21qR2ZOK01BMUpEV1h1SUsrdzJkaVhpendj?=
 =?utf-8?B?cEhsR2c2K2ZKV3dZV2FRZHhSc2FGZjJjMzQ3d0p5SEhjeGtkTlhmdUtCTWVo?=
 =?utf-8?B?VC9QUVdubjM4RFNjLzdGV0VSNEVIVk5TazhBK29BNDdpaGx5N3B2cTFXVTZx?=
 =?utf-8?B?NTM0ekozUXhrbHN4MzI0N0xiR0MvckF1aStGRE9vQkxpMEdMY1dSSDdvY2tB?=
 =?utf-8?B?WUxTYko2RVo4UjNzVnc4ZW4rNitFRnJxd3dMeVdzaFpuc2RMenNXQXVTdGdq?=
 =?utf-8?B?TC9CNkxFNzhZbzFYdXJKemw0eHBCbUg5bzBlaHpvbmkxdXBXK0hFVVB2bjcr?=
 =?utf-8?B?MWpIL2lhbHVVZHBVVUVTQ2RQNitnTGVWNlZOQVBuRGgwbjNGRkVnd3pXa1o2?=
 =?utf-8?B?Rmw3NEVLdkx2R1BXZS9pZU5Sc2loUG9wQk1FUjRnd0x1dDY0djhnY1ljYyts?=
 =?utf-8?B?U1JjRGJ4TVlDelpYZTlWN3hBSDBIQWRCdXZSVEFSeEU4MmFmRlJibERWcFhI?=
 =?utf-8?B?bGg3a0lBOXNYVzFtWVJUYnNvZmhtSUhtWEMxTVhDN1p5WmNpdGpmSnJTZGph?=
 =?utf-8?B?Ym5JZ2xycTdTLzJJcTZ2RXcrVnY3czlrdWVEbGhSbC9NcjN2YmdRdmtpcE5N?=
 =?utf-8?B?Wldib0ZnelByYW5VRlJLY2hINmtJUW1RNlRSeFBQcW1udFV5L202YXNZa2NG?=
 =?utf-8?B?UGRGeGpRTTFOODJ4M3RVUVZkNWwwaHUvU2c5ajF5RE5JRXNTek9TWjNPYk16?=
 =?utf-8?B?eHVVY0RGY0NJMkpXN1FJSHl0VzFlZW9SNDJVZHYyY2htQzl3S09wb1JiZHZj?=
 =?utf-8?B?TGpFdDljM1p5NWVRNlRXV3ZjWGZHSms2VlhPOXVZQmV1LzIxQzZyNHhwMy9v?=
 =?utf-8?B?SElXRmtUM1VSK1BueHZwWGc1Qi9OY0VJbFF1QUt5RE95M2VDT295dU9EeHhy?=
 =?utf-8?B?NVlWRHRBeEhIeGIzaWVBaVcyZWMwclNnWnZ6UFRkWjFadkxIS1VmRVRHOGtK?=
 =?utf-8?Q?uHPy/pUADJAcz73qZKVboZFNq?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2b78153-c259-4659-2213-08db132f29c1
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3835.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 10:42:28.9845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YLlgJMXPTAWXYTDDi3Pc/mVps3ZU6lDWsx6RkYYKqop2WfxdGWY9VbuI9087BbceyIXQTm3+sLP9e4DaCjUs+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5354
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/20/2023 4:46 AM, Simon Horman wrote:
> External email: Use caution opening links or attachments
>
>
> On Sun, Feb 19, 2023 at 09:29:21PM +0100, Simon Horman wrote:
>> On Fri, Feb 17, 2023 at 05:39:24AM +0200, Gavin Li wrote:
>>> Constify input argument(i.e. struct ip_tunnel_info *info) of
>>> ip_tunnel_info_opts( ) so that it wouldn't be needed to W/A it each time
>>> in each driver.
>>>
>>> Signed-off-by: Gavin Li <gavinl@nvidia.com>
>>> ---
>>>   include/net/ip_tunnels.h | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h
>>> index fca357679816..32c77f149c6e 100644
>>> --- a/include/net/ip_tunnels.h
>>> +++ b/include/net/ip_tunnels.h
>>> @@ -485,9 +485,9 @@ static inline void iptunnel_xmit_stats(struct net_device *dev, int pkt_len)
>>>      }
>>>   }
>>>
>>> -static inline void *ip_tunnel_info_opts(struct ip_tunnel_info *info)
>>> +static inline void *ip_tunnel_info_opts(const struct ip_tunnel_info *info)
>>>   {
>>> -   return info + 1;
>>> +   return (void *)(info + 1);
>> I'm unclear on what problem this is trying to solve,
>> but info being const, and then returning (info +1)
>> as non-const feels like it is masking rather than fixing a problem.
> I now see that an example of the problem is added by path 5/5.
>
> ...
>    CC [M]  drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.o
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c: In function 'mlx5e_gen_ip_tunnel_header_vxlan':
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c:103:43: error: passing argument 1 of 'ip_tunnel_info_opts' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
>    103 |                 md = ip_tunnel_info_opts(e->tun_info);
>        |                                          ~^~~~~~~~~~
> In file included from drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c:4:
> ./include/net/ip_tunnels.h:488:64: note: expected 'struct ip_tunnel_info *' but argument is of type 'const struct ip_tunnel_info *'
>    488 | static inline void *ip_tunnel_info_opts(struct ip_tunnel_info *info)
>        |                                         ~~~~~~~~~~~~~~~~~~~~~~~^~~~
> ...
>
> But I really do wonder if this patch masks rather than fixes the problem.
Hi Olek, any comment?
>
>>>   }
>>>
>>>   static inline void ip_tunnel_info_opts_get(void *to,
>>> --
>>> 2.31.1
>>>