Feedback-ID: i787e41f1:Fastmail
Date:   Mon, 20 Feb 2023 11:50:40 +0100
From:   Greg KH <greg@kroah.com>
To:     Qi Zheng <zhengqi.arch@bytedance.com>
Cc:     Bagas Sanjaya <bagasdotme@gmail.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the driver-core tree
Message-ID: <Y/NQgAXYVDAd20cg@kroah.com>
References: <20230220163133.481e43d8@canb.auug.org.au>
 <896c1146-21bb-35bb-dc25-a12014eb5ccd@bytedance.com>
 <Y/Mh7uA61KMvMHAt@kroah.com>
 <Y/NCPC3rjOT7dJtE@debian.me>
 <3a449abe-b5c8-cee3-6c2e-bfb79eb51f73@bytedance.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3a449abe-b5c8-cee3-6c2e-bfb79eb51f73@bytedance.com>
Precedence: bulk

On Mon, Feb 20, 2023 at 06:15:33PM +0800, Qi Zheng wrote:
> 
> 
> On 2023/2/20 17:49, Bagas Sanjaya wrote:
> > On Mon, Feb 20, 2023 at 08:31:58AM +0100, Greg KH wrote:
> > > On Mon, Feb 20, 2023 at 03:26:41PM +0800, Qi Zheng wrote:
> > > > 
> > > > 
> > > > On 2023/2/20 13:31, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > > 
> > > > > After merging the driver-core tree, today's linux-next build
> > > > > (htmldocs) produced this warning:
> > > > > 
> > > > > Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.
> > > > > 
> > > > > Introduced by commit
> > > > > 
> > > > >     d3002468cb5d ("debugfs: update comment of debugfs_rename()")
> > > > 
> > > > This is just a comment modification. Didn't see where my modification
> > > > caused this WARNING. :(
> > > 
> > > Yeah, I don't understand either, here's the diff, what's wrong with it?
> > > 
> > > 
> > > --- a/fs/debugfs/inode.c
> > > +++ b/fs/debugfs/inode.c
> > > @@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
> > >    * exist for rename to succeed.
> > >    *
> > >    * This function will return a pointer to old_dentry (which is updated to
> > > - * reflect renaming) if it succeeds. If an error occurs, %NULL will be
> > > - * returned.
> > > + * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
> > > + * will be returned.
> > >    *
> > >    * If debugfs is not enabled in the kernel, the value -%ENODEV will be
> > >    * returned.
> > 
> > Hi Greg and Qi,
> > 
> > The simple fix is to drop the percent (which is an inline code variant):
> > 
> > ---- >8 ----
> > diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> > index 58a35afb7c5d89..a7a6a0821605a8 100644
> > --- a/fs/debugfs/inode.c
> > +++ b/fs/debugfs/inode.c
> > @@ -802,7 +802,7 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
> >    * exist for rename to succeed.
> >    *
> >    * This function will return a pointer to old_dentry (which is updated to
> > - * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
> > + * reflect renaming) if it succeeds. If an error occurs, ERR_PTR(-ERROR)
> >    * will be returned.
> >    *
> >    * If debugfs is not enabled in the kernel, the value -%ENODEV will be
> 
> LGTM, do I need to resend the patch with this fix?

Bagas needs to send it as a real fix so that I can apply it.

thanks,

greg k-h