MIME-Version: 1.0
References: <20230218122236.1919465-1-keguang.zhang@gmail.com>
 <646cc26f-ed98-10fc-217b-5dc4416670a6@linaro.org> <CAJhJPsU7KmR1Z1uGsKUDW_=wUwr_Bg_7DwqsMD7tKWrZYQMPhw@mail.gmail.com>
 <4cd266d0-0555-e1a3-f9d1-35d4179ccfd1@linaro.org> <CAJhJPsVhCKW6qgTm30wS_NhxF5cgrGg=vvj+v--FH+pg=JAKbg@mail.gmail.com>
 <ca6ebb35-ac8e-b49f-c2ab-b65492c1b4b4@linaro.org>
In-Reply-To: <ca6ebb35-ac8e-b49f-c2ab-b65492c1b4b4@linaro.org>
From:   Kelvin Cheung <keguang.zhang@gmail.com>
Date:   Mon, 20 Feb 2023 18:54:41 +0800
Message-ID: <CAJhJPsXrG3dpcG0iMjTFfG0GAHCghtWrWDij17JBD+aHRVR-Xg@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: convert
 loongson,ls1x-intc.txt to json-schema
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 20, 2023 at 6:40 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/02/2023 11:36, Kelvin Cheung wrote:
> > On Mon, Feb 20, 2023 at 6:28 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 20/02/2023 11:25, Kelvin Cheung wrote:
> >>> On Mon, Feb 20, 2023 at 4:04 PM Krzysztof Kozlowski
> >>> <krzysztof.kozlowski@linaro.org> wrote:
> >>>>
> >>>> On 18/02/2023 13:22, Keguang Zhang wrote:
> >>>>> Convert the Loongson1 interrupt controller dt-bindings to json-schema.
> >>>>>
> >>>>> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> >>>>> ---
> >>>>>  .../loongson,ls1x-intc.txt                    | 24 ---------
> >>>>>  .../loongson,ls1x-intc.yaml                   | 51 +++++++++++++++++++
> >>>>>  2 files changed, 51 insertions(+), 24 deletions(-)
> >>>>>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt
> >>>>>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml
> >>>>>
> >>>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt
> >>>>> deleted file mode 100644
> >>>>> index a63ed9fcb535..000000000000
> >>>>> --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt
> >>>>> +++ /dev/null
> >>>>> @@ -1,24 +0,0 @@
> >>>>> -Loongson ls1x Interrupt Controller
> >>>>> -
> >>>>> -Required properties:
> >>>>> -
> >>>>> -- compatible : should be "loongson,ls1x-intc". Valid strings are:
> >>>>> -
> >>>>> -- reg : Specifies base physical address and size of the registers.
> >>>>> -- interrupt-controller : Identifies the node as an interrupt controller
> >>>>> -- #interrupt-cells : Specifies the number of cells needed to encode an
> >>>>> -  interrupt source. The value shall be 2.
> >>>>> -- interrupts : Specifies the CPU interrupt the controller is connected to.
> >>>>> -
> >>>>> -Example:
> >>>>> -
> >>>>> -intc: interrupt-controller@1fd01040 {
> >>>>> -     compatible = "loongson,ls1x-intc";
> >>>>> -     reg = <0x1fd01040 0x18>;
> >>>>> -
> >>>>> -     interrupt-controller;
> >>>>> -     #interrupt-cells = <2>;
> >>>>> -
> >>>>> -     interrupt-parent = <&cpu_intc>;
> >>>>> -     interrupts = <2>;
> >>>>> -};
> >>>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml
> >>>>> new file mode 100644
> >>>>> index 000000000000..4cea3ee9fbb1
> >>>>> --- /dev/null
> >>>>> +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml
> >>>>> @@ -0,0 +1,51 @@
> >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >>>>> +%YAML 1.2
> >>>>> +---
> >>>>> +$id: http://devicetree.org/schemas/interrupt-controller/loongson,ls1x-intc.yaml#
> >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>>>> +
> >>>>> +title: Loongson-1 Interrupt Controller
> >>>>
> >>>> You changed the title, so this binding now will cover all Loonson-1
> >>>> interrupt controllers?
> >>>>
> >>> Yes.
> >>
> >> OK, then with the dropped |
> >>
> > Sorry.
> > Should I send the patch V2 to drop the description part?
>
> Yes, please, with my tag.

Thanks for your time.
>
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>
>
> Best regards,
> Krzysztof
>


-- 
Best regards,

Kelvin Cheung