Date:   Mon, 20 Feb 2023 12:37:13 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Deepak R Varma <drv@mailo.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] perf/x86/amd/core: Use sysfs_emit() in show() callback
 function
Message-ID: <Y/NbadiYAF5exJN0@hirez.programming.kicks-ass.net>
References: <Y++ukV1djYTd01vy@ubun2204.myguest.virtualbox.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y++ukV1djYTd01vy@ubun2204.myguest.virtualbox.org>
Precedence: bulk

On Fri, Feb 17, 2023 at 10:12:57PM +0530, Deepak R Varma wrote:
> Using sprintf/snprintf functions are error prone and suggested to be
> replaced by scnprintf/vscnrptintf as outlined in this [1] LWN article.
> 
> A more recent recommendation is to use sysfs_emit() or sysfs_emit_at()
> as per Documentation/filesystems/sysfs.rst in show() callback function
> when formatting values to be returned to user-space. These helper
> functions are PAGE_SIZE aware and wrap a safer call to vscnprintf().
> 
> [1] https://lwn.net/Articles/69419/
> 
> Issue identified using the coccinelle device_attr_show.cocci script.

This Changelog fails to inform me of what the actual problem is and why
the proposed solution is better.

As such I cannot form an opinion on the patch and must decline.

(Also, I'm not going to chase down random links on the interweb,
Changelogs should be self contained)