Date:   Mon, 20 Feb 2023 11:39:40 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Dexuan Cui <decui@microsoft.com>
Cc:     Mohammed Gamal <mgamal@redhat.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
        "parri.andrea@gmail.com" <parri.andrea@gmail.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "xxiong@redhat.com" <xxiong@redhat.com>
Subject: Re: [PATCH v3] Drivers: vmbus: Check for channel allocation before
 looking up relids
Message-ID: <Y/Nb/Ba36+2CnYKf@liuwe-devbox-debian-v2>
References: <20230217204411.212709-1-mgamal@redhat.com>
 <SA1PR21MB1335BBA8DF84AFDDF2E1ABE6BFA19@SA1PR21MB1335.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SA1PR21MB1335BBA8DF84AFDDF2E1ABE6BFA19@SA1PR21MB1335.namprd21.prod.outlook.com>
Precedence: bulk

On Fri, Feb 17, 2023 at 11:17:04PM +0000, Dexuan Cui wrote:
> > From: Mohammed Gamal <mgamal@redhat.com>
> > Sent: Friday, February 17, 2023 12:44 PM
> > ...
> > --- a/drivers/hv/connection.c
> > +++ b/drivers/hv/connection.c
> > @@ -409,6 +409,10 @@ void vmbus_disconnect(void)
> >   */
> >  struct vmbus_channel *relid2channel(u32 relid)
> >  {
> > +	if (vmbus_connection.channels == NULL) {
> > +		pr_warn_once("relid2channel: relid=%d: No channels mapped!\n",
> > relid);
> 
> Looks good to me except that the line exceeds 80 characters.
> Please run "scripts/checkpatch.pl" to detect that.

FWIW the max line length has been bumped to 100 in checkpatch.pl.

> For this patch, I guess Wei may be willing to help fix it.
> 
> > +		return NULL;
> > +	}
> >  	if (WARN_ON(relid >= MAX_CHANNEL_RELIDS))
> >  		return NULL;
> >  	return READ_ONCE(vmbus_connection.channels[relid]);
> > --
> 
> Reviewed-by: Dexuan Cui <decui@microsoft.com>